312661 - Software Update 1st step displays "AUS: Update XML File Malformed (200)" if working offline

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[skierpage]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051015 Firefox/1.4.1
Build Identifier: version 1.6a1 (20051010)

If you click the lower-left icon to go offline, then choose Help > Check for
Updates... , Software Update displays "AUS: Update XML File Malformed (200)" 

Reproducible: Always

Steps to Reproduce:
1.  Run Thunderbird
2.  Click the cable icon in the lower-left status bar; or choose File > Offline
> Work Offline...
3.  Choose Help > Check for Updates... from the menu

Actual Results:  
The Software Update window displays 
"There were problems [blah blah...]
AUS: Update XML File Malformed (200)"

Expected Results:  
The error mesage is pretty confusing.  Either 
a) allow software updates while working offline
or
b) Check for Updates should alert "You are working offline.  In order to check
for updates you need to go online (click the connection icon or choose File >
Offline > Work Offline)."

My use case is I'm trying to clean up all my imported mail messages before
connecting to my ISP get more e-mails, so I want to work offline.

Comment 1

[Chris Marshall]

I got this error message while working online immediately after installing 1.5 RC 1 that I had downloaded from the internet. The steps I took were to install 1.5 RC 1 from the downloaded executable, launch Thunderbird, and immediately go to Help | Check for Updates.

One thing to note about my installation is that I'm behind a pretty heavy firewall. Does the Check for Updates feature observe the proxy settings of the product?

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5)
> Gecko/20051015 Firefox/1.4.1
> Build Identifier: version 1.6a1 (20051010)
> 
> If you click the lower-left icon to go offline, then choose Help > Check for
> Updates... , Software Update displays "AUS: Update XML File Malformed (200)" 
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1.  Run Thunderbird
> 2.  Click the cable icon in the lower-left status bar; or choose File > Offline
> > Work Offline...
> 3.  Choose Help > Check for Updates... from the menu
> 
> Actual Results:  
> The Software Update window displays 
> "There were problems [blah blah...]
> AUS: Update XML File Malformed (200)"
> 
> Expected Results:  
> The error mesage is pretty confusing.  Either 
> a) allow software updates while working offline
> or
> b) Check for Updates should alert "You are working offline.  In order to check
> for updates you need to go online (click the connection icon or choose File >
> Offline > Work Offline)."
> 
> My use case is I'm trying to clean up all my imported mail messages before
> connecting to my ISP get more e-mails, so I want to work offline.
> 

Comment 2

[Dave Miller [:justdave]]

Confirming bug, I've hit this myself as well.

Comment 3

[Dave Miller [:justdave]]

For reference, Firefox pretends to (but actually doesn't) check, and tells you there are no updates available if you attempt to check while offline.  This is almost worse because then the user thinks they checked successfully when there might be something critical pending they would otherwise get notified about if they knew they had to go online first.

Comment 4

[Justin Kerk]

This doesn't just apply to when you've set Firefox to work offline, it also happens when you try to check for updates and the Internet connection isn't working properly.

Comment 5

[Johannes Buchner]

FULL ACK to both of you. 
But if we are in offline mode, we know that, so a info msg is possible. If can't connect to the update server, we also have a msg. 
Btw, this should be changed from "AUS: Update XML File Malformed (200)" to something more user friendly like "Couldn't connect to update server, check your internet connection and try again."

Comment 6

[Johannes Buchner]

This bug concerns Firefox too and should probably be marked for "Product: Update".

Comment 7

[Bill Gianopoulos [:WG9s]]

This seems to now occur even if online and on alternate attempts to check for updates.  This occurs even if the product is up-to-date.

Steps to reproduce:

1.  download and install latest branch nightly.
2.  Go to Help -> Check for Updates
3. repeat step 2 several times.

Results are you will find that on alternate tries it will either give the malformed update error or tell you your product is up-to-date.

This does NOT occur with Firefox.

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to comment #7)
> This seems to now occur even if online and on alternate attempts to check for
> updates.  This occurs even if the product is up-to-date.
> 
> Steps to reproduce:
> 
> 1.  download and install latest branch nightly.
> 2.  Go to Help -> Check for Updates
> 3. repeat step 2 several times.
> 
> Results are you will find that on alternate tries it will either give the
> malformed update error or tell you your product is up-to-date.
> 
> This does NOT occur with Firefox.
> 
Hmm. I just changed Firefox from the Beta channel to the nightly channel and it now behaves approximately the same as Thunderbird.

It does not appear to be an every other time thoguh more like every third attempt fails.

Comment 9

[v1ctor_n]

It said that a new update was ready so i did it and now it wont let me search the web...and when i went to check for updates this came up:AUS: Update XML File Malformed (200) what is goin on??

Comment 10

[Scott MacGregor]

we didn't get any traction on this bug.

Comment 11

[Patrick Best]

I downloaded the nightly build from last night February 5th, and then it updated just about 20 minutes ago at 4:20pm February 6th. I was online, and it updated automatically. Then i decided to see if there were any other updates and that error of AUS: UPdate XML File Malformed (200) came up. Not sure why it is doing this. I don't understand the error. Any one working on this at the moment? If so, contact me and I'll try and help as well.

Comment 12

[Peter D]

Actually, this exact problem DOES occur online - in my case - with FIREFOX version 2. . . Search for Bug 358915 in the database . . .

Peter D

(In reply to comment #7)
> This seems to now occur even if online and on alternate attempts to check for
> updates.  This occurs even if the product is up-to-date.
> 
> Steps to reproduce:
> 
> 1.  download and install latest branch nightly.
> 2.  Go to Help -> Check for Updates
> 3. repeat step 2 several times.
> 
> Results are you will find that on alternate tries it will either give the
> malformed update error or tell you your product is up-to-date.
> 
> This does NOT occur with Firefox.
> 

Comment 13

[Sandra Gresham]

I had this problem with Firefox, but now, after three attempts to re=download update, got a message that said "Thunderbird need to close" , while I was trying to get my registration email...

Unfortunately, I did not have the error reporting tool installed as I had never had a problem with either Firefox or Thunderbird before this incident.

I do not know enough to fix this myself..what should I do?
Can anyone help me, please?

Comment 14

[skierpage]

This bug is for Thunderbird's 100% reproducible alert when you are in WORK OFFLINE mode.

You can also get the same alert if you have network problems, but that's a different case, try bug 358915.

Comment 15

[skierpage]

(In reply to comment #3)
> For reference, Firefox pretends to (but actually doesn't) check, and tells you
> there are no updates available if you attempt to check while offline.

That's not what I get running FF3 (Gran Paradiso) nightly "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070508 Minefield/3.0a5pre ID:2007050804 [cairo]".  If I set File > Work Offline in Firefox I get exactly the same misleading "AUS: Update XML File Malformed (200)" alert as in Thunderbird

So this bug is common between Thunderbird and Firefox; I'm not sure what its product and component should be.

Comment 16

[Phil Ringnalda (:philor)]

It should be Toolkit: Software Update; too bad neither bug 271978 nor bug 292026 has been fixed, so that doesn't actually exist.

Comment 18

[Mike Connor [:mconnor]]

Seth, this isn't immediately needed, but need this for beta 1.

Comment 19

[Phillip M. Jones, C.E.T.]

In Thunderbird I found what appears to be the cause. There is a file in the profile called compatibility.ini.

Found by experiment. I created a new profile for TB. I found this file and noticed it was up to date. 

Then in my original profile found that it was months old. So on a hunch, I made a copy. removed the old one inserted this new one.

then I left the folder open for the default profile. When I hit check for update it worked with the error and several new files appeared.

This was in TB for Mac OSX.4.9 But might work for FF as well.

Comment 20

[(not reading, please use [e-mail] instead)]

Ken Kovash hit this, but is 90% sure he wasn't haven't internet connectivity problems at the time.

Comment 21

[(not reading, please use [e-mail] instead)]

clearing bogus blocking flag.

While this doesn't block 1.8.1.6, I'd like to get it on the radar (for firefox 2.0.0.6 / tbird 2.0.0.6).  

The plan is to fix this for trunk, back port it to the MOZILLA_1_8_BRANCH and then seek approval.

Comment 22

[Phillip M. Jones, C.E.T.]

Another thing I have noticed is that if you check as soon as you open Thunderbird, you receive this message. If after you have read some mail after downloading Mail You don't seem have the problem. (This is after I had replaced the file as described in my comment of 6-18-2007.

Curious thing is I've never had this problem with error message on any version of Firefox.

I get the message both on my Laptop Mac Powerbook 17" 1.67GB using X.4.9 (and now .10) and on my G4-500 Desktop 500Mb using OSX.3.9. Common thread between the two is same ISP and same 768K DSL connection.

Comment 23

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 24

[Phillip M. Jones, C.E.T.]

What I see is somewhat similar to your screen shot though taking into account differences for I am using the standard Thunderbird install. I've long ago given up test alpha and beta  version. And My using the Mac OSX Platform (OSX.3.9 and 4.10) 

Comment 25

[Carsten Book [:Tomcat]]

(In reply to comment #24)
> What I see is somewhat similar to your screen shot though taking into account
> differences for I am using the standard Thunderbird install. I've long ago
> given up test alpha and beta  version. And My using the Mac OSX Platform
> (OSX.3.9 and 4.10) 
> 

Is the same for Thunderbird and Firefox 1.8. Builds . When you run Thunderbird in offline mode, you get also a AUS Error message

Comment 26

[Phillip M. Jones, C.E.T.]

I found I think the link to the problem. if for some reason you try as soon as you open Thunderbird you get this problem. I have not set to work off air.

"If" however; you download some messages and create some activity, then try it works fine with out the message.

For some reason the download server is not recognizing that Thunderbird is active until sees indication of recent activity.

By the way: the Last sentence should read:

And I am using the Mac OSX Platform (OSX.3.9 and 4.10). 

I haven't given up on Using Macintosh as it implies. Sorry. 

Comment 27

[(not reading, please use [e-mail] instead)]

not currently working on this, back to nobody.

one thing we should check out is, in addition to what happens when you manually check for updates, what happens if the update timer files and you check for updates in the background and your offline?

Comment 28

[Marcia Knous [:marcia]]

This message persists with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9b4pre) Gecko/2008020504 Minefield/3.0b4pre. If we could improve the error messaging for final ship this would be great, since I think it will be confusing to end users if they accidentally end up offline. I should also check what happens in the scenario that seth describes in Comment 27.

Comment 29

[Phillip M. Jones, C.E.T.]

This should have been fixed ages ago. And now it been propagated to OSX.5 as reported by Marcia.

If they are going to use the same or similar set up on the new SeaMonkey based on this setup and FF3, I hope this bug don't creep in.

Comment 30

[Phillip M. Jones, C.E.T.]

(In reply to comment #29)
> This should have been fixed ages ago. And now it been propagated to OSX.5 as
> reported by Marcia.
> 
> If they are going to use the same or similar set up on the new SeaMonkey based
> on this setup and FF3, I hope this bug don't creep in.
> 

And by the way it still is a problem on the latest 2.0.14 version both in OSX.3.9 and 10.4.11. Just updated a day or so ago. 

Comment 31

[Serge Gautherie (:sgautherie)]

(See bug 407838 comment 4 on how I got the details.)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008050302
SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

In this bug, we get:
Actual code :   0 (undefined string)
Default code: 200 (= "Update XML File Malformed (200)")
from
<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/mozapps/update/src/nsUpdateService.js.in&rev=1.150&mark=2109-2114#2091>

While it seems we would want to get
"2152398864 = Network is Offline (Go online)"
<http://mxr.mozilla.org/seamonkey/search?string=2152398864&case=on&tree=seamonkey>
<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/base/public/nsNetError.h&rev=1.12&mark=184-189#183>

Comment 32

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <nsUpdateService.js> Fix |status| declaration & value, ++

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008050302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

For this bug:
*|onError()|: fix |var status| declaration(s), ignore |0| value (!), optimize code.

Unrelated, but while there:
*|getStatusTextFromCode()|: optimize code and make message more explicit/different.
*|onStopRequest()|: merge duplicated string.

***

This patch fixes the "front-end" part of this bug:
with it, we get
Actual code : 2152398918 (undefined string)
Default code:        200 (= "Update XML File Malformed (200)")

So, basically, bug 407838 comment 4 and this bug become duplicates, waiting for the same "backend" fix.

Comment 33

[Robert Strong (they/them - no direct email)]

Comment on attachment 319281 [details] [diff] [review]
(Av1) <nsUpdateService.js> Fix |status| declaration & value, ++

Looks fine and thanks

Comment 34

[Mike Schroepfer]

Comment on attachment 319281 [details] [diff] [review]
(Av1) <nsUpdateService.js> Fix |status| declaration & value, ++

This issue has existed for quite some time so I don't think we should fix it right before RC1 without a good set of tests to run through each code path here to confirm the behavior is correct.   Please re-nom or bring to drivers if you disagree.

Comment 35

[Serge Gautherie (:sgautherie)]

(In reply to comment #34)
> (From update of attachment 319281 [details] [diff] [review])
> This issue has existed for quite some time so I don't think we should fix it

I thought |wanted‑firefox3+| meant this was wanted.

> right before RC1 without a good set of tests to run through each code path here

I don't know how to create tests (for this).

> to confirm the behavior is correct.   Please re-nom or bring to drivers if you
> disagree. 

I won't bother. Asking |wanted1.9.0.x?| instead.

Comment 36

[Phillip M. Jones, C.E.T.]

This bug both in Firefox and Thunderbird has existed much of the time of version 2. No people are recomending it be shelved and looked at when it his version 3. This should have been fixed the minute it first happened. Sound like either no one knows how to fix it. or don't wish to take the time to fix it. 

Comment 37

[Serge Gautherie (:sgautherie)]

(In reply to comment #36)
> Sound like
> either no one knows how to fix it. or don't wish to take the time to fix it. 

I beg your pardon ?
My patches (here and) in bug 407838 do fix this/these.

Comment 38

[Steffen Wilberg]

Is this ready for checkin?

Comment 39

[Serge Gautherie (:sgautherie)]

(In reply to comment #38)
> Is this ready for checkin?

<testnsUpdateService.js> could be where to add the test.
But I still don't know how to write it:
helpwanted !

Comment 40

[Robert Strong (they/them - no direct email)]

I'm adding unit tests for Application Update in bug 446527 and will take a look at what it would take to test this in the next few days

Comment 41

[Serge Gautherie (:sgautherie)]

Attachment: (Bv0) |Checker.onError()| test

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080813014450 SeaMonkey/2.0a1pre] (home, optim default) (W2Ksp4)

Eventually, I managed to write this (wip) test.

Without the patch:
FAIL: inStatus = 0, code = 200, expected = 12

With the patch:
PASS: inStatus = 0, code = 12, expected = 12

***

What do you think of it ?

The one thing I still don't know how to do is how to report the success/failure: as (text and/or) "exit" code.

Comment 43

[Robert Strong (they/them - no direct email)]

Comment on attachment 333718 [details]
(Bv0) |Checker.onError()| test

I've got a test that uses the harness... patch coming up

Comment 44

[Robert Strong (they/them - no direct email)]

Attachment: test [Checkin: Comment 49]

Comment 45

[Robert Strong (they/them - no direct email)]

Serge, I'm going to combine your patches from this bug and bug 407838... I'll also get them checked in.

Comment 46

[Robert Strong (they/them - no direct email)]

Attachment: patch including the patch from bug 407838 [Checkin: Comment 49]

Comment 47

[Serge Gautherie (:sgautherie)]

(In reply to comment #43)
> (From update of attachment 333718 [details])
> I've got a test that uses the harness... patch coming up

This looks much better ;-)
But it lacks to test the other cases: see comment 34 :-(

(In reply to comment #45)
> Serge, I'm going to combine your patches from this bug and bug 407838... I'll
> also get them checked in.

Fine with me :-)

Comment 48

[Robert Strong (they/them - no direct email)]

Tests for the other states can be added later as a general test.

Comment 49

[Robert Strong (they/them - no direct email)]

Checked in to mozilla-central

http://hg.mozilla.org/mozilla-central/index.cgi/rev/85c82edb887a09ec61b36ba3945cb34dcba35e42

Comment 50

[Robert Strong (they/them - no direct email)]

Thanks Serge!

Comment 51

[Serge Gautherie (:sgautherie)]

(In reply to comment #48)
> Tests for the other states can be added later as a general test.

And you filed bug 451164 ;-)

Comment 52

[Robert Strong (they/them - no direct email)]

Yep... I'd like it to have general tests that use XMLHttpRequest and nsIUpdateCheckListener to return the actual codes vs. simulation of the codes.

Comment 53

[Daniel Veditz [:dveditz]]

Unfortunately "fixed in 3.1" will have to do, we're not going to relocalize these strings for a 3.0.x security update.

Comment 54

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with builds on OS X and Windows:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090213 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090213020445