313219 - Table wrapped inside marquee is cropped

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

See url testcase, the table should not be cropped like that. This is a
regression from bug 277208.

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

This fixes it.
If it is really not done adding marquee code to quirk.css (which I can
imagine), I could maybe hack something up by adding <html:style>marquee table {
 white-space: nowrap;}</html:style> to <content> for horizontal marquee
binding.

Comment 2

[Martijn Wargers (dead)]

Attachment: testcase

On the other hand, this would then not work well anymore, so the fix would break other things.
Probably this is something that is difficult to fix anyhow.
The best way to get this fixed is returning to use xul:hbox instead of div style="display:table". But that would depend on bug 307763.

Comment 3

[Martijn Wargers (dead)]

A possible solution is to put an extra <div style="display:-moz-box"> between innerdiv and the surrounding <div style="display:table">. It would not trigger bug 307763. 
But xul:hboxes also suffer from 313750, which means that this would cause a regression in https://bugzilla.mozilla.org/attachment.cgi?id=98119 from bug 167075.
The vertical marquee would not scroll completely anymore.

It's probably best to keep current situation, as long as bug 307763 and bug 313750 are not fixed.

Comment 4

[Martijn Wargers (dead)]

And the use of xul:hboxes would regress bug 276729.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I can't seem to reproduce this on trunk...

Comment 6

[Martijn Wargers (dead)]

Attachment: testcase2

Sorry, the first testcase describes a situation that doesn't work with the patch I attached.

This testcase describes what wrong in current situation. The table is cropped currently, but shouldn't be, because IE6 doesn't crop it.

Comment 7

[Boris Zbarsky [:bzbarsky]]

So the real issue is that the text wraps, right?

Comment 8

[Martijn Wargers (dead)]

Yes.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Should the anonymous stuff inside the marquee have white-space: nowrap set on it?  Or should things sometimes wrap inside the marquee?

Comment 10

[Martijn Wargers (dead)]

(In reply to comment #9)
> Should the anonymous stuff inside the marquee have white-space: nowrap set on
> it?  Or should things sometimes wrap inside the marquee?

Yes, setting the anonymous stuff to white-space: nowrap should help with testcase2, but that would break the first testcase (at least that's what I said in comment 2).
With using xul:hbox instead of display:table, you don't need to use white-space: nowrap, but that has other, more serious problems, bug 277208 and bug 313750. So afaict, there isn't a solution, atm.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Hmm...  The first testcase already doesn't wrap; how would this be worse?

Comment 12

[Martijn Wargers (dead)]

Well, it would not be worse, but we would trade one bug for the other.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Trade this bug for what other?

Comment 14

[Martijn Wargers (dead)]

I was gonna say, for the case of testcase1, but I must have been tripping when I made that testcase, because I don't see a difference after I've applied the patch.

But the thing is, white-space: nowrap is already set on stuff inside the marquee:
http://lxr.mozilla.org/seamonkey/source/layout/style/xbl-marquee/xbl-marquee.xml#648
The problem is that this isn't inherited by tables in quirks mode:
http://lxr.mozilla.org/seamonkey/source/layout/style/quirk.css#98
So the patch is adding some extra rules to quirk.css to prevent that from happening.
So I guess that patch would be suitable then, but I suspect you don't like the adding of marquee rules to quirk.css. 

Comment 15

[Boris Zbarsky [:bzbarsky]]

I have no problem with inheriting white-space into tables inside marquees in quirks mode...  Do we really need the "marquee table" rule?  Can we get away with "marquee > table"?  The latter is a _lot_ faster.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

This is fixed on the latest hourly now that bug 363285 landed.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061211 Minefield/3.0a1 ID:2006121112 [cairo]