Closed Bug 365436 Opened 19 years ago Closed 19 years ago

gBrowser is undefined in reporterOverlay.js file, very easy solution

Categories

(Other Applications Graveyard :: Reporter, defect)

1.8 Branch
x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 313359

People

(Reporter: linuxed7, Assigned: raccettura)

References

()

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 Anytime I open the customize toolbar window I receive the following error after dragging a new button onto my toolbar. Error: gBrowser is not defined Source File: chrome://reporter/content/reporterOverlay.js Line: 74 This error can be solved by replacing the existing onBrowserLoad() function in the reporterOverlay.js file with the one below. function onBrowserLoad() { var win = Components.classes["@mozilla.org/appshell/window-mediator;1"]. getService(Components.interfaces.nsIWindowMediator). getMostRecentWindow("navigator:browser"); win.gBrowser.addProgressListener(reporterListener); } Reproducible: Always Steps to Reproduce: 1. Right click on the toolbar 2. Click customize 3. Drag a new button onto your toolbar 4. Open the Error Console to view the error I also receive an additional error when I drag a new button onto the toolbar. Warning: assignment to undeclared variable gDraggingFromPalette Source File: chrome://global/content/customizeToolbar.xul Line: 1 This error only occurs if you have your javascript.strict preference set to true. But it's an easy fix. Just add the code below to the customizeToolbar.xul file or simply add 'var' in front of the gDraggingFromPalette variable. <script type="application/x-javascript"> var gDraggingFromPalette; </script>
Assignee: nobody → robert
Component: Toolbars → Reporter
Product: Firefox → Other Applications
QA Contact: toolbars → xul-client
Version: unspecified → 1.8 Branch
One issue per bug, please, and you'll save yourself some time if you check to be sure things are still an issue on the trunk before you fix them in a branch build: in this case, those were bug 313359 (and reporter didn't need to add another observer to some window it was already observing, just to be sure there was a gBrowser before trying to use it), and bug 297648 (where you can see that gDraggingFromPalette didn't need to be defined, just removed, since it was dead code).
Status: UNCONFIRMED → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: