314019 - Should sort by approval date rather than date uploaded (for recently updated, newest lists, searches and RSS feeds)

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[vnagarjuna]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

Since there is a variable amount of time between submitting an extension for approval and its acceptance (one hour to 3 weeks in my experience), I think 'New Additions' tab should be based on approval date. It is good for an extension to be listed there (at least for a few hours) as it provides more visibility.

Reproducible: Always

Comment 1

[alanjstr]

I agree.  It makes more sense to show them as they're approved.

Comment 2

[Michael Morgan [:morgamic]]

This requires addition of another date column.  The approval_date will be added at a datetime type column in version.

I addition to this, it would be best for new additions to be listed approximately 30 minutes after approval to give them time to propagate to FTP servers.

This would require adjustments of public queries on listing pages, and we should also add proper notification in outgoing emails that are sent to developers on approval.

Comment 3

[Michael Morgan [:morgamic]]

The following query needs to be run on production to add the approval_date column to `version` so we can display extensions as they are approved, instead of based on when they entered the queue:

ALTER TABLE `version` ADD `DateApproved` DATETIME NOT NULL AFTER `DateUpdated` ;

Having this column will allow us to modify the additem.php script to update this time when an extension is approved.  This could help reduce the liklihood of people clicking and attempting to install an extension that hasn't been rsync'd to the FTP mirrors yet, because it would let the public listings list items 30 min or so after the approval time.

Comment 4

[Michael Morgan [:morgamic]]

Ack.  Sorry -- bug 322596 already dealt with the query.

The problem is that the databases coming over from reptile do not have these changes, so for whatever reason it didn't take.

If it DID take, then at the very least the dump on chameleon (/data/db/mozilla-update.sql) is not pulling from production, which is a problem as well.

Comment 5

[Michael Morgan [:morgamic]]

*** Bug 336111 has been marked as a duplicate of this bug. ***

Comment 6

[Michael Morgan [:morgamic]]

*** Bug 299377 has been marked as a duplicate of this bug. ***

Comment 7

[Cameron]

*** Bug 338101 has been marked as a duplicate of this bug. ***

Comment 8

[Cameron]

*** Bug 343433 has been marked as a duplicate of this bug. ***

Comment 9

[Mel Reyes]

while it might be more related to Bug 343433, I would try changing the release notes on an individual release that has already been approved, I think maybe that bumps an extension right to the recently updated list, I don't want to try again since I don't want to bump my extensions unnecessarily.

Comment 10

[Cameron]

Atm, simply modifying the description of your addon will bump it to the top of the newest list. Adjusting the description.

Comment 11

[Cameron]

*** Bug 346432 has been marked as a duplicate of this bug. ***

Comment 12

[Cameron]

*** Bug 278661 has been marked as a duplicate of this bug. ***

Comment 13

[DonGato]

I won't open a new bug as I think this issue fits here very well, or I should say it would be fixed by implementing this request.

Well, I was astonished at what Cameron confirms in the post #10 yesterday while changing some wording to one of the themes I maintain.

IMO it shouldn't be this way. You correct a spelling mistake and your extension is automatically bumped. At least, let the developer decide if the change merits a bump of the extension/theme.

Comment 14

[Michael Morgan [:morgamic]]

v3 should solve this problem by not storing .xpi's on the mirror network.  Pushing to 3.0.  We will evaluate this pre-launch, and write tests for it as well.

Comment 15

[Fred Wenzel [:wenzel]]

This was fixed a while ago: Remora indeed sorts the "newest" list by approval date. Thanks everyone.