314047 - address autocomplete ignores additional email addresses when there is only one card that matches

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect)

Description

[Jeff Bernstein]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051025 Firefox/1.5
Build Identifier: Thunderbird/version 1.5 (20051025)

When composing a message to an individual in the address book with two email addresses (Email and Additional Email), autocomplete does not give the option to send mail to the Additional Email address.  Instead, it automatically assumes you want to send email to the primary email address.

Reproducible: Always

Steps to Reproduce:
1. Create an address book entry for Joe Smith with email [e-mail] and additional email [e-mail].
2. Compose a new message and type "joe" (without the quotes, of course) in the to: line.

Actual Results:  
Thunderbird assumes you want to send your message to [e-mail].

Expected Results:  
Autocomplete dropdown allowing choice of both email addresses.

If you create a second address book entry for Joe Smith with an email address of [e-mail], the autocomplete dropdown seems to work normally, showing all three addresses.

This problem did not exist in TB 1.0.7.

Comment 1

[Magnus Melin [:mkmelin]]

Seems to work fine over here.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051026 Thunderbird/1.5 ID:2005102604

Comment 2

[Jeff Bernstein]

So perhaps it's a Windows-only issue?

Comment 3

[Jeff Bernstein]

More information: This only seems to occur when there are no other possible autocomplete options for the string you've entered.

For example, if you already have an entry for Josh Smith in your address book, then my test case above fails when you enter J or JO and wait for the autocomplete.  In that case, both Joe1 and Joe2 appear as possible autocomplete options.

However, if you retry the test case with a contact name that does not share its first few letters in common with any other entries (for example, name your test contact YYY ZZZ, on the assumption that no other contacts begin with YYY) and give that contact two email addresses, when entering YY in the address field of a new message, TB will assume you want to autocomplete with the first address and will not let you choose the second one.

Comment 4

[Magnus Melin [:mkmelin]]

With the additional info in comment 3 I can reproduce. 

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051026 Thunderbird/1.5 ID:2005102604

Comment 5

[Felix Pahl]

Attachment: patch to show autocomplete popup for two matches

This patch should fix this bug, most likely also bug 318892, and possibly also bug 330757, bug 262093 and bug 261497. minResultsForPopup is set to 3 in the autocomplete cell of the compose window to suppress popups showing only one match and the @my.domain completion. There is code in mailnews/compose/resources/content/MsgComposeCommands.js to set minResultsForPopup to 2 if autocompleteToMyDomain is false, but there is no corresponding code in the corresponding Thunderbird file mail/components/compose/content/MsgComposeCommands.js. The attached patch inserts the code from the former in the latter and fixes the bug. I guess this should tell us something about the downsides of this sort of partial code duplication.

Comment 6

[Felix Pahl]

Sorry, that should have been bug 318992, not 318892.

Comment 7

[Jerry Baker]

I apologize for my ignorance, but what is autocompleteToMyDomain in the patch? It sounds like it only would work for addresses within the same domain as my email address.

Comment 8

[David :Bienvenu]

this patch looks like it's already in the trunk...am I missing something? Or can you attach a patch with more context, e.g., diff -uwp8

Comment 9

[David :Bienvenu]

autocompleteToMyDomain is a per-identity hidden pref, which defaults to false in 1.5

Comment 10

[Jerry Baker]

OK. The source appears to say that this just affects whether or not the current identity's domain is appended to autocomplete addresses. I'm not sure how this affects bug 318992 since the domain of the address book entries are irrelevant.

Comment 11

[Jerry Baker]

Received: from mail.cpinternet.com ([209.240.224.81] helo=cpinternet.com)
	by osaka.hostforweb.net with esmtp (Exim 4.52)
	id 1FONFq-0000oT-1O
	for [e-mail]; Tue, 28 Mar 2006 17:05:38 -0600
Received: from [64.61.212.40] (unverified [64.61.212.40]) 
	by cpinternet.com (SurgeMail 3.6a) with ESMTP id 67903166 
	for <[e-mail]>; Tue, 28 Mar 2006 17:05:44 -0600 CST
Message-ID: <[e-mail]>
Date: Tue, 28 Mar 2006 17:06:03 -0600
From: Mike Cowperthwaite <[e-mail]>
User-Agent: Thunderbird 2.0a1 (Windows/20060328)
MIME-Version: 1.0
To:  [e-mail]
Subject: Bug 314047 / bug 318992
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Rather than spamming 314047 with your musings, why don't you spam your 
own bug?  Or better yet, wait until the patch for that bug goes in and 
see if it actually fixes your bug?  All you're doing right now is 
creating distractions to the people who are actually trying to fix 
something.

Comment 12

[Felix Pahl]

David is right, almost the same code was already in the trunk -- I wasn't using the latest source -- sorry for wasting some of your and a lot of my time...
At least a couple of bugs can hopefully be buried now.
Jerry, bug 318992 is likely to be affected not because the domains of the addresses matter but because minResultsForPopup = 3 is appropriate only if autocompleteToMyDomain always adds a third address to any two matches. If this is off (as it is by default), minResultsForPopup = 3 suppresses the popup that should present the two choices.

Comment 13

[Magnus Melin [:mkmelin]]

Seems this was fixed (at least for branch, trunk too from the comments) with a checkin for bug 324521. Works fine on on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060330 Thunderbird/2.0a1 ID:2006033004 

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mail/components/compose/content&command=DIFF_FRAMESET&file=MsgComposeCommands.js&rev2=1.72.2.10&rev1=1.72.2.9

Comment 14

[Wayne Mery (:wsmwk)]

*** Bug 318992 has been marked as a duplicate of this bug. ***