314208 - 'Check for Updates...' doesn't check for extension updates

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Steffen Wilberg]

"Check for Updates..." only checks for app updates, but not extension updates.
Just watch the JS Console when you click "Find Updates" EM; that doesn't happen when you select "Check for Updates".

Comment 1

[Steffen Wilberg]

Attachment: patch

Also explains the process of downloading and installing an update by restarting Firefox. Also explains the various labels of the menuitem (except Resume Downlading), see http://lxr.mozilla.org/mozilla1.8/source/browser/base/content/utilityOverlay.js#501

Comment 2

[Jeff Walden (gone starting June 8)]

Comment on attachment 201241 [details] [diff] [review]
patch

>+  <p>Displays a dialog which checks for updates to &brandShortName; and asks
>+    you whether you want to download available updates. After an update has been

This seems to be biased toward there typically being available updates, but in release versions this will be the exception (versus the behavior to which we've become accustomed in nightlies).  I think changing "available updates" to "updates if any are available" would ameliorate this problem.

>+    downloaded, it asks you to restart &brandShortName; so that the update can

"it" is a vague term here.  I know you're trying to refer to the updater itself, but there's no difference between the application and the updater to the user.  I'm not sure what's the best way to resolve this.

>+    be installed. While an update is being downloaded, this menu item is
>+    labelled "Downloading &brandShortName; (version)...". If an update is ready
>+    to be installed and &brandShortName; is waiting for you to restart it, this
>+    menu item is labelled "Apply Downloaded Updates Now...".</p>

I'm not convinced that enumerating the different labels for the menu item is a good idea; I think it's more a waste of space than a genuine help to the user.  Perhaps mentioning, "This menu item's name will change while an update is being downloaded and installed." might do the trick, but I'm not entirely sure.

Comment 3

[Steffen Wilberg]

Attachment: patch v1.1

> I think changing "available updates" to
> "updates if any are available" would ameliorate this problem.
Fixed.

> >+    downloaded, it asks you to restart &brandShortName;
> 
> "it" is a vague term here.  I know you're trying to refer to the updater
> itself, but there's no difference between the application and the updater to
> the user.  I'm not sure what's the best way to resolve this.
Of course it's all Firefox, but I meant a certain little part of it which is the the update dialog, which asks you to restart now or later, so I replaced "it" with "the dialog".

> Perhaps mentioning, "This menu item's name will change while an update is being
> downloaded and installed." might do the trick, but I'm not entirely sure.
How about "The name of this menu item will change when an update is being downloaded or ready to be installed."?

Comment 4

[Jeff Walden (gone starting June 8)]

Comment on attachment 201963 [details] [diff] [review]
patch v1.1

(In reply to comment #3)
> How about "The name of this menu item will change when an update is being
> downloaded or ready to be installed."?

Put an "is" before "ready to be installed" and start the sentence with "Note that" (because it feels more like an aside than an integral part of the menu item's docs but doesn't really deserve the space a full "Note: ..." paragraph would give it) and r=me.

To the approver: this is a simple fix to make our documentation of one menu item a little more accurate; Firefox currently doesn't check for updates to extensions when Tools > Check for Updates... is invoked (tho it once did), so we'd like to fix it.

Comment 5

[Scott MacGregor]

Comment on attachment 201963 [details] [diff] [review]
patch v1.1

In the past we've been flexible in approving help only changes. I don't think we can approve changes to the help viewer for the branch anymore because we believe we have final bits in hand and don't plan on respinning. 

So we'd never see this change anyway.

Comment 6

[Steffen Wilberg]

Attachment: patch v1.2

Review comments addressed.

Comment 7

[Steffen Wilberg]

Trunk checkin:
Checking in mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/menu_reference.xhtml,v  <--  menu_reference.xhtml
new revision: 1.36; previous revision: 1.35

Comment 8

[Robin Monks]

*** Bug 317525 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Schroepfer]

Comment on attachment 202553 [details] [diff] [review]
patch v1.2

Please land on 1.8 and 1.8.1 branches.

Comment 10

[Steffen Wilberg]

Checked into 1.8 and 1.8.0 branches.

Comment 11

[Dave Liebreich [:davel]]

verified on mac, build 2006010904

Comment 12

[Dave Liebreich [:davel]]

verified on mac, build 2006011103 (a 1.8.0.1 build)