315962 - Add Lightning buttons to Thunderbird toolbar by default

Status: VERIFIED INVALID

(Calendar :: Lightning Only, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

In addition to packaging the images, we may want to add some or all of these buttons to the toolbar by default.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

*** Bug 315961 has been marked as a duplicate of this bug. ***

Comment 2

[Joey Minta]

Attachment: overlay customizeToolbar.xul

All of the actual packaging, etc already seems to be in place.  If I drag a button to the toolbar, then a nice icon shows up without a problem.  The only bug I found was that icons don't show up inside the actual customize toolbar window.  This patch adds an overlay to that xul file so that the css rules can be applied.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 205479 [details] [diff] [review]
overlay customizeToolbar.xul

I'd suggest switching from <overlay></overlay> to <overlay/>.  r=dmose with or without that change.

Comment 4

[Joey Minta]

Comment on attachment 205479 [details] [diff] [review]
overlay customizeToolbar.xul

patch checked in, leaving bug open for adding buttons to the toolbar by default.  Suggestions as to what those buttons should be?

Comment 5

[Joey Minta]

Setting this back to default to try and unload a bit of my assigned bugs.  Anyone interested in working on the remaining part of this should look at http://forums.mozillazine.org/viewtopic.php?t=189667 (scroll down several comments).

Comment 6

[Simon Paquet [:sipaq]]

(In reply to comment #5)
> Setting this back to default to try and unload a bit of my assigned bugs. 
> Anyone interested in working on the remaining part of this should look at
> http://forums.mozillazine.org/viewtopic.php?t=189667

Joey, what do you think of this: 
http://forums.mozillazine.org/viewtopic.php?p=1105811#1105811

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #6)
> (In reply to comment #5)
> > Setting this back to default to try and unload a bit of my assigned bugs. 
> > Anyone interested in working on the remaining part of this should look at
> > http://forums.mozillazine.org/viewtopic.php?t=189667
> 
> Joey, what do you think of this: 
> http://forums.mozillazine.org/viewtopic.php?p=1105811#1105811
> 

While that poster's logic is reasonable, the number of people who customize their toolbar is likely to be exceedingly small (ie only a fraction of power users).  I would suggest that the case to optimize for is the vast majority / non power-user.  So if we think that discoverability / convenience is given a good enough boost by putting it in the toolbar by default (and I kinda suspect it is), I think leaving the power users to tweak anything they don't like is the right thing to do.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

This shouldn't really block 0.1; the current state may be ugly, but it's usable.

Comment 9

[Stefan Sitter [:ssitter]]

Update summary to reflect remaining issues.

Comment 10

[Stefan Sitter [:ssitter]]

*** Bug 356828 has been marked as a duplicate of this bug. ***

Comment 11

[Martin Schröder [:mschroeder]]

This bug is invalid with checkin of patch from bug 371916. -> Nominating for marking INVALID.