Change throbber images to PNGs or TIFFs, fix bad pixels (also optimize other GIFs)

VERIFIED FIXED in Camino1.0

Status

VERIFIED FIXED
13 years ago
13 years ago

People

(Reporter: samuel.sidler+old, Assigned: mikepinkerton)

Tracking

({polish, verified1.8})

unspecified
Camino1.0
PowerPC
Mac OS X
polish, verified1.8
Bug Flags:
camino1.0 +

Details

Attachments

(1 attachment)

11.57 KB, application/zip
Details
We have one PNG in our throbber list. We should change that to a GIF in line with the others. In addition, I think we can optimize our GIFs a bit more.
(Reporter)

Comment 1

13 years ago
I'd like this for 1.0, thought it definitely isn't "important".
Target Milestone: --- → Camino1.0
(Reporter)

Updated

13 years ago
Summary: Change throbber PNG to GIF (also optimize other GIFs) → Change throbber PNG to GIF, fix bad pixels (also optimize other GIFs)
(Reporter)

Comment 2

13 years ago
Actually, looking at our current throbber, I think it does need to be in 1.0. Anyone who uses the throbber will see white pixels as it "throbs" (or spins as it were). This is *very* ugly.

Jasper, do you have these images without the dead pixels?

(Note, I'm on 10.4, so this may just show bad with the unified look...)
Flags: camino1.0?
Keywords: polish
I don't see any white pixels in 10.3.9, but boy do those GIFs look awful compared to the PNG in large size (in small size, my default, so much of the detail and clarity is lost, so you can't tell much different between them).
(Reporter)

Comment 4

13 years ago
Yeah, the GIFs look horrible. We should convert them all to TIFFs with transparency, I think.

I kind of guessed you'd only be able to see the white against the unified style, which is why we missed them for so long...
Summary: Change throbber PNG to GIF, fix bad pixels (also optimize other GIFs) → Change throbber images to PNGs or TIFFs, fix bad pixels (also optimize other GIFs)

Comment 5

13 years ago
Created attachment 203054 [details]
new TIFF throbber

The zip file contains 12 32px sized optimized TIFF icons for the throbber. The actual spinner is 24px in size. When using the small icons in the toolbar the throbber is as big as it was before (17px).
OMG!  That looks amazing, Jasper!  I can actually see it turning clearly in small mode!

I still think that the "resting state" image should be blank (so you can tell if it's really at rest/page finished or stalled at that particular frame/page stalled in loading, but this looks so much better than the old one that I'd be willing to let that slide for a while (and it looks like having a resting-state image that doesn't also appear in the midst of the animation would require a code change, so...).
(Reporter)

Comment 7

13 years ago
(In reply to comment #6)
> I still think that the "resting state" image should be blank (so you can tell
> if it's really at rest/page finished or stalled at that particular frame/page
> stalled in loading, but this looks so much better than the old one that I'd be
> willing to let that slide for a while (and it looks like having a resting-state
> image that doesn't also appear in the midst of the animation would require a
> code change, so...).
> 

That's bug 287709 kind of, no?
(In reply to comment #7)
> (In reply to comment #6)
> > I still think that the "resting state" image should be blank  
> That's bug 287709 kind of, no?

Yeah.  I was just elsewhere when I was writing that, and then discovered it needed a code change anyway....
(Reporter)

Comment 9

13 years ago
WOW. This is such an improvement. Land it! :D

Updated

13 years ago
Flags: camino1.0? → camino1.0+
This will get fixed when the other icons from bug 314632 land.
Depends on: 314632
This is now fixed per the checkin for bug 314632.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
v on branch and trunk.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8 → verified1.8
You need to log in before you can comment on or make changes to this bug.