316177 - command-line options for "-compose" broken

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[intendentedelleacque]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it-IT; rv:1.7.12) Gecko/20050920 Firefox/1.0.7
Build Identifier: Mozilla-Thunderbird version 1.5 Beta 1 (20050908)

It seems that in TB 1.5 the syntax of commands line described at http://www.mozilla.org/docs/command-line-args.html for the option "-compose" is broken. 

Reproducible: Always

Steps to Reproduce:
1. enter the command 
thunderbird -compose to='[e-mail]',cc='[e-mail]',subject="something",body="Something else",attachment="file://path/to/file" 

Actual Results:  
With TB 1.5 you will have a message compose window, without any address in "to" and "cc" fields, any text in body and any attachment.

On the contrary, in TB 1.0.7 you will have a message compose window with to='[e-mail]',cc='[e-mail]',subject="something",body="Something else",attachment="file://path/to/file" 



Expected Results:  
Also in TB 1.5 you should have  a message compose window with to='[e-mail]',cc='[e-mail]',subject="something",body="Something else",attachment="file://path/to/file" 

A partial workaround is to use the command

thunderbird -compose "mailto:somebody@somewhere?cc=address@provider&subject=hi&body=Hell" 

But in this you can't pass any attachment, for the security restriction http://lxr.mozilla.org/mailnews/source/mailnews/compose/src/nsSmtpUrl.cpp#96

Comment 1

[Magnus Melin [:mkmelin]]

-> new
 using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Thunderbird/1.5 ID:2005111106

Comment 2

[Mike Cowperthwaite]

Same under Windows.  Not a problem with the compose window, it's a problem with parsing the command line.

Comment 3

[Magnus Melin [:mkmelin]]

blockig1.8.0.1/blocking1.8.1?

Comment 4

[Scott MacGregor]

Could this be related to the new command line hander stuff we added for 1.5 benjamin?

Comment 5

[Benjamin Smedberg]

It sure could... I didn't realize that anything other than a mailto: URI was an acceptable argument for the -compose flag, so the code only handles that case:

http://lxr.mozilla.org/mozilla/source/mailnews/compose/src/nsMsgComposeService.cpp#1395

Comment 6

[changdong.cui]

Attachment: handle other cases,not only "mailto:"

handle other cases such as "to","cc",ect.

Comment 7

[Karsten Düsterloh]

Comment on attachment 208061 [details] [diff] [review]
handle other cases,not only "mailto:"

Is <http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsSmtpUrl.cpp#96> an issue here?

Comment 8

[Mike Cowperthwaite]

See also bug 313457.

Comment 9

[changdong.cui]

(In reply to comment #7)
> (From update of attachment 208061 [details] [diff] [review] [edit])
> Is
> <http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsSmtpUrl.cpp#96>
> an issue here?
> 

in 'mailto' syntax , you can't pass any attachment, for the security restriction.
just as the Description said.

Comment 10

[changdong.cui]

(In reply to comment #8)
> See also bug 313457.
> 
what is the meaning?
#316177 depends on it?

Comment 11

[Mike Cowperthwaite]

(In reply to comment #10)
> (In reply to comment #8)
> > See also bug 313457.
> > 
> what is the meaning?
> #316177 depends on it?

Sorry, didn't mean to be cryptic.  No, I don't think this bug depends on or blocks that one, but the problem seen there is a similar regression in parsing the command line, where a file path is being treated as a URL.

Comment 12

[Benjamin Smedberg]

Comment on attachment 208061 [details] [diff] [review]
handle other cases,not only "mailto:"

bah, this hack is spiraling out of control :-(

Comment 13

[Scott MacGregor]

I wasn't aware that we ever handled anything but a mailto url here. Interesting.

Comment 14

[Steve Wendt]

*** Bug 322011 has been marked as a duplicate of this bug. ***

Comment 15

[Elmar Ludwig]

*** Bug 323550 has been marked as a duplicate of this bug. ***

Comment 16

[Vidar Haarr (not reading bugmail)]

Attachment: nautilus-actions script to attach files to e-mails

This bug broke the nautilus-actions[1] script I wrote for my parents that add a "Send to contact..." context menu item to all files, and either launches TB with a compose window or uses XRemote to invoke a new compose window in an already running instance.

Obviously, the XRemote part still works.

Anyone know how I can get this working again for 1.5?

1: <http://www.grumz.net/?q=taxonomy/term/2/9> <http://cvs.gnome.org/viewcvs/nautilus-actions/>

Comment 17

[Vidar Haarr (not reading bugmail)]

I'd like to re-request blocking1.8.0.2? but since blocking1.8.0.1 was turned down with no explanation, I guess it wouldn't do much.

Comment 18

[Benjamin Smedberg]

blocking1.8.0.1- because there isn't a thunderbird release planned from 1.8.0.1

Comment 19

[Scott MacGregor]

fixed on the trunk. Please verify there if you can. 

Comment 20

[Philip Puryear]

*** Bug 325371 has been marked as a duplicate of this bug. ***

Comment 21

[Scott MacGregor]

Vidar, care to verify that this is working again on the trunk builds? 

Comment 22

[Vidar Haarr (not reading bugmail)]

(In reply to comment #21)
> Vidar, care to verify that this is working again on the trunk builds? 

I'll try to verify with <http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk/thunderbird-1.6a1.en-US.linux-i686.tar.bz2>.

Comment 23

[Vidar Haarr (not reading bugmail)]

Attachment 209690 [details] works with todays nightly trunk build on Linux (20060201).

Comment 24

[Lasantha Marian]

(In reply to comment #22)
> I'll try to verify with
> <http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk/thunderbird-1.6a1.en-US.linux-i686.tar.bz2>.
> 
Thanks for Resolving this problem. Build from this link works as how it used to be with 1.0.7.

Unfortunately the win32 build (2006-02-01-06-mozilla1.8/thunderbird-1.5.en-US.win32.zip) is not working yet.

I appreciate your effort in resolving this bug. I have a 70+ installation which is yet to be upgraded, but avoided due to this bug.

Anticipating to see it being available in Thunderbird 1.5 (win32) branch.

Comment 25

[Benjamin Smedberg]

Attachment: Supplementary fix

There was a logic bug in the original code that could read past the end of the commandline array. I've committed this on trunk.

Comment 26

[Benjamin Smedberg]

Attachment: Supplementary fix, corrected :-(

Comment 27

[Lasantha Marian]

(In reply to comment #24)
> (In reply to comment #22)

> Unfortunately the win32 build
> (2006-02-01-06-mozilla1.8/thunderbird-1.5.en-US.win32.zip) is not working yet.

No luck with the version at (http://ftp.mozilla.org/pub/mozilla.org/thunderbird/tinderbox-builds/patrocles-mozilla1.8/thunderbird-1.5.en-US.win32.zip) or (http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2006-02-02-08-mozilla1.8/thunderbird-1.5.en-US.win32.zip).

Comment 28

[Scott MacGregor]

Comment on attachment 208061 [details] [diff] [review]
handle other cases,not only "mailto:"

this has baked on the trunk long enough.

Comment 29

[intendentedelleacque]

Thanks for your efforts in resolving the bug.
A question: what means  "Target Milestone: Thunderbird2.0"?
Does it mean that the bug won't be fixed in 1.5.0.1 version of TB (if it will be released)?

Comment 30

[Lasantha Marian]

Please kindly let us know whether the fix for this bug will be available in any release to come soon, if so what release will it be ?

Build at 
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2006-02-06-15-mozilla1.8.0/thunderbird-1.5.0.1.en-US.win32.zip does not yet contain the fix.

Comment 31

[intendentedelleacque]

(In reply to comment #30)
> Please kindly let us know whether the fix for this bug will be available in any
> release to come soon, if so what release will it be ?
> Build at 
>http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2006-02-06-15-mozilla1.8.0/thunderbird-1.5.0.1.en-US.win32.zip
> does not yet contain the fix.

You should find the fixed releases at http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk/
(latest trunk of today is of  06-Feb-2006)

Comment 32

[Lasantha Marian]

(In reply to comment #31)
> You should find the fixed releases at
> http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk/
> (latest trunk of today is of  06-Feb-2006)
> 
Thanks, but it points to 1.6x branch, whereas I am interested in 1.5x branch. 

Well 1.6x releases are updated with the fix, which I noticed since 2006-02-02.

Comment 33

[Lasantha Marian]

(In reply to comment #32)
> Thanks, but it points to 1.6x branch, whereas I am interested in 1.5x branch. 
> 
> Well 1.6x releases are updated with the fix, which I noticed since 2006-02-02.
> 
Thanks a lot guys.

Release 1.5.0.1 (20060208) from this link (http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2006-02-08-05-mozilla1.8.0/thunderbird-1.5.0.1.en-US.win32.zip) works well as it used to be with 1.0.7 as per '-compose' CLI option.

Could we expect 1.5.0.1 to be released soon ?

Comment 34

[Magnus Melin [:mkmelin]]

*** Bug 330021 has been marked as a duplicate of this bug. ***

Comment 35

[Tracy Walker [:tracy]]

verified with Thunderbird 1.5.0.2 20060308

Comment 36

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 using the steps to reproduce from comment#0 and Thunderbird 2 RC 2 (Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620)