31685 - changing "use secure connection" doesn't affect the icons in the folder pane until restart (toggling SSL connection type does not immediately show lock)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

if I add a new news server, say secnews.netscape.com, it shows up with the
normal news icon in the folder pane.

if I go to the account manager dialog, and check the "use secure connection
(SSL)." checkbox, the icon doesn't turn into a secure news server icon until I
restart.

I'm sure the same goes for secure imap.

Comment 1

[Alec Flett]

need to reflect this into RDF.

Comment 2

[Alec Flett]

moving non-critical bugs to M20

Comment 3

[Alec Flett]

over to sspitzer, probably pretty easy

Comment 4

[Alec Flett]

argh, actually reassign

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 76786 has been marked as a duplicate of this bug. ***

Comment 6

[(not reading, please use [e-mail] instead)]

I think I know what needs to be done.

when SetIsSecure() is called, we need to notify any listeners on the folder 
(the root folder for the server) that the boolean property nc:IsSecure has 
changed.

I just got done doing something similar for bug #85088.  shouldn't be had at 
all.

we'll probably need to expose a new method on nsIMsgFolder, like 
boolPropertyChanged(), otherwise we'd have to copy over a lot of notification 
code that already lives in nsMsgFolder.cpp into nsMsgIncomingServer.cpp

still future, as I'm too busy to get to this right now.

Comment 7

[Mike Cowperthwaite]

*** Bug 177885 has been marked as a duplicate of this bug. ***

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 278552 has been marked as a duplicate of this bug. ***

Comment 9

[[e-mail]]

Attachment: Non-working patch :-(

Well, I've based this on the other notifications, and I traced with gdb and I
get as far as calling nsMsgRDFDataSource::NotifyPropertyChanged so I don't
understand why the display doesn't update. Any ideas?

Comment 10

[[e-mail]]

Attachment: Fixed patch

Turned out I had isSecure and aIsSecure the wrong way around.

Comment 11

[[e-mail]]

*** Bug 301114 has been marked as a duplicate of this bug. ***

Comment 12

[Mike Cowperthwaite]

Neil, is this checked in?  Does it affect Thunderbird or is it suite-specific?

Comment 13

[[e-mail]]

(In reply to comment #12)
>Neil, is this checked in?
It is now ;-)
>Does it affect Thunderbird or is it suite-specific?
No, this is core code.

Comment 14

[Frank Wein [:mcsmurf]]

Comment on attachment 171454 [details] [diff] [review]
Non-working patch :-(

clearing obsolete review request