85088 - "Select Offline" dialog needs to be switched to use the outliner

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P2)

Description

[Håkan Waara]

Because the "Select Offline" dialog uses the same rules as the folderpane does,
switching the folderpane over to outliner (and thus changing the rules to be
outliner-specific) will break this tree's icons.

We need to make it so this dialog can use its icons regardless of folderpane's
rules... Like the subscribe dialog does it.

I guess this should be high priority, but this is really your call.

Comment 1

[David :Bienvenu]

Not sure if it was Diane or Mohan who did this dialog - taking a guess.

Comment 2

[(not reading, please use [e-mail] instead)]

short term:  we'll need a new .css file for this dialog.  probably copy the old 
folerpane.css to offline.css, and reference that from the "Select Offline" 
dialog.

long term:  like all other multiple column tree widgets, we'll need to switch 
to the outliner.

Comment 3

[[e-mail]]

Perhaps as a workaround you can use the folderMenuItem rules? They are almost
the same as the folderTreeItem rules except that they apply to all tree columns
so that the checkboxes look odd :-)

Comment 4

[Diane Sun]

Attachment: Add offline.css to the theme

Comment 5

[Håkan Waara]

I take it you just copied folderPane.css and made it offline.css?

There are many rules there that the offline command doesn't need IIRC.

Also, this doesn't have to land before the folder_outliner branch.

Comment 6

[Diane Sun]

In the modern theme,  it is not completed copied since a lot of items we don't 
need in the offline.css.

Comment 7

[Diane Sun]

Request R & SR,  Bhuvan,  Hakan, Seth?

Comment 8

[Håkan Waara]

I don't think this fix is the best possible fix. You shouldn't have to use CSS
at all to fix this bug.

Maybe look at how the subscribe tree does it?

The Select Offline dialog doesn't need to use nearly as many CSS rules as the
folderpane does.

Comment 9

[Diane Sun]

It is true we don't use many CSS rules in the select offline dialog. Any reason 
not to use CSS at all,  or we should use other approach,  please advise.

Comment 10

[Håkan Waara]

If it's not too much work, I think you should glance at the subscribe tree and
try to use that approach (non-css).

Comment 11

[(not reading, please use [e-mail] instead)]

diane, hold of on this bug.

we need to switch this dialog from using a tree to using an outliner.

I'm working with hwaara and jan to land the folder pane outliner changes, and
after that, we'll work on converting this dialog to the outliner.

if we do that right, this dialog can continue to use folderpane.css.

I'll investigate how much work it will be to do that, and get back to you.

it shouldn't be much.

Comment 12

[(not reading, please use [e-mail] instead)]

updating summary.  this bug has morphed.

Comment 13

[Blake Ross]

Doesn't look like this is getting fixed before the freeze tonight.  Folder pane
outliner has a few kinks in it, as well.  Pushing out a milestone.  Please
correct if I'm mistaken.

Comment 14

[(not reading, please use [e-mail] instead)]

taking.  I plan on fixing this and landing it with the fix for #73865

Comment 15

[(not reading, please use [e-mail] instead)]

ok, I've got this started.

I'll attach a patch.

I've got some issues I still need to figure out before it is complete.

Comment 16

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 17

[(not reading, please use [e-mail] instead)]

Attachment: start of the fix.

Comment 18

[(not reading, please use [e-mail] instead)]

that patch won't work unless you've got the lastest patch to #73865.

here are the things I need to finish before this is ready to land:

1) only show those accounts that support offline (currently, pop is showing up.)
2) column header titles aren't showing up
3) checkbox images for the "synch" column
4) checkboxes for folders only (not servers)
5) I'm performing expand on the imap servers, but it's not prompting me for 
login.
6) toggling synch state works, but not showing up in the outliner until I force 
it. 

Comment 19

[(not reading, please use [e-mail] instead)]

> 1) only show those accounts that support offline
> (currently, pop is showing up.)

> 2) column header titles aren't showing up

working on a fix to #2 (thanks to jan for the help).

jan's also got some ideas about #1, we're talking over aim.

Comment 20

[(not reading, please use [e-mail] instead)]

Attachment: updated screen shot

Comment 21

[(not reading, please use [e-mail] instead)]

Attachment: updated diff.

Comment 22

[(not reading, please use [e-mail] instead)]

> 1) only show those accounts that support offline
> (currently, pop is showing up.)
> 2) column header titles aren't showing up

thanks to some help from jan, both of those are fixed.

now on to items 3-6

Comment 23

[(not reading, please use [e-mail] instead)]

> 3) checkbox images for the "synch" column
> 4) checkboxes for folders only (not servers)

ok, I got 3 and 4 working.  here comes a new diff and new screen shot.

Comment 24

[(not reading, please use [e-mail] instead)]

Attachment: update diff

Comment 25

[(not reading, please use [e-mail] instead)]

Attachment: updated screen shot

Comment 26

[(not reading, please use [e-mail] instead)]

> 6) toggling synch state works, but not showing up in the outliner until I 
force it.

I've got this fixed.  the patch will be included in the patch for #73865

two remaining problems:

5) I'm performing expand on the imap servers, but it's not prompting me for 
login.
7) not always painting check / dots (sometimes I have to force a repaint.)

Comment 27

[(not reading, please use [e-mail] instead)]

fixed.  there are some issues and open bugs to fix, but the basics work.

this needed to be done since folderPane.css got rewritten, and this is really a 
folder pane.

I'll go log any new bugs that I know about, and cc dianesun and gchan.

Comment 28

[grylchan]

Commercial builds
2001082703 - win nt 4.0
2001082708 - linux 2.2, mac 9.0.4

Verified on both modern/classic themes.

Other than bugs already filed (bug 95377 , bug 95378) looks
ok to me.

Marking as verified.