317003 - Change the listing of valid fields values in bug_email.pl

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Tiago Ratto]

Since the valid values aren't described on the table field type anymore, it's necessary to chance the validation Subs of bug_email.pm to use the descriptor tables.

This is part of the reply:

     You sent wrong priority-setting, valid values are:varchar(64

*  The priority is set to the default value ''

     You sent wrong bug_severity-setting, valid values are:varchar(64

*  The bug_severity is set to the default value 'normal'

     You sent wrong platform-setting, valid values are:varchar(64

*  The rep_platform is set to the default value 'All'

     You sent wrong OS-setting, valid values are:varchar(64

*  The op_sys is set to the default value 'Linux'


These are the Subs that have to be changed:

sub CheckPriority
sub CheckSeverity
sub CheckPlatform
sub CheckSystem

Comment 1

[Tiago Ratto]

> Since the valid values aren't described on the table field type anymore, it's
> necessary to chance the validation Subs of bug_email.pm to use the descriptor
> tables.
> 
> This is part of the reply:
> 
>      You sent wrong priority-setting, valid values are:varchar(64
> 
> *  The priority is set to the default value ''
> 
>      You sent wrong bug_severity-setting, valid values are:varchar(64
> 
> *  The bug_severity is set to the default value 'normal'
> 
>      You sent wrong platform-setting, valid values are:varchar(64
> 
> *  The rep_platform is set to the default value 'All'
> 
>      You sent wrong OS-setting, valid values are:varchar(64
> 
> *  The op_sys is set to the default value 'Linux'
> 
> 
> These are the Subs that have to be changed:
> 
> sub CheckPriority
> sub CheckSeverity
> sub CheckPlatform
> sub CheckSystem
> 

Acctually, the only Sub that have to be changed is Sub getEnumList

(In reply to comment #0)

Comment 2

[Tiago Ratto]

Attachment: Patch v1

Comment 3

[Frédéric Buclin]

*** Bug 321843 has been marked as a duplicate of this bug. ***

Comment 4

[Vlad Dascalu]

This is a bug introduced by bug 146104 , so the fix should go in 2.20.

Comment 5

[Vlad Dascalu]

Comment on attachment 203538 [details] [diff] [review]
Patch v1

You are inconsistent with spacing near the equal sign ("=") and near the ( ) signs:

-    my @all_sever = getEnumList( "bug_severity" );
+    my $all_sever = getEnumList("bug_severity");

-    my @all= getEnumList( "area" );
+    my $all= getEnumList( "area" );

-    my @all = getEnumList( "rep_platform" );
+    my $all = getEnumList( "rep_platform" );

but that can be fixed upon checkin.

Comment 6

[Vlad Dascalu]

Not sure if we need approval for contrib.

Comment 7

[Vlad Dascalu]

Checking in contrib/bug_email.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v  <--  bug_email.pl
new revision: 1.32; previous revision: 1.31
done
Checking in contrib/bug_email.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v  <--  bug_email.pl
new revision: 1.31.2.1; previous revision: 1.31
done
Checking in contrib/bug_email.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v  <--  bug_email.pl
new revision: 1.28.2.1; previous revision: 1.28
done