318817 - bookmark keyword and description annotations

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Brian Ryner (not reading)]

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

At the same time, make sure that they have a decent name in the UI, like "shortcuts" or something else less easily confused with tags/folders/categories. 

-> Joe Hughes, load balancing. 

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

I'm going to toss this back to brian for the back end. I don't think this requires much, not even anything on the api, since access can be done using the anno-svc api. Joe can wire up the fe. 

Also brian, can you store an annotation for "description" ?

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 317836 has been marked as a duplicate of this bug. ***

Comment 4

[Brett Wilson]

Attachment: Patch and importing (no creation)

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 212031 [details] [diff] [review]
Patch and importing (no creation)

r=[e-mail]

Comment 6

[Brett Wilson]

First patch is on trunk and branch. We still need descriptions, so keeping open at a lower priority.

Comment 7

[Kevin Brosnan]

*** Bug 328485 has been marked as a duplicate of this bug. ***

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Hmm, bookmark keywords don't seem to be working for me in a 3/2 build; the import seems to have happened fine (checked via inspecting the database), but they don't have any effect when used in the urlbar -- I just get the default i'm-feeling-lucky search.

Comment 9

[Dave Townsend [:mossop]]

(In reply to comment #8)
> Hmm, bookmark keywords don't seem to be working for me in a 3/2 build; the
> import seems to have happened fine (checked via inspecting the database), but
> they don't have any effect when used in the urlbar -- I just get the default
> i'm-feeling-lucky search.
> 

I've been seeing that for the past few days too.

Comment 10

[Joe McCabe]

My 20060227 FF trunk build has working keywords and working bookmark properties. Each nightly I've built since then does not have functional keywords OR bookmark properties.

Help?

Comment 11

[Brett Wilson]

Upping priority due to freshly broken shortcuts.

Comment 12

[Brett Wilson]

The keywords should be working again. Still no creation UI, but they will be imported and used.

Comment 13

[Peter Lairo]

Do we need to re-import our bookmarks.html (by deleting bookmarks_history.sqlite), thus *losing any bookmarks we've added since Places landed*, or were keywords imported (into: bookmarks_history.sqlite ?) but just didn't work until this bug was/is fixed?

Comment 14

[Dave Townsend [:mossop]]

(In reply to comment #13)
> Do we need to re-import our bookmarks.html (by deleting
> bookmarks_history.sqlite), thus *losing any bookmarks we've added since Places
> landed*, or were keywords imported (into: bookmarks_history.sqlite ?) but just
> didn't work until this bug was/is fixed?

If your profile was created before the first patch for this landed (15/02) then you will have to reimport. The recent non-workage of this merely stopped them working and they worked fine again afterwards.

Comment 15

[Peter Lairo]

(In reply to comment #14)
> they worked fine again afterwards.

If by "they" you meant "keywords", then they don't work on today's trunk nightly. Did you mean "they *import* fine?

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060306 Firefox/1.6a1

Comment 16

[Dave Townsend [:mossop]]

(In reply to comment #15)
> If by "they" you meant "keywords", then they don't work on today's trunk
> nightly. Did you mean "they *import* fine?

Yes I mean the keywords. They work fine for me, but they will only work if they were imported by using places for the first time from a build after the initial checkin of this.

Comment 17

[Brett Wilson]

To clarify: if your bookmarks.html had keywords and was imported since this feature landed (15 Feb) then your bookmarks_history.sqlite will have those keywords. The frontend code for using the keywords became broken, and then was fixed, but at all times they should have been imported properly. If you run with a build since I fixed the frontend (6 Mar) then they should work.

Comment 18

[Peter Lairo]

(In reply to comment #17)
> If you run
> with a build since I fixed the frontend (6 Mar) then they should work.

Confirmed. Keywords are functioning again in trunk build from 20060307 WinXP.

Comment 19

[ronin.achilles]

(In reply to comment #18)
> (In reply to comment #17)
> > If you run
> > with a build since I fixed the frontend (6 Mar) then they should work.
> 
> Confirmed. Keywords are functioning again in trunk build from 20060307 WinXP.
> 

The imported keywords are working fine on Branch (03/08), but the "Post" type keywords, which are working perfectly on Fx1.5 are not working right... the keywords along with the search terms are performing a Google Lucky Search.

Comment 20

[Brett Wilson]

> The imported keywords are working fine on Branch (03/08), but the "Post" type
> keywords, which are working perfectly on Fx1.5 are not working right...

I just filed bug 329842 for this.

Comment 21

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #1)
>like "shortcuts"
>
Thought it was a whole new feature for fanatic keyboards users, a key combination to call a certain bookmark. :D

Comment 22

[Oliver Saier]

It'd be handy to have a column for shortcuts aka keywords. Or something nicer, since that column would be useless for history and folders. Maybe append shortcuts in parenthesis to bookmarks titles?

Comment 23

[Asaf Romano (gone)]

filed bug 372161 for the description-annotation part of this bug.

Comment 24

[Dietrich Ayala (:dietrich)]

marking fixed b/c this bug's remaining issues have been spun-off (bug 329842, bug 372161) and each block bug 370099 individually.

Comment 25

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv