320433 - Talkback option should be removed from build, until we can build TB again.

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20051214 SeaMonkey/1.0b] (nightly) (W98SE)

We don't currently have (Mozilla Fondation) tinderboxen, so we don't have TalkBack included builds.

Yet, the option is still present in Custom installer option, and adds a few hundred kilobytes to the count when enabled :-(

Of course, no TB is installed at all.

Comment 1

[Reed Loden [:reed]]

J_Rey on IRC also noticed that the following text would need to be removed from "about:" if Talkback is removed from SeaMonkey:
"This software may contain portions that are copyright © 1998–2002 SupportSoft, Inc.  All Rights Reserved."

Comment 2

[Hermann Schwab]

(In reply to comment #1)
> J_Rey on IRC also noticed that the following text would need to be removed from
> "about:" if Talkback is removed from SeaMonkey:
> "This software may contain portions that are copyright © 1998–2002
> SupportSoft, Inc.  All Rights Reserved."

No, 'it may contain' doesn't denote that it actually contains this software.
Due to limited space on the server not every build includes talkback.

Talkback consists of two parts, special software build with the browser, and symbol tables from exactly that build installed at the talkback server.
Symbol tables on the server are deleted after some weeks, so talkbacks from old builds give you offsets into DLLs only instead of symbols and lines of files.

So Talkback used to be provided with the nightly builds of Mozilla/MozillaSuite/Seamonkey, not with the tinderbox builds.
It is often provided with the hourly Firefox builds.

Comment 3

[J. Reynolds]

I filed a new bug for this since the about: page isn't related to installation. See Bug 320688 for more info.

Comment 4

[Andrew Schultz]

*** Bug 320959 has been marked as a duplicate of this bug. ***

Comment 5

[Andrew Schultz]

*** Bug 321137 has been marked as a duplicate of this bug. ***

Comment 6

[Andrew Schultz]

Attachment: disable talkback

This prevents the installer from trying to install talkback.  There will still be an empty talkback.xpi.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 207870 [details] [diff] [review]
disable talkback

r=dveditz
You could also take the opportunity to rearrange the unix components to move talkback last as in windows, which would make the eventual re-enabling patch smaller.

Comment 8

[Andrew Schultz]

Attachment: patch for trunk to put talkback last

ok, this reorders things as dveditz suggested (moves talkback to the end)

Comment 9

[Andrew Schultz]

KaiRo: is rearranging things (a la attachment 208180 [details] [diff] [review]) going to confuse SM 1.0 localizers too much at this late stage of the game?

Comment 10

[Robert Kaiser]

ajschult, I think the change in the installer file only will be no big problem to localizers, so we just should tell them in the L10n newsgroup once the release is really near...

Comment 11

[Robert Kaiser]

Comment on attachment 207870 [details] [diff] [review]
disable talkback

a=me for both branches, still one needed to go for 1.0

Comment 12

[Andrew Schultz]

patches are in trunk, 1.8 branch and 1.8.0 branch