322859 - ORGANIZER property lost on roundtrip

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Joey Minta]

Testcase from Oracle coming.  Relevant line: ORGANIZER;X-ORACLE-GUID=07FC24E37F265815E0405794071A700C;CN=Simon Vaillan
 court:mailto:[e-mail]

Comment 1

[Joey Minta]

Attachment: testcase.ics

Comment 2

[Joey Minta]

+
+        if (this.mOrganizer) {
+            m.mOrganizer = this.mOrganizer;
+        }

to calItemBase's clone().  Proper patch coming in a few days.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: clone the organizer, if it exists

I think we need to actually clone the organizer, mirroring the way attendees work.

Comment 4

[Joey Minta]

Comment on attachment 208049 [details] [diff] [review]
clone the organizer, if it exists

yep, yep. r=jminta

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Fixed.

Comment 6

[Stefan Sitter [:ssitter]]

That does not work for me. Import the event from testcase.ics and export the event to a new *.ics file. Examine the *.ics file with a text editor. There is no ORGANIZER element. Same with the testcase from Bug 320000.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060121 Mozilla Sunbird/0.3a1+.

Comment 7

[Joey Minta]

(In reply to comment #6)
> That does not work for me. Import the event from testcase.ics and export the
> event to a new *.ics file. Examine the *.ics file with a text editor. There is
> no ORGANIZER element. Same with the testcase from Bug 320000.
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060121
> Mozilla Sunbird/0.3a1+.
> 
The original bug was about simply roundtriping the attendee when subscribing.  The storage provider doesn't look for an organizer property at all, so import+export will lose it.  I don't have a problem using this bug to fix that, but I wanted to be clear why the above patch did fix the original problem.

(I suspect there are a fair number of other properties that the storage provider drops.)

Comment 8

[Stefan Sitter [:ssitter]]

Ok, if this was not the intention of this bug feel free to close it. There are more problems with that testcase. When opening the event in the new item dialog the attendees field displays 'undefined'. But that should be another bug.

Comment 9

[Stefan Sitter [:ssitter]]

Subscribing means ics provider? So it should also work with a remote calendar using file:/// url?

From the testcase:

ORGANIZER;X-ORACLE-GUID=07FC24E37F265815E0405794071A700C;CN=Simon Vaillan
 court:mailto:[e-mail]
ATTENDEE;X-ORACLE-SHOWASFREE=BUSY;X-ORACLE-GUID=07FC24E37F265815E04057940
 71A700C;CUTYPE=INDIVIDUAL;RSVP=FALSE;CN=Simon Vaillancourt;PARTSTAT=ACCE
 PTED:mailto:[e-mail]

After opening the edit event dialog and pressing ok:

ATTENDEE;CN=Simon Vaillancourt:mailto:[e-mail]
ATTENDEE;RSVP=FALSE;CN=Simon Vaillancourt;CUTYPE=INDIVIDUAL:mailto:
 [e-mail]
 
Or is this also not the scope of this bug?

Comment 10

[Joey Minta]

(In reply to comment #9)
> Subscribing means ics provider? So it should also work with a remote calendar
> using file:/// url?
It *should*.

> Or is this also not the scope of this bug?
> 
I think this type of dataloss is within the scope of this bug.  The basic idea here is that an organizer is treated exactly like an attendee.  However, when we hit http://landfill.mozilla.org/mxr-test/mozilla/source/calendar/base/src/calItemBase.js#576 we end up adding an "ATTENDEE" property, rather than an "ORGANIZER" property, since calIAttendee always returns attendee properties.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Since we don't actually generate ORGANIZER properties yet, this bug can wait for 0.2.

Comment 12

[Joey Minta]

Attachment: introduce isOrganizer flag to set icalProperty type

(cleaning up some of my old assigned bugs)

As I mentioned in comment #10, the current problem is that the organizer is a calIAttendee.  When getting the icalProperty from this, it returns an ATTENDEE property, rather than an ORGANIZER property.  This patch introduces a flag in order to determine which type of property should be returned.  We will still have issues with importing into storage, but there are larger problems there.  I'm mostly concerned about round-tripping ics files here.

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 212393 [details] [diff] [review]
introduce isOrganizer flag to set icalProperty type

r=mvl

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

I'd be ok with this landing before 0.1, since it's a pretty simple fix to an obvious dataloss bug.  Can you change to use a doxygen-style comment in the IDL?

Comment 15

[Joey Minta]

Patch "introduce isOrganizer flag to set icalProperty type" checked in.  Since this ought to fix the ics-roundtrip issues, I'm going to close this bug.  Feel free to file follow-ups on import-export issues.