323776 - Lightning should only install in corresponding branch/trunk builds

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

To avoid any problems the branch/trunk builds of Lightning should only install in corresponding branch/trunk builds. minVersion/maxVersion in install.rdf should be adapted for this.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: trunk patch

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: branch patch

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 208738 [details] [diff] [review]
trunk patch

I think this wants to use the XUL preprocessor to have both minVersion and maxVersion set to whatever the current build is. See <http://lxr.mozilla.org/seamonkey/source/extensions/inspector/install.rdf> for an example.  The reasoning behind this is that the trunk changes quickly enough that we're likely to avoid invalid bugs by forcing Lightning and Thunderbird builds to be from the same point.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 208740 [details] [diff] [review]
branch patch

I think maxVersion here probably wants to be calculated at build time, since we actually want to support more than the 1.5.0 branch, and the general plan seems to be keep the APIs that we care about more or less intact on the 1.8 branch itself.  Note that both this and the previous change will require adding the XUL preprocessor into the build, if we don't already have that.

Comment 5

[Stefan Sitter [:ssitter]]

(In reply to comment #4)

Ok, for the trunk I have a working version where minVersion and maxVersion is set to the current Firefox/Thunderbird trunk version during build.

But I'm not sure how to process with the branch version. 
The minVersion is fixed to 1.5, ok. But how do you want to calculate maxVersion at build time? For the 1.8.0 branch we need 1.5.0.* as maxVersion to support the security updates. For the 1.8 (later 1.8.1) branch we need 1.5 at the moment and later 2.0.

Comment 6

[Simon Paquet [:sipaq]]

(In reply to comment #5)
> But I'm not sure how to process with the branch version. 
> The minVersion is fixed to 1.5, ok. But how do you want to calculate maxVersion
> at build time? For the 1.8.0 branch we need 1.5.0.* as maxVersion to support
> the security updates. For the 1.8 (later 1.8.1) branch we need 1.5 at the
> moment and later 2.0.

IMO we should push the Firefox and Thunderbird folks to go somewhere along the following route:

1.8.0 Branch: maxVersion = 1.5.0.*
              minVersion = 1.5
1.8 Branch:   maxVersion = 2.0.*
              minVersion = 1.6
Trunk:        maxVersion = tbd
              minVersion = 2.1

Comment 7

[Stefan Sitter [:ssitter]]

Attachment: work in progress

This is the trunk patch mentioned in comment #5. 
Still have to decide how to process on branch.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

We should block Lightning 0.1 on the branch version of this, or we'll be asking for trouble.

Comment 9

[Stefan Sitter [:ssitter]]

(In reply to comment #8)
> We should block Lightning 0.1 on the branch version of this, or we'll be asking
> for trouble.

For Lightning 0.1 release I suggest using <em:minVersion>1.5</em:minVersion> and <em:maxVersion>1.5.0.*</em:maxVersion> on the branch because at the moment we don't know when the thunderbird branch version will change from 1.5 to something else and we don't know if the released Lightning 0.1 version will work in future Thunderbird branch versions (remember Bug 325140).

Comment 10

[Stefan Sitter [:ssitter]]

Attachment: patch for trunk and branch

Patch for branch and trunk using #ifdef MOZILLA_1_8_BRANCH to distinguish.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 211176 [details] [diff] [review]
patch for trunk and branch

I agree with the logic behind these version choices.  Thanks for the patch!

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Checked in on the trunk and branch.