324194 - Remove the search bar, make quick search and mail views customizeable toolbar buttons

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

In order to support tabs across the top of the thread pane, we're going to need to create room for the tab row. We can do this by getting rid of the existing search bar.

1) Move the throbber from the primary toolbar to the menu bar (like it is in firefox)
2) Move the quick search bar from the search bar into the primary toolbar (far right end)
3) Move the mail views listbox into the primary toolbar as a customizeable toolbar button which is *NOT* part of the default set. Users who still want to use views can customize their primary toolbar to get it.
4) Remove the Search Bar menu item from View / Toolbars

Comment 1

[Scott MacGregor]

Attachment: the fix

This implements the UI changes I listed above for 3-pane, address book, 

Still need to work on the CSS for the Mac and some more polish adjustments for windows. May also end up needing to add more if (gSearchInput) bullet proofing for users that remove the quick search bar.

Comment 2

[Scott MacGregor]

Attachment: screen shot

Comment 3

[David :Bienvenu]

Comment on attachment 209169 [details] [diff] [review]
the fix

nice

Comment 4

[Scott MacGregor]

I need to figure out a way to remove the quick search and mail view containers from the toolbar palette for the stand alone message window. Right now, the toolbars and the palette are shared between the stand alone and the 3-pane windows in mailWindowOverlay.xul

We don't want users to be able to add quick search boxes to the stand alone toolbar :)

Comment 5

[Scott MacGregor]

Attachment: updated patch

updated patch of what I'm going to check in.

I bumped the element ID for the mail toolbars to make sure the new items show up in the toolbars for users who may have customized their toolbars using 1.5 and earlier releases. This has the net effect of "resetting" your toolbars so you see the new default items.

I also added some code to the stand alone message window to remove quick search and mail views from the default toolbar set. But they still show up in the palette, I'm not sure how to fix that yet.

carrying forward david's sr.

Comment 6

[Thomas Schade]

(In reply to comment #5)
> updated patch of what I'm going to check in.

At least you gave me a big surprise after installing today's Thunderbird...  :)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060125 Thunderbird/1.6a1

> I also added some code to the stand alone message window to remove quick search
> and mail views from the default toolbar set. But they still show up in the
> palette, I'm not sure how to fix that yet.

Any chance to get bug 320015 in here? It seems to be somehow related to what you're going to change.

Comment 7

[Scott MacGregor]

I missed a couple files when I checked this into the trunk, so the trunk build today has several JS errors in the console because of this. But it's still functional.

Comment 8

[Scott MacGregor]

Attachment: bump the ids for the menu bars too

I need to bump the ids for the menubars as well. Otherwise when you go back to a branch build, you end up with two throbbers due to stale localstore information.

Comment 9

[Scott MacGregor]

Attachment: more null checks

If you have the views button but no quick search, views were broken because gSearchInput is null. Added more null check bullet proofing to searchBar.js which is used by both quick search (gSearchInput)and mail views.

Comment 10

[Scott MacGregor]

there might be some more bullet proofing patches we have to take for this.

Comment 11

[Jerry Baker]

One small nit (dunno if it should be another bug). Can we collapse the top of the folders pane so that it is level with the thread pane and then make the groove run all the way across the screen?

Comment 12

[Jerry Baker]

Attachment: Mock up

Mock up to illustrate my previous post.

Comment 13

[Mike Cowperthwaite]

I agree with Jerry's idea.  Also note, even with "expanded columns for Folder Pane" enabled, the column headers in the Folder pane are a little taller than the column headers in the Thread pane -- it appears because the Folder pane has an inset border that the Thread pane lacks.

Comment 14

[Scott MacGregor]

Attachment: more sidebar header and splitter cleanup

some minor changes to the sidebar header look to make it look like a real sidebar header (and improvements to the non default, tree column based view).

Comment 15

[Scott MacGregor]

Attachment: addressbook sidebar header changes

Comment 16

[Mike Cowperthwaite]

(In reply to comment #1)
> May also end up needing to add more if (gSearchInput) bullet proofing
> for users that remove the quick search bar.

Looks like you need a test in   ClearQSIfNecessary()  -- if there's no QS displayed and you change the setting under  View | Thread, there's an error thrown and the thread mode doesn't change.

Comment 17

[Scott MacGregor]

Attachment: more bullet proofing

handles the case where you do View / Threads when there is no quick search or mail view buttons in the toolbar.

Good catch Mike.

Comment 18

[Mike Cowperthwaite]

(In reply to comment #4)
> I need to figure out a way to remove the quick search and mail view containers
> from the toolbar palette for the stand alone message window. Right now, the
> toolbars and the palette are shared between the stand alone and the 3-pane
> windows in mailWindowOverlay.xul

Scott, bug 325028 was opened about this issue.  Do you want that duped here, or would you like to keep that bug for that particular problem?

Comment 19

[Wayne Mery (:wsmwk)]

moving the bar is also a welcome change for gaining real estate.
relnote > users will need to be informed of how to restore the "view" selection.

Comment 20

[Ronny Perinke]

Attachment: fix for: Error loading AccountCentral page -> ReferenceError: gSearchBox is not defined

https://bugzilla.mozilla.org/attachment.cgi?id=209478
the patch forgot to remove a reference to gSearchBox and therefore the accountcentral page won't load.

Comment 21

[Scott MacGregor]

Comment on attachment 211624 [details] [diff] [review]
fix for: Error loading AccountCentral page -> ReferenceError: gSearchBox is not defined

This change was included in my original patch along with some other changes to mailWindow.js. I wonder if my changes to this file just didn't make it onto the 1.8 branch. If true, I should just fix that instead of this patch.

Comment 22

[Ronny Perinke]

(In reply to comment #21)
> (From update of attachment 211624 [details] [diff] [review] [edit])
> This change was included in my original patch along with some other changes to
> mailWindow.js. I wonder if my changes to this file just didn't make it onto the
> 1.8 branch. If true, I should just fix that instead of this patch.
> 

Maybe only this particular change did not succeed when applying the patch? Who knows ....

Comment 23

[Scott MacGregor]

Comment on attachment 211624 [details] [diff] [review]
fix for: Error loading AccountCentral page -> ReferenceError: gSearchBox is not defined

i checked this into the branch. Thanks!

Comment 24

[Alex Ihrig [:Thunderbird_Mail_DE]]

The new toolbar items "View" and "Quicksearch" appear in message standalone window. This should not be the case. These 2 items make only sense in the 3-pane-window.

Remove these 2 items from the related overlay for the standalone window, please.

Comment 25

[Alex Ihrig [:Thunderbird_Mail_DE]]

Ahh, sorry. Should read your comment #4.

Comment 26

[Adam Guthrie]

Reverting the unintended reopening by Alexander Ihrig.

Comment 27

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 on Thunderbird 2 RC2 (Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620)