Closed
Bug 324194
Opened 19 years ago
Closed 18 years ago
Remove the search bar, make quick search and mail views customizeable toolbar buttons
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird2.0
People
(Reporter: mscott, Assigned: mscott)
References
Details
(Keywords: fixed1.8.1, verified1.8.1.3)
Attachments
(9 files, 1 obsolete file)
57.21 KB,
image/png
|
Details | |
31.42 KB,
patch
|
mscott
:
superreview+
|
Details | Diff | Splinter Review |
3.36 KB,
patch
|
Details | Diff | Splinter Review | |
2.60 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
18.29 KB,
image/png
|
Details | |
2.07 KB,
patch
|
mscott
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
2.77 KB,
patch
|
mscott
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
1.15 KB,
patch
|
mscott
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
1.02 KB,
patch
|
mscott
:
superreview+
mscott
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
In order to support tabs across the top of the thread pane, we're going to need to create room for the tab row. We can do this by getting rid of the existing search bar. 1) Move the throbber from the primary toolbar to the menu bar (like it is in firefox) 2) Move the quick search bar from the search bar into the primary toolbar (far right end) 3) Move the mail views listbox into the primary toolbar as a customizeable toolbar button which is *NOT* part of the default set. Users who still want to use views can customize their primary toolbar to get it. 4) Remove the Search Bar menu item from View / Toolbars
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird2.0
Assignee | ||
Comment 1•19 years ago
|
||
This implements the UI changes I listed above for 3-pane, address book, Still need to work on the CSS for the Mac and some more polish adjustments for windows. May also end up needing to add more if (gSearchInput) bullet proofing for users that remove the quick search bar.
Attachment #209169 -
Flags: superreview?(bienvenu)
Assignee | ||
Comment 2•19 years ago
|
||
Comment 3•19 years ago
|
||
Comment on attachment 209169 [details] [diff] [review] the fix nice
Attachment #209169 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 4•19 years ago
|
||
I need to figure out a way to remove the quick search and mail view containers from the toolbar palette for the stand alone message window. Right now, the toolbars and the palette are shared between the stand alone and the 3-pane windows in mailWindowOverlay.xul We don't want users to be able to add quick search boxes to the stand alone toolbar :)
Assignee | ||
Comment 5•19 years ago
|
||
updated patch of what I'm going to check in. I bumped the element ID for the mail toolbars to make sure the new items show up in the toolbars for users who may have customized their toolbars using 1.5 and earlier releases. This has the net effect of "resetting" your toolbars so you see the new default items. I also added some code to the stand alone message window to remove quick search and mail views from the default toolbar set. But they still show up in the palette, I'm not sure how to fix that yet. carrying forward david's sr.
Attachment #209169 -
Attachment is obsolete: true
Attachment #209478 -
Flags: superreview+
Comment 6•19 years ago
|
||
(In reply to comment #5) > updated patch of what I'm going to check in. At least you gave me a big surprise after installing today's Thunderbird... :) Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060125 Thunderbird/1.6a1 > I also added some code to the stand alone message window to remove quick search > and mail views from the default toolbar set. But they still show up in the > palette, I'm not sure how to fix that yet. Any chance to get bug 320015 in here? It seems to be somehow related to what you're going to change.
Assignee | ||
Comment 7•19 years ago
|
||
I missed a couple files when I checked this into the trunk, so the trunk build today has several JS errors in the console because of this. But it's still functional.
Assignee | ||
Comment 8•19 years ago
|
||
I need to bump the ids for the menubars as well. Otherwise when you go back to a branch build, you end up with two throbbers due to stale localstore information.
Assignee | ||
Comment 9•19 years ago
|
||
If you have the views button but no quick search, views were broken because gSearchInput is null. Added more null check bullet proofing to searchBar.js which is used by both quick search (gSearchInput)and mail views.
Attachment #209908 -
Flags: superreview?(bienvenu)
Updated•19 years ago
|
Attachment #209908 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 10•19 years ago
|
||
there might be some more bullet proofing patches we have to take for this.
Comment 11•19 years ago
|
||
One small nit (dunno if it should be another bug). Can we collapse the top of the folders pane so that it is level with the thread pane and then make the groove run all the way across the screen?
Comment 12•19 years ago
|
||
Mock up to illustrate my previous post.
Comment 13•19 years ago
|
||
I agree with Jerry's idea. Also note, even with "expanded columns for Folder Pane" enabled, the column headers in the Folder pane are a little taller than the column headers in the Thread pane -- it appears because the Folder pane has an inset border that the Thread pane lacks.
Assignee | ||
Comment 14•19 years ago
|
||
some minor changes to the sidebar header look to make it look like a real sidebar header (and improvements to the non default, tree column based view).
Attachment #210259 -
Flags: branch-1.8.1+
Assignee | ||
Comment 15•19 years ago
|
||
Attachment #210312 -
Flags: branch-1.8.1+
Comment 16•19 years ago
|
||
(In reply to comment #1) > May also end up needing to add more if (gSearchInput) bullet proofing > for users that remove the quick search bar. Looks like you need a test in ClearQSIfNecessary() -- if there's no QS displayed and you change the setting under View | Thread, there's an error thrown and the thread mode doesn't change.
Assignee | ||
Comment 17•19 years ago
|
||
handles the case where you do View / Threads when there is no quick search or mail view buttons in the toolbar. Good catch Mike.
Attachment #210553 -
Flags: branch-1.8.1+
Comment 18•19 years ago
|
||
(In reply to comment #4) > I need to figure out a way to remove the quick search and mail view containers > from the toolbar palette for the stand alone message window. Right now, the > toolbars and the palette are shared between the stand alone and the 3-pane > windows in mailWindowOverlay.xul Scott, bug 325028 was opened about this issue. Do you want that duped here, or would you like to keep that bug for that particular problem?
Comment 19•19 years ago
|
||
moving the bar is also a welcome change for gaining real estate. relnote > users will need to be informed of how to restore the "view" selection.
Keywords: relnote
Comment 20•18 years ago
|
||
https://bugzilla.mozilla.org/attachment.cgi?id=209478 the patch forgot to remove a reference to gSearchBox and therefore the accountcentral page won't load.
Attachment #211624 -
Flags: superreview?(mscott)
Assignee | ||
Comment 21•18 years ago
|
||
Comment on attachment 211624 [details] [diff] [review] fix for: Error loading AccountCentral page -> ReferenceError: gSearchBox is not defined This change was included in my original patch along with some other changes to mailWindow.js. I wonder if my changes to this file just didn't make it onto the 1.8 branch. If true, I should just fix that instead of this patch.
Comment 22•18 years ago
|
||
(In reply to comment #21) > (From update of attachment 211624 [details] [diff] [review] [edit]) > This change was included in my original patch along with some other changes to > mailWindow.js. I wonder if my changes to this file just didn't make it onto the > 1.8 branch. If true, I should just fix that instead of this patch. > Maybe only this particular change did not succeed when applying the patch? Who knows ....
Assignee | ||
Comment 23•18 years ago
|
||
Comment on attachment 211624 [details] [diff] [review] fix for: Error loading AccountCentral page -> ReferenceError: gSearchBox is not defined i checked this into the branch. Thanks!
Attachment #211624 -
Flags: superreview?(mscott)
Attachment #211624 -
Flags: superreview+
Attachment #211624 -
Flags: approval-branch-1.8.1+
Comment 24•18 years ago
|
||
The new toolbar items "View" and "Quicksearch" appear in message standalone window. This should not be the case. These 2 items make only sense in the 3-pane-window. Remove these 2 items from the related overlay for the standalone window, please.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 25•18 years ago
|
||
Ahh, sorry. Should read your comment #4.
Comment 26•18 years ago
|
||
Reverting the unintended reopening by Alexander Ihrig.
Status: REOPENED → RESOLVED
Closed: 19 years ago → 18 years ago
Resolution: --- → FIXED
Comment 27•17 years ago
|
||
verified fixed 1.8.1.3 on Thunderbird 2 RC2 (Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620)
Keywords: verified1.8.1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•