324314 - 'Use this theme' for the default theme is dimmed when non-default theme selected.

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Colton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060121 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060121 Firefox/1.6a1

I upgraded to tonights alpha (01-21-2006) and noticed that the theme I was using was imcompatable with the tab changes. When I went to switch to default theme I noticed I couldnt use it by clicking the button. I had to uninstall my old theme to force it to switch to default.

Reproducible: Didn't try

Steps to Reproduce:
1.Install theme and use it.
2.restart Fx and and try 'use' default theme.

Actual Results:  
Could not select default theme.

Expected Results:  
Browser to switch to default.

Comment 1

[Colton]

I just tried it with aquatint and didnt eve have to restart. Just did 'Use this theme' on aquatint and tried to do the same back to default and couldnt.

Comment 2

[zug_treno]

Related to/duplicate of bug 307395?

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> Related to/duplicate of bug 307395?
No, a patch was checked in that fixed that bug but I don't recall which.

Comment 4

[Dave Townsend [:mossop]]

No problem here.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060122 Firefox/1.6a1

Comment 5

[Colton]

News to me because its still broken here with 01-22-2006.

Comment 6

[Robert Strong (they/them - no direct email)]

This WFM also with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060127 Firefox/1.6a1

Chances are you are experiencing one of the install bugs for the Extension Manager (e.g. bug 315245 and several others) which can prevent normal operations such as you describe. Can you zip up your profile's extensions directory along with the extensions.rdf, extensions.cache, and extensions.ini files that are located inside your profile's directory and either email the zip file to me or attach it to this bug? I suspect the resulting zip file will be larger than the maximum allowed for attachments so you will probably have to email them to me.
http://www.mozilla.org/support/firefox/profile

Comment 7

[Robert Strong (they/them - no direct email)]

It appears to be as I suspected and the reason this is happening is that the Extension Manager runs into an unhandled exception that then prevents the fix for bug 295855 from working.

Taking since I'm working on several similar bugs.

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch

It turns out that some of the unhandled exceptions have prevented the removal of the old default theme in the profile's extensions directory from 1.0. With this patch we will always check on upgrade for a default theme and old DOMi dir in the profile's extensions directory when we have the old Extensions.rdf in the extensions directory.

Comment 9

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Comment 10

[Robert Strong (they/them - no direct email)]

Comment on attachment 212032 [details] [diff] [review]
patch

This contains a fix that only occurs once during the first app run on upgrade.

Comment 11

[Robert Strong (they/them - no direct email)]

Fixed on MOZILLA_1_8_BRANCH