325287 - storage file reorg

Status: RESOLVED INVALID

(Toolkit :: Storage, defect)

Description

[Brian Ryner (not reading)]

1. We need to get away from using .sdb as a file extension, see http://www.sqlite.org/cvstrac/wiki?p=PerformanceTuningWindows section 5.

2. We should provide an easy way to name storage files in the profile directory without requiring all callers to use the directory service or hardcode the file extension.

This change impacts Calendar, so cc'ing those people.  dmose thought calendar could just hook in some migration to rename storage.sdb if it exists.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Like so.  Note that this also changes the base name of the default file to "profile", as brettw suggested (to make it look less like something that can be deleted to free up space).

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 210203 [details] [diff] [review]
patch

Looks fine to me.

Comment 3

[Darin Fisher]

That doc recommends .db or .dat instead of .sdb.  Any reason not to go with one of those?

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #3)
> That doc recommends .db or .dat instead of .sdb.  Any reason not to go with one
> of those?

Too generic, IMO (note that that doc is just a wiki page written up by someone, not an official doc).  We don't have any supported systems with 8.3 limitations any more, and .sqlite gives people a hint to what file format is in use if they poke around their profile directory.  .db is already used for the cert db (berkeley db).

Comment 5

[Brian Ryner (not reading)]

just to update, this is on hold until we figure out proper migration for apps such as sunbird.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

I'm marking this as blocking Lightning 0.1, as I think that having fewer users hit the migration code avoids trouble.  I'd like to propose that the migration code live in storage, as otherwise it is hard to guarantee that any migration has done before someone opens the database for the very first time (since it seems plausible that future Thunderbird versions will open the database before any extensions are loaded).

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

bryner: I'd like this make Lightning 0.1, which means it needs to land in the next couple of days.  I propose taking over this bug, adding code to storage which will automatically rename any existing database (as per comment 6), and driving both that patch and the one that you've already submitted into the tree.  Are you ok with this?

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

bryner OK'ed my proposal in comment 7; I'll go ahead with it soon.

Comment 9

[Stuart Parmenter]

Is it OK to actually use .sqlite?  Will that work on win95 (and other crappy OSes) with non-vfat drives?

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: migrating version of sdb -> sqlite, work-in-progress

This is an un-bitrotted version of bryner's patch, and a work in progress.  A bunch of the error-handling code still needs to be written.  It doesn't include a patch to satchel like first version, as there is already a patch in the tree that opens a specific, separate database for formhistory.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Assigning bugs that I'm not actively working on back to nobody; use
SearchForThis as a search term if you want to delete all related bugmail at
once.

Comment 12

[Shawn Wilsher :sdwilsh]

This isn't a valid storage bug