Closed Bug 325399 Opened 19 years ago Closed 19 years ago

tweak CSS padding to cut down on font-clipping in event boxes

Categories

(Calendar :: Internal Components, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Lightning 0.1

People

(Reporter: dmosedale, Unassigned)

References

Details

Attachments

(2 files)

This should be an extremely way to improve visual effect before releasing Lightning 0.1.  Spun off from bug 322981.
s/extremely/extremely easy
Attached patch first try (checked in) — — Splinter Review
Not sure if this is what you have in mind, but it does allow for more events-per-day in the month and multiweek views.
(we really need to fix our theme story...)
Attachment #210527 - Flags: first-review?(dmose)
Comment on attachment 210527 [details] [diff] [review]
first try (checked in)

That's pretty much exactly what I had in mind; thanks!  Can I talk you into doing the multiday view also?
Attachment #210527 - Flags: first-review?(dmose) → first-review+
Comment on attachment 210527 [details] [diff] [review]
first try (checked in)

patch checked in.
I'm not sure what to with the multiday view, becuase it has much more room. No need to remove the margins there, i think. But leaving the bug open in case you disagree.
Attachment #210527 - Attachment description: first try → first try (checked in)
Attached patch updates (checked in) — — Splinter Review
The checkin for bug 321546 made the event label have a bigger font again, while the time was still small. The labels also no longer aligned properly
This patch corrects that.
Attachment #210703 - Flags: first-review?(jminta)
Comment on attachment 210703 [details] [diff] [review]
updates (checked in)

When we edit, we use font-size: x-small, http://lxr.mozilla.org/mozilla/source/calendar/base/content/calendar-multiday-view.css#92 instead of the 0.9em you use here.  I'm not sure if it's better to match those up or not. r=jminta either way.
Attachment #210703 - Flags: first-review?(jminta) → first-review+
Attachment #210703 - Attachment description: updates → updates (checked in)
mvl has convinced me that trying to do the same trick for the week views would make them look strange for the default settings.  I see lots of extra clipping because I display 0700 through 2300.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!
Assignee: base → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: