Closed Bug 325440 Opened 19 years ago Closed 19 years ago

Sunbird's GUID isn't recognized ("Get more themes" link in Sunbird's themes window shows Firefox themes page)

Categories

(addons.mozilla.org Graveyard :: Administration, defect)

defect
Not set
blocker

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sipaq, Assigned: morgamic)

Details

Assignee: morgamic → nobody
Component: Listings → General
Product: Update → Calendar
QA Contact: listings → general
Gavin, why did you move this bug to Calendar from Update? What is wrong on our side?
Sorry, you said "I get sent to amo?application={ec8030f7-c20a-464f-9b0e-13a3a9e97384}" when you meant "I get sent to amo?application={718e30fb-e89b-41dd-9da7-e25a45638b28} which gets treated like amo?application=firefox", which led me to believe it was a client side bug.
Assignee: nobody → morgamic
Component: General → Administration
Product: Calendar → Update
QA Contact: general → administration
Summary: "Get more themes" link in Sunbird's themes window shows Firefox themes page → Sunbird's GUID isn't recognized ("Get more themes" link in Sunbird's themes window shows Firefox themes page)
UMO 1.0 http://lxr.mozilla.org/update1.0/source/core/inc_guids.php#39 AMO 2.0 Can't find it. morgamic, do we have this redirect? This should be database driven.
Why are we passing GUIDs as GET parameters?
The applications pass them to us. They know their own GUID. We convert that into a name.
Why are we passing GUIDs as GET parameters?
Oops. Thanks for the tip Alan. I didn't realize we passed the GUID from the Get More Themes... link. My question is really about why we are passing the GUID instead of an application name?
(In reply to comment #8) > I didn't realize we passed the GUID from the Get More Themes... link. My > question is really about why we are passing the GUID instead of an application > name? Presumably because the GUID for a given application is much more consistent than it's name. Some Firefox builds are not "Firefox", for example. Knowing which keyword AMO responds to for a given app is more complicated than just giving it a GUID.
Those instances should be replaced with a wrapper func in amo.class.php. Writing a v1.0 patch would not be a good use of time, but a v2.0 patch would be welcome, if you want to. I'll add this to the v2.0 todo list.
Status: NEW → ASSIGNED
Severity: normal → blocker
Target Milestone: 1.0 → 2.0
Morgamic, this seems to be fixed with the new AMO 2.0 system. Although the header still shows the "Firefox Addons" header. I guess it's time for Sunbird to have its own section. Should I open a new bug for that or can we track that here?
(In reply to comment #12) > Morgamic, this seems to be fixed with the new AMO 2.0 system. > Although the header still shows the "Firefox Addons" header. I guess it's time > for Sunbird to have its own section. > > Should I open a new bug for that or can we track that here? See Bug 332417
(In reply to comment #12) > This seems to be fixed with the new AMO 2.0 system. Seems to be, or is? (-> FIXED?)
Yes, this was fixed by changes Wil made to the app switching. The header logo doesn't change, but I wouldn't worry about that too much in the short term since there is bug 337198 which is slated to modify app switching behavior to avoid this kind of confusion.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
It's not working again- 'get themes/extensions' link shows firefox extensions/themes pages. Please reopen the bug
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060911 Calendar/0.3a2+
(In reply to comment #16) > It's not working again- 'get themes/extensions' link shows firefox > extensions/themes pages. Please reopen the bug > If you read this bug carefully, you'll notice that despite the header image showing "Firefox add-ons," the add-ons listed are actually Sunbird Add-ons. Am I incorrect?
Not really. https://addons.mozilla.org/sunbird/extensions/ shows extensions that are not compatible with sunbird.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.