Open Bug 328174 Opened 19 years ago Updated 3 years ago

ISP files: can't preselect server type choice

Categories

(Thunderbird :: Account Manager, defect)

defect

Tracking

(Not tracked)

REOPENED

People

(Reporter: y.rouillard, Assigned: y.rouillard)

Details

(Keywords: fixed1.8.1, Whiteboard: [patchlove])

Attachments

(5 files, 1 obsolete file)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060210 Ubuntu/dapper Firefox/1.5.0.1 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060210 Ubuntu/dapper Firefox/1.5.0.1 The AccountWizard customization by just putting rdf files in defaults/isp directory is great, but it lacks some features. if server type is set to imap in the rdf file, the imap type should be pre-selected on the Account Wizard server page. Reproducible: Always Steps to Reproduce: 1. Put the isp_example.rdf file attached in the defaults/isp directory 2. launch the wizard 3. go to the server page Actual Results: pop is selected by default Expected Results: imap should be selected by default
This patch just add some code to preselect the imap type.
Attachment #212724 - Flags: review?(bienvenu)
I could be wrong, but I thought in the Netscape days, when we had an AOL account type, the user didn't have to pick imap vs. pop3. Did we some how have a check for redirector type or something? Probably not relevant, but I just want to make sure we're not reinventing something here.
Comment on attachment 212724 [details] [diff] [review] Patch to preselect imap in server page if server type was set to imap in isp rdf file this can be simplified to reduce code duplication. Something like: var serverTypeRadioItem = document.getElementById(pageData.server && pageData.server.servertype && pageData.server.servertype.value == "imap" ? "imap" : "pop3"); serverTypeRadioGroup.selectedItem = serverTypeRadioItem; Thx for working on all this, btw!
Attachment #212724 - Flags: review?(bienvenu) → review-
(In reply to comment #4) > I could be wrong, but I thought in the Netscape days, when we had an AOL > account type, the user didn't have to pick imap vs. pop3. Did we some how have > a check for redirector type or something? Probably not relevant, but I just > want to make sure we're not reinventing something here. > Well, with AOL wizard, I think the server page was simply not shown, because imap and pop server was coded in the rdf file so they didn't have the problem. In my case, I still need my users to be able to enter the imap/smtp hostname, as in my society there are several distinct geographics units which use differents imap/smtp servers. Concerning this redirector thing, what is it exactly ?
that makes sense re the aol wizard. The redirector type was the abstraction we hid Netscape/AOL servers behind. It was supposed to be general, but it was only Netscape/AOL that had servers that did redirection. It allowed us to do little hacks in the open source code that we more or less specific to AOL.
Attached patch cumulative patchSplinter Review
Yann, this is what I have so far from your patches, as a cvs diff, with some little code optimizations I added. I ran with them and they seem to work as desired.
Attachment #212779 - Flags: superreview?(mscott)
Attachment #212779 - Flags: review+
Attachment #212779 - Flags: superreview?(mscott) → superreview+
Thanks for you quick reviews !! btw, do you know where I should modify some code for https://bugzilla.mozilla.org/show_bug.cgi?id=328180 ? I already made a hack in the AccountWizard.js but it's not a generic enough.
Reassigning to you before I mark this fixed - I checked your fixes in.
Assignee: mscott → y.rouillard
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
setting target milestone to tb 2.0 since I think this would be nice for 2.0 if it shakes out ok on the trunk.
Target Milestone: --- → Thunderbird2.0
Attachment #212779 - Flags: approval-branch-1.8.1?
Keywords: fixed1.8.1
Comment on attachment 212779 [details] [diff] [review] cumulative patch it looks like this already made it's way onto the branch.
Attachment #212779 - Flags: approval-branch-1.8.1? → approval-branch-1.8.1+
In the case we force the creation of a new smtp server in the rdf file, we should ask for the smtp server (already done in the previous patch) but we should also ask for the username for this server in the login page. I forgot this in my previous patch, here is a an additional patch to fix this problem.
Attachment #217880 - Flags: review?(bienvenu)
This patch adds a new option in rdf file (smtpUserIncomingUsername) which allows to force to use the incoming username for outgoing smtp server authentication even if outgoing and incoming server names are differents. It also includes the previous patch.
Attachment #217880 - Attachment is obsolete: true
Attachment #217897 - Flags: review?(bienvenu)
Attachment #217880 - Flags: review?(bienvenu)
Comment on attachment 217897 [details] [diff] [review] Allow isp rdf to force use of incoming username for outgoing server do you have a test rdf I can try this with?
Attachment #217897 - Flags: review?(bienvenu) → review+
Attachment #217897 - Flags: superreview?(mscott)
Comment on attachment 217897 [details] [diff] [review] Allow isp rdf to force use of incoming username for outgoing server Bitrotted. You also have to add the corresponding entities for /suite
Attachment #217897 - Flags: superreview?(mscott) → superreview-
Target Milestone: Thunderbird2.0 → ---
obsolete with autoconfig?
Whiteboard: [patchlove]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: