328180 - ISP files: can't modify IMAP special folders path (Sent, Drafts, ...) in isp rdf files

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Yann Rouillard]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060210 Ubuntu/dapper Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060210 Ubuntu/dapper Firefox/1.5.0.1

It would be nice to be able to change the values of the IMAP special folders path (Sent, Drafts, ...) in isp rdf files.
I tried to play with stationeryFolder, draftFolder, fccFolder options but it never worked.

Reproducible: Always

Comment 1

[Yann Rouillard]

This bug is part of a serie of bug I filled about bugs/feature in isp rdf files, 
see:
https://bugzilla.mozilla.org/show_bug.cgi?id=328174
https://bugzilla.mozilla.org/show_bug.cgi?id=328175
https://bugzilla.mozilla.org/show_bug.cgi?id=328178
https://bugzilla.mozilla.org/show_bug.cgi?id=328180

Comment 2

[David :Bienvenu]

Can you give more detail about what you tried? I would think something like setPageData(pageData, "identity", "fcc_folder", string) would do the trick.

Comment 3

[Yann Rouillard]

Attachment: Allow special folders to be specified in isp rdf files

I tried again and here is the best solution I found.

Comment 4

[Yann Rouillard]

Attachment: Allow special folders to be specified in isp rdf files

Oups last patch was created from an already modified original source file.

Comment 5

[David :Bienvenu]

that looks reasonable - do you have  sample rdf file I can test quickly with?

Comment 6

[Yann Rouillard]

Attachment: sample rdf to test

Comment 7

[Yann Rouillard]

I attached a sample rdf.

Concerning the patch:
strangely I was not able to use directly identity.fccFolder (same for draftFolder and stationeryFolder).

 I thought it should already be initialized with value from accountData.draftFolder, but each time I tried to use identity.draftFolder, for example:

var fccFolder = (identity.fccFolder ? identity.fccFolder : "Sent");

it didn't work and even causes some bug which prevents the rest of the function 
to be properly executed.

So I have to carry accountData in the setDefaultCopiesAndFoldersPrefs function.

Comment 8

[David :Bienvenu]

sorry for the delay - I tried this patch, and it did set the folder prefs correctly, but the account settings UI doesn't reflect the prefs correctly. The fcc_folder_picker_mode is left at 0, even though the fcc folder set is not the "default". This would be confusing for the user; at least it was for me. If you set the fcc_folder_picker_mode to 1, it might do the right thing, as long as the folder you set does exist...does that make sense? This also goes for the template and drafts folder_picker_mode. Can you give it a try?

something like:

        identity.fcc_folder_picker_mode = accountData.identity && accountData.identity.stationeryFolder
         ? "1" : "0";

But that might not work - when I tried it, I got some errors on the js console...

Comment 9

[Yann Rouillard]

Ok I will try, I also noticed that but didn't think it was a problem, but you're right it would be better if the pickermode could be changed. I will work on this, I'll keep you updated.

Comment 10

[David :Bienvenu]

Comment on attachment 214863 [details] [diff] [review]
Allow special folders to be specified in isp rdf files

minusing in favor of a patch that adjusts the folder picker mode appropriately.

Comment 11

[Yann Rouillard]

Attachment: Updated patch

Updated patch as asked by David Bienvenu.

I added the picker mode change, however I nearly did the modifications you gave in your comment.
I tested it and it works, but I don't have js console to see the debug output. How do you enable it ?

Comment 12

[David :Bienvenu]

tools | js console will show you the js console. I'll try this patch now.

Comment 13

[David :Bienvenu]

Comment on attachment 217843 [details] [diff] [review]
Updated patch

thx for the patch. It doesn't quite work if we don't know about the special folders yet, but if the user connects to the server and discovers the folder, it should work.

Comment 14

[David :Bienvenu]

fixed on trunk, thanks, Yann! I'll put this in TB 2 soon.

Comment 15

[Scott MacGregor]

Comment on attachment 217843 [details] [diff] [review]
Updated patch

adding this flag so we don't lose track of this.

Comment 16

[Scott MacGregor]

Comment on attachment 217843 [details] [diff] [review]
Updated patch

I think this has baked long enough that we can take it on the branch.