328337 - black flash if you visit page that loaded in a background tab

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060223 Firefox/1.6a1 ID:2006022310

repro:
1.middleclick on the testcase (a blank page) to load it in a background tab
2.click on that tab

result:
the page briefly appears as black before turning white

testcase next

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: load testcase in background tab

Comment 2

[gabe]

refrshing page gives same resuilt

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: windows paint handling patch

So our windows paint event handling seems to have been at least somewhat based on a dirty lie, or at least on some odd logic: namely, the return value from OnPaint wasn't really the return value from the WndProc, but instead just a flag saying whether we actually set a return value or not and whether we should call the default WndProc.  Before, the WndProc return value was always 0, meaning "we handled this event", so just about every OnPaint ended up as "we handled this"; a few times it didn't, but those were for event handlers that don't paint anyway.

Here we always say that we set a return value (PR_TRUE from ProcessMessage) but also set the WndProc return value indicating whether we did paint or not.  This seems to fix this bug and I don't notice anything breaking...

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** Bug 328993 has been marked as a duplicate of this bug. ***

Comment 5

[Jerry Baker]

Will this patch address the issue I see of images flashing black on occasion also, or should that be a separate bug?

Comment 6

[Oliver Saier]

(In reply to comment #5)
> Will this patch address the issue I see of images flashing black on occasion
> also, or should that be a separate bug?
>
That should be Bug 324707

Comment 7

[Jerry Baker]

I'm talking about JPG's and non-animated GIFs.

Comment 8

[Jerry Baker]

That's nice with the reassign less than 1/16" from the submit button.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 213076 [details] [diff] [review]
windows paint handling patch

sorry that this fell through the cracks

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

checked in; I think this same problem exists on linux, I'll double check that before resolving.

Comment 11

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060307 Firefox/1.6a1 ID:2006030713

Fixed for me

Comment 12

[Justin Kerk]

(In reply to comment #7)
> I'm talking about JPG's and non-animated GIFs.

Bug 326672?

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix for gtk2

Same fix for gtk2

Comment 14

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Fixed on both windows/linux; shouldn't appear on mac, once we get there.