Closed
Bug 328645
Opened 19 years ago
Closed 19 years ago
Fix copyright dates on branches
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mark, Assigned: mscott)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
3.11 KB,
patch
|
mscott
:
review+
mscott
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.2-
|
Details | Diff | Splinter Review |
The copyright date needs to be kicked on the 1_8 and 1_8_0 branches.
Reporter | ||
Comment 1•19 years ago
|
||
mail/base/content/credits.xhtml has already been updated.
I question the string in nsMailApp.cpp ("Copyright (c) 2005-2006 mozilla.org") - shouldn't it say "Contributors" like it does elsewhere? (This applies to Firefox too.) And shouldn't the dates be 1998-2006 like they are elsewhere? I've just used the string as-is to match the trunk.
Attachment #213245 -
Flags: review?(mscott)
Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 213245 [details] [diff] [review]
Do it
I think I fixed aboutDialog.dtd just recently on the branch.
Attachment #213245 -
Flags: review?(mscott) → review+
Reporter | ||
Comment 3•19 years ago
|
||
Comment on attachment 213245 [details] [diff] [review]
Do it
Only on the 1.8 branch.
Nothing to check in, since the trunk's already got the right dates. Requesting branch approval.
Attachment #213245 -
Flags: approval1.8.0.2?
Attachment #213245 -
Flags: approval-branch-1.8.1?(mscott)
Comment 4•19 years ago
|
||
We agreed on the firefox bug that there is no requirement to bump the copyright
version in the locale files on the 1.8.0 branch.
Assignee | ||
Comment 5•19 years ago
|
||
Do you know what the corresponding Firefox bug for this was?
Updated•19 years ago
|
Attachment #213245 -
Flags: approval1.8.0.3?
Attachment #213245 -
Flags: approval1.8.0.2?
Attachment #213245 -
Flags: approval1.8.0.2-
Comment 6•19 years ago
|
||
(In reply to comment #5)
> Do you know what the corresponding Firefox bug for this was?
>
bug 322172
Assignee | ||
Updated•19 years ago
|
Attachment #213245 -
Flags: approval-branch-1.8.1?(mscott) → approval-branch-1.8.1+
Comment 7•19 years ago
|
||
Comment on attachment 213245 [details] [diff] [review]
Do it
Please check in promptly on the 1.8.0 branch for enUS and make sure to follow up with Axel about getting the other locales updated. Since it's a simple date change, anyone with access to the l10n tree should be able to do the update. Thanks!
Attachment #213245 -
Flags: approval1.8.0.3? → approval1.8.0.3+
Comment 8•19 years ago
|
||
(In reply to comment #7)
> (From update of attachment 213245 [details] [diff] [review] [edit])
> Please check in promptly on the 1.8.0 branch for enUS and make sure to follow
> up with Axel about getting the other locales updated. Since it's a simple date
> change, anyone with access to the l10n tree should be able to do the update.
> Thanks!
>
That is a pretty uneducated guess. There are a few locales which don't use
numbers "anyone with access to the l10n" tree can fix, let alone fix.
As Gerv said in bug 322172 comment 17, there is no reason to land this
on the 1.8.0 branch.
Assignee | ||
Comment 9•19 years ago
|
||
Comment on attachment 213245 [details] [diff] [review]
Do it
I thought we had decided to not take these copy right string changes on the branch. See the Firefox bug Axel cited above.
clearing the approval flag to avoid confusion.
Attachment #213245 -
Flags: approval1.8.0.3+
Comment 10•19 years ago
|
||
My apologies for the "uneducated" guess. We didn't look at the Firefox bug throughly (didn't realize there was no legal obligation to change it) and thought this was going to be a more simple change than it apparently is. If people have discussed this and are ok with shipping a product, that will most likely live through 2007, with an old copyright date, that is fine with me.
Assignee | ||
Comment 11•19 years ago
|
||
I've checked this into the 1.8.1 branch.
Assignee | ||
Comment 12•19 years ago
|
||
*** Bug 346347 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•