328754 - Event/task creation fails if 'Default alarm setting' is set to 'On'

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Event/task creation fails if 'Default alarm setting' is set to 'On'

Go to Sunbird preferences -> Alarms -> Default alarm settings for event/task and set values to 'On'.

Try to create new event --> Creation fails. Error in JavaScript console:

Error: uncaught exception: [Exception... "Cannot modify properties of a WrappedNative"  nsresult: "0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)"  location: "JS frame :: chrome://calendar/content/calendar.js :: newEvent :: line 291"  data: no]

Try to create new task --> Creation fails. Error in JavaScript console:

Error: uncaught exception: [Exception... "Cannot modify properties of a WrappedNative"  nsresult: "0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)"  location: "JS frame :: chrome://calendar/content/calendar.js :: newToDo :: line 328"  data: no]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060227 Mozilla Sunbird/0.3a1+

Comment 1

[Joey Minta]

Attachment: upgrade to new alarm properties

I missed this bit of code when updating the alarm code.  This patch moves the relevant bits to the new alarm properties.

Comment 2

[Stefan Sitter [:ssitter]]

*** Bug 328503 has been marked as a duplicate of this bug. ***

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 213351 [details] [diff] [review]
upgrade to new alarm properties

>+       var units = alarmsBranch.getCharPref("eventalarmunit");
>+       alarmOffset[units] = alarmsBranch.getIntPref("eventalarmlen");

You should wrap those calls to the prefservice in a try/catch block. You never know what someone did to his pref file. (same in newTodo)

r=mvl with that fixed

Comment 4

[Joey Minta]

Patch checked in.

Comment 5

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060909 Calendar/0.3a2+