Disable "Global Inbox" by default

RESOLVED FIXED

Status

SeaMonkey
MailNews: Account Configuration
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Manuel Reimer, Assigned: Manuel Reimer)

Tracking

({fixed-seamonkey1.1, fixed1.8.1.1, late-l10n})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.8.0.1) Gecko/20060126 SeaMonkey/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.8.0.1) Gecko/20060126 SeaMonkey/1.0

If you create a new mail account, then the option "Use global inbox" is checked by default. I think this isn't what someone, who ports from Mozilla to SeaMonkey, expects.

After I (Mozilla user) had created my accounts I was confused as I didn't see my inboxes. I killed all my accounts again and with the second try I saw the checkbox which has to be disabled.

Reproducible: Always

Steps to Reproduce:
Just create a new mail account.
Actual Results:  
The option "global inbox" is enabled by default. This is something that may confuse users that come from mozilla.

Expected Results:  
Global inbox should be disabled by default. This is a nice feature but I think most mozilla users just liked the way it was done in mozilla. If someone wants this new feature then he is able to enable it.

Comment 1

12 years ago
If Seamonkey wants to do this, it can...but Thunderbird is going to stick with the Global Inbox.

Comment 2

12 years ago
Actually, the default for Global Inbox is quite confusing, especially for long-time Mozilla users: you're creating a new account, haven't touched anything strange (at least by feeling) - and it just doesn't show up in the folder pane!
We should turn it off for SM.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Please disable "Global Inbox" by default → Disable "Global Inbox" by default

Comment 3

12 years ago
I don't know how easy that would be given that the wizard is shared code.
Failing that I'd like to see the global inbox in its own wizard page.
At least you'd be more likely to notice it then!

Comment 4

12 years ago
The checkmark is set statically in the XUL, regardless of any prefs. So we could put its 'checked' attribute value into the (non-shared!) .dtd (yuck!) or .properties (only slightly less yucky) or create a pref with different default for SM and TB.
(In reply to comment #0)
> Expected Results:  
> Global inbox should be disabled by default.

See Bug 272340 for request on Thunderbird, which was already WONTFIX'ed.
(Assignee)

Comment 6

12 years ago
(In reply to comment #5)
> See Bug 272340 for request on Thunderbird, which was already WONTFIX'ed.

But SeaMonkey is *NOT* Thunderbird!

I agree with the last comment of Karsten. I think there should be added some setting into one of those files. Of course this would mean that the state of the setting also has to be added to the Thunderbird .dtd file.

Comment 7

11 years ago
*** Bug 357519 has been marked as a duplicate of this bug. ***
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 8

11 years ago
Created attachment 243929 [details] [diff] [review]
First draft for a patch

This is a first try to fix the "global" stuff as this is the difficult part.

As soon as this is fixed I'll create a second patch to do the changes in SeaMonkey

The patch will add a new user_pref. Maybe the name of the pref isn't perfect. Maybe someone else has a better idea. If the pref isn't set at all, then the Thunderbird-Default is used (enabled global inbox). If the pref is set, then the value in the pref will be used. SeaMonkey will have a "false" for this pref after my second patch.
Attachment #243929 - Flags: superreview?
Attachment #243929 - Flags: review?(mnyromyr)
(Assignee)

Comment 9

11 years ago
Created attachment 243966 [details] [diff] [review]
Simplified the code of the first patch

Simplified my first patch. "setAttribute" not longer used. Not longer defining a default in the js file. The setting in the xul file is the default!
Attachment #243929 - Attachment is obsolete: true
Attachment #243966 - Flags: superreview?
Attachment #243966 - Flags: review?(mnyromyr)
Attachment #243929 - Flags: superreview?
Attachment #243929 - Flags: review?(mnyromyr)

Comment 10

11 years ago
Comment on attachment 243966 [details] [diff] [review]
Simplified the code of the first patch

Looks good, just two nits:

>+    // Set default value for global inbox checkbox
>+    var checkGlobalInbox = document.getElementById("deferStorage");
>+    try {
>+        checkGlobalInbox.checked = gPrefs.getBoolPref("mail.accountwizard.default.globalinbox");

The prefname is somewhat excessive and accounts using the "global inbox" feature are called "deferred" in code, so we'd better use something along "mail.accountwizard.deferred": the term "accountwizard" clearly states that it's just a default...

>+    } catch(e) { }

No space inside the braces.
Attachment #243966 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 11

11 years ago
Created attachment 244892 [details] [diff] [review]
The (maybe) final version of the "global" patch

Did the changes, but I've used "mail.accountwizard.deferstorage" as pref as "deferStorage" is also the ID of the button we want to modify with the pref. Maybe this makes things a bit clearer.
Attachment #243966 - Attachment is obsolete: true
Attachment #244892 - Flags: superreview?(bienvenu)
Attachment #244892 - Flags: review+
Attachment #243966 - Flags: superreview?

Updated

11 years ago
Attachment #244892 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 12

11 years ago
Created attachment 245129 [details] [diff] [review]
Second patch which should only affect SeaMonkey

This is the second patch to fix this bug. It just modifies one line in two files. The first is to turn the pref to "false" by default and the second is for modifying the information next to the checkbox (Uncheck --> Check).
Attachment #245129 - Flags: superreview?(neil)
Attachment #245129 - Flags: review?(mnyromyr)
Attachment #245129 - Flags: approval-seamonkey1.5a?
Attachment #245129 - Flags: approval-seamonkey1.1?
(Assignee)

Updated

11 years ago
Attachment #244892 - Flags: approval-seamonkey1.5a?
Attachment #244892 - Flags: approval-seamonkey1.1?

Comment 13

11 years ago
Comment on attachment 245129 [details] [diff] [review]
Second patch which should only affect SeaMonkey

Can you update the Help documentation as well, please?
 
mail_help.xhtml:

153       <li>If you want this account to be a part of the Local Folders Global
154         Inbox account, keep the <q>Use Global Inbox</q> box checked. Mail for
155         this account will then be stored in your Local Folders. Otherwise, if
156         the checkbox is unchecked, mail will be stored in its own
157         directory.</li>

Comment 14

11 years ago
Comment on attachment 245129 [details] [diff] [review]
Second patch which should only affect SeaMonkey

>+<!ENTITY deferStorageDesc.label "Check this checkbox to store mail for this account in the Local Folders Global Inbox. Otherwise the account appears as a top-level account and its mail is stored in its own directory.">

I'm no native English speaker, but maybe:
- Local Folders don't have something named "Global Inbox" -> just "Local Folders' Inbox"?
- "the account appears ... mail is stored" -> "the account will appear ... mail will be stored"?

r=me with that, supposing Neil doesn't object. ;-)
Attachment #245129 - Flags: review?(mnyromyr) → review+

Updated

11 years ago
Attachment #245129 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 15

11 years ago
Created attachment 245378 [details] [diff] [review]
Patch to fix the help system, as suggested by Stefan

This will correct the text in the help system ("leave checked" -> "check").

As soon as this gets r+ and sr+, could someone please check all that stuff in whereever it's possible? Please also make it possible to get this fix into 1.0.7 (I don't have "approval-seamonkey1.0.7" here).
Attachment #245378 - Flags: superreview?(neil)
Attachment #245378 - Flags: review?(mnyromyr)
Attachment #245378 - Flags: approval-seamonkey1.5a?
Attachment #245378 - Flags: approval-seamonkey1.1?
(Assignee)

Comment 16

11 years ago
(In reply to comment #14)
> I'm no native English speaker, but maybe:
> - Local Folders don't have something named "Global Inbox" -> just "Local
> Folders' Inbox"?
> - "the account appears ... mail is stored" -> "the account will appear ... 
> mail will be stored"?

I'm also no native english speaker, but your solution also sounds nice ;-)

But my solution seems to be not completely wrong as Neil gave sr+

Comment 17

11 years ago
Comment on attachment 245378 [details] [diff] [review]
Patch to fix the help system, as suggested by Stefan

Sorry, I didn't read the text that carefully last time.
Attachment #245378 - Flags: superreview?(neil) → superreview+

Updated

11 years ago
Whiteboard: approval-seamonkey1.0.7? for all three SM patches

Comment 18

11 years ago
Comment on attachment 245378 [details] [diff] [review]
Patch to fix the help system, as suggested by Stefan

Could be hard to get the help changes "through" the string freeze of 1.1, though...
Attachment #245378 - Flags: review?(mnyromyr) → review+

Comment 19

11 years ago
(In reply to comment #18)
> (From update of attachment 245378 [details] [diff] [review] [edit])
> Could be hard to get the help changes "through" the string freeze of 1.1,
> though...
> 

And the string changes in AccountWizard.dtd ...

Comment 20

11 years ago
Comment on attachment 244892 [details] [diff] [review]
The (maybe) final version of the "global" patch

1.5a doesn't need approvals (yet), this flag doesn't make sense.
Additionally, as you did mention it, this is no regression, stability or security fix and therefore has no reason to go into 1.0.x (1.8.0 branch).
Attachment #244892 - Flags: approval-seamonkey1.5a?

Updated

11 years ago
Attachment #245129 - Flags: approval-seamonkey1.5a?

Updated

11 years ago
Attachment #245378 - Flags: approval-seamonkey1.5a?

Updated

11 years ago
Whiteboard: approval-seamonkey1.0.7? for all three SM patches

Updated

11 years ago
Keywords: late-l10n

Comment 21

11 years ago
Comment on attachment 244892 [details] [diff] [review]
The (maybe) final version of the "global" patch

a=me (first-a=CTho) for SeaMonkey 1.1, this is a shared file though, so we need global (or Thunderbird) approval for this part.
Attachment #244892 - Flags: approval1.8.1.1?
Attachment #244892 - Flags: approval-seamonkey1.1?
Attachment #244892 - Flags: approval-seamonkey1.1+

Comment 22

11 years ago
Comment on attachment 245129 [details] [diff] [review]
Second patch which should only affect SeaMonkey

a=me (first-a=CTho) for SeaMonkey 1.1

We'll need to inform localizers of this late-l10n change, but if they don't take the change in their L10n, nothing is badly wrong, so we'll go for it (same thing goes for the help change).
Attachment #245129 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+

Updated

11 years ago
Attachment #245378 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+

Updated

11 years ago
Assignee: mail → Manuel.Spam
Status: ASSIGNED → NEW
(Assignee)

Comment 23

11 years ago
(In reply to comment #21)
> (From update of attachment 244892 [details] [diff] [review] [edit])
> a=me (first-a=CTho) for SeaMonkey 1.1, this is a shared file though, so we need
> global (or Thunderbird) approval for this part.

Maybe David is able to give approval or at least he may tell us who could give approval for us?

Comment 24

11 years ago
mscott@mozilla.org can give approval for the tb part.

Comment 25

11 years ago
Scott, the SM people are interested in getting this in for their 1.8.1 branch based build.

Updated

11 years ago
Attachment #244892 - Flags: approval1.8.1.1? → approval1.8.1.1+

Comment 26

11 years ago
Landed on trunk and MOZILLA_1_8_BRANCH.
Keywords: fixed-seamonkey1.1, fixed1.8.1.1

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 27

11 years ago
Did this result in bug 372415 ?
You need to log in before you can comment on or make changes to this bug.