329047 - 1.5.0.2 nightlies ABI incompabilities with 1.5

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

When verifying bug 321244, ssitter noticed that branch Lightning nightlies now work with 1.5 but not 1.5.0.2 nightlies, and found compiler differences between the two builds on the Thunderbird side.  Not using the same toolchain breaks compatibility, so in addition to effecting Lightning, it would likely break other C++ extensions that don't or can't link with XPCOM glue.

Comment 1

[Scott MacGregor]

Hey Dan can you be more specific?

I'm not a linux expert so I'm not sure what differences you found. I set up the build machine based on a VM image the build team gave me that they were using for Firefox 1.5.0.2 test builds. So it should be using the same build tools those firefox test builds were using. 

The build machine I've configured for these branch builds is esx-test-vm1
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8.0

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

The effect of this bug is that it's currently not possible to build a non-glue-linked C++ extension and have that same build work in both 1.5 and 1.5.0.2-nightly.  My understanding from talking to preed is that the Firefox build had the same problem, and he's already fixed it there.

Comment 3

[Scott MacGregor]

Paul, is it possible that the linux VM box you gave me had the same compiler problem that moz180-linux-tbox had when we did 1.5.0.1? 

Comment 4

[Scott MacGregor]

Both the production linux VM builds for thunderbird and firefox are using
gcc 3.2.3-53 when I type gcc --version on each of the machines.

Ah but wait, in the tinder-config for the firefox build I see:

tinder-config.pl:$ENV{'PATH'} = "/opt/gcc-3.3.2rh/bin:$ENV{'PATH'}";

I don't have this line in Thunderbird's tinder-config. I suspect that's the fix Paul must have added when we had this problem for Firefox 1.5.0.1.

Comment 5

[Scott MacGregor]

I just added the forementioned environment variable to the tinder-config file and re-kicked the builds. Hopefully things will look much better in the morning.

What a great catch. It would have been really bad to have released 1.5.0.2 with this!

Comment 6

[Scott MacGregor]

builds are up if you want to test them ssitter:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2006-03-02-00-mozilla1.8.0/

Comment 7

[Stefan Sitter [:ssitter]]

Retested with Lightning 0.0.1+ (20060302) from
http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-mozilla1.8/

and Thunderbird 1.5 (20051201) from
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/releases/1.5/linux-i686/en-US/

and Thunderbird 1.5.0.2 (20060302) from
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-mozilla1.8.0/

and Thunderbird 2.0a1 (20060302) from
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-mozilla1.8/

All three combinations work fine. No crash anymore. Thanks for fast fixing Scott.

Comment 8

[Scott MacGregor]

what a relief. Great catch.

Comment 9

[Scott MacGregor]

Stefan, can you test this again with the linux build posted on:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/1.5.0.2-candidates/

I want to make sure this change didn't regress.

Comment 10

[Stefan Sitter [:ssitter]]

(In reply to comment #9)
> Stefan, can you test this again with the linux build posted on: ...

Sure: Thunderbird 1.5.0.2 (20060308) (en-US and de-DE) works fine with Lightning 0.1 (20060310). Everything seems OK with this builds.

(I can't test with a recent Lightning nightly build because the Lightning tinderbox is configured wrong, see Bug 321244 Comment #34)

Comment 11

[Scott MacGregor]

It turns out there was a compiler and linker issue with the tinderbox machine we were using for 1.5.0.2 (see Bug #334707) so we had to respin, and make a new linux version of 1.5.0.2 which is now here:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/1.5.0.2-candidates/thunderbird-1.5.0.2.en-US.linux-i686.tar.gz

Our QA folks have installed the lightning.xpi from 03-10, but it couldn't hurt to have others try it out too.