329817 - events do not have calendar colors. only blue.

Status: RESOLVED FIXED

Description

[Kenton]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: thunderbird version 1.5 (20051201) - lighting build 2006030708

color coding for the calendar is no working. all the events are blue and all of the calendar names listed are black (blue BG when selected). 

with colored events will the border be a dark sade of the color and the event be a light shade? So an event can be light red with a dark red border.

Reproducible: Always

Steps to Reproduce:
1.creating multiple events and calendars wit different colors.
2.
3.

Actual Results:  
events are blue with a darker blue border.

Expected Results:  
an event can be light red with a dark red border. then when selected it can be all light red (border and event) or all dark red with white text.

OSX 10.4

Comment 1

[Stefan Sitter [:ssitter]]

Did you restart Thunderbird after changing the calendar color?

Comment 2

[Joey Minta]

Are there any errors in the javascript console?

Comment 3

[Kenton]

No, I did no restart after changing the color, and the colors do show today after restarting thunderbird.

Currently there is an error in the java Console: Error: GetThreadTree is not defined. Source file: chrome://messenger/content/mail3paneWindowCommand.js line:715

Comment 4

[Kenton]

Sorry for calling your attention to this bug as a major bug if it isn't.

But I would like the second part of the bug look at too when there is time. That the colors of the event be more pleasing and cordinated. so that you don't have a bright red event with a darker blue border. but that the colors go together with not so bright red and a thin darker and rich red border. then (like in ical) rather than changing color to yellow it will thick the border and maybe darken the main event color a little.

Comment 5

[Joey Minta]

(In reply to comment #4)
> That the colors of the event be more pleasing and cordinated. so that you don't
> have a bright red event with a darker blue border. but that the colors go
> together with not so bright red and a thin darker and rich red border. then
> (like in ical) rather than changing color to yellow it will thick the border
> and maybe darken the main event color a little.
> 
In Sunbird, the color of the border of the event is reserved for the event's category, allowing for both the calendar and the categor to be visually represented.  Something very much along these lines is planned for Lightning. 

Comment 6

[Kenton]

Are there any plans to make the look more pleasing?

Can I work on some ideals for the look and feel of the events and calendar?
If so how can I submit some ideas?

Comment 7

[Kenton]

Also when the thunderbird window is closed (program still running) and then you open thunderbird's window again. the colors for the calendars are completely missing until you click on each one of the calendars.

Comment 8

[Michael Büttner (no reviews TFN)]

(In reply to comment #6)
Yes, there are plans to make the look more pleasing. Our user experience team is currently working on a proposal to address this issue. The final draft will probably be ready end of march. But new ideas are of course always welcome, so feel free to file a new bug and post your proposal there.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Also see bug 327760 (but please keep the discussion in that bug on a higher level. So not about a slightly different tone of blue, but about using green instead of blue)

Comment 10

[Martin Schröder [:martinschroeder]]

I have a calendar with no color choosen. When editing the calendar without changing to an 'real' color I get the following errors.

From JavaScript Console in latest Sunbird nightly:
Warning: Error in parsing value for property 'background-color'.  Declaration dropped.
Source File: chrome://calendar/content/calendarProperties.xul
Line: 0

and

Warning: Expected color but found 'null'.  Error in parsing value for property 'background-color'.  Declaration dropped.
Source File: chrome://calendar/content/calendarProperties.xul
Line: 0

Also, the events of my first calendar, which has no color selected, are colored blue by default. I tried to investigate this by myself but wasn't unsuccessful. Maybe this is also a cause for the behavior observed in this bug.

Comment 11

[Joey Minta]

Created attachment 221898 [details] [diff] [review]
fix warnings

This is a patch to get rid of the warnings referenced in comment #10.  Doesn't fix the main bug, however.

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 221898 [details] [diff] [review]
fix warnings

r=mvl

Comment 13

[Joey Minta]

Comment on attachment 221898 [details] [diff] [review]
fix warnings

patch checked in.  Leaving bug for the other stuff.

Comment 14

[Stefan Sitter [:ssitter]]

(In reply to comment #0)
> Actual Results:  
> events are blue with a darker blue border.

(In reply to comment #3)
> No, I did no restart after changing the color, and the colors
> do show today after restarting thunderbird.

(In reply to comment #13)
> patch checked in.  Leaving bug for the other stuff.

#0) is default behavior and expected to work this way
#3) colors work after restart (Bug 330183)

Is there anything open? I would suggest to file new bugs for enhancement requests for the default theme and close this bug.

Comment 15

[Joey Minta]

(In reply to comment #14)
> Is there anything open? I would suggest to file new bugs for enhancement
> requests for the default theme and close this bug.
> 
I agree, this bug has tried to hit too many areas.  Please file new ones, for specific issues that you may feel are still open.  Closing as fixed for the color warning.

Comment 16

[Reed Loden [:reed] (use needinfo?)]

The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!