329853 - Places Library should remember the last opened folder in the left pane

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect, P3)

Description

[Ryuichi KUBUKI]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060308 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060308 Firefox/1.6a1

Places should remember the last opened folder in the left pane (at least in the same session).

Currently if you open Places it always opens History even though you opened Bookmarks Menu the last time you opened Places.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Asaf Romano (gone)]

Also, double-click on the grippy doesn't collapse the left pane.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[Asaf Romano (gone)]

Comment on attachment 251360 [details] [diff] [review]
patch

er, wrong bug.

Comment 4

[Ryuichi KUBUKI]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007122411 Minefield/3.0b3pre ID:2007122411

A minor behavior change, All Bookmarks is loaded now, still without remembering the last opened folder

Comment 5

[Marco Bonardo [:mak]]

possible patch in bug 405010

Comment 6

[Marco Bonardo [:mak]]

See discussione in bug 405010

Show All Bookmarks should always point to "All Bookmarks" or should
remember the last selected folder as in FX2? 

Or do we need a new menu item to
open the Library to the last selected position?

Comment 7

[Marco Bonardo [:mak]]

Attachment: patch

Comment 8

[Marco Bonardo [:mak]]

actually this patch does not remember position by itself (because the menu command has AllBookmarks hardcoded as a windows argument), needs a new menu item, or removing the argument.

Comment 10

[skierpage]

(In reply to comment #6)

> Show All Bookmarks should always point to "All Bookmarks" or should
> remember the last selected folder as in FX2? 

Here's the use case that prompted my bug 441641 now marked as duplicate:
I am re-visiting a subset of the pages in a bookmarks folder (e.g. "To Follow up" or "My recent posts").  I want to open bookmarks one after another but don't want to Open All in Tabs.

Steps to Reproduce:
1. Open the Library with Bookmark > Organize Bookmarks...
2. Navigate to a subfolder of your Bookmarks Menu and select a bookmark.
3. Return focus to the main browser window.
4. Choose Bookmark > Organize Bookmarks... (or its keyboard shortcut Ctrl+Shift+B) again.

It is clearly incorrect & unexpected behavior for this sequence to reset the Library navigation tree pane to All Bookmarks, losing my place.

Comment 11

[Nochum Sossonko [:Natch]]

Marco with this patch, what happens if the node that was last selected is deleted? Also, what if the selected item is a shortcut folder (where I believe the id lives in folderItemId?), isn't that what getConcreteItemId was created for?

Comment 12

[Marco Bonardo [:mak]]

(In reply to comment #11)
> Marco with this patch, what happens if the node that was last selected is
> deleted? 
IIRC if the persisted node is no more valid it is going back to the default

Also, what if the selected item is a shortcut folder (where I believe
> the id lives in folderItemId?), isn't that what getConcreteItemId was created
> for?

a folder shortcut has an itemId, so i don't understand the problem, saving the concreteId would be wrong since i could have more shortcuts to that id.

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 307185 [details] [diff] [review]
patch

Looks good.

Comment 15

[Marco Bonardo [:mak]]

not actively working on this and waiting for future plans for the Library.

Comment 16

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 17

[Mike de Boer [:mikedeboer]]

There is no more generic case to open the Places window, just very target menu items that direct your to Bookmarks, Downloads or History right away.