330238 - Bookmark Properties box too small to fit buttons

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Ryan Jones-Ward [:sciguyryan]]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060311 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060311 Firefox/1.5

Basically the edge of the window slices the buttons in half, everytime.

Also the same in Organise Bookarks.

Reproducible: Always

Steps to Reproduce:
1. Bookmarks -> Right Click on a bookmark -> Properties
2.
3.

Actual Results:  
Window opened and buttons were hidden (Partially).

Expected Results:  
Window should open and buttons should not be hidden, window size should not cut through the buttons.

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Showing the partially hidden buttons.

Comment 2

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060318 Firefox/1.6a1 ID:2006031801 [cairo]

confirmed

I'm seeing the same using default win2k settings

Comment 3

[Shawn]

also seeing the same probelm using xp pro

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 331033 has been marked as a duplicate of this bug. ***

Comment 5

[Steve Russell (RaiseMachine)]

Adding this to your userChrome.css file is a temp workaround.

#bookmarkproperties { height: 15em !important; }

Comment 6

[Spencer Selander [greenknight]]

On my machine, with XP Home, Branch or Trunk, the buttons are completely hidden.

Comment 7

[Phil Ringnalda (:philor)]

*** Bug 331237 has been marked as a duplicate of this bug. ***

Comment 8

[Andreas Korthaus]

(In reply to comment #7)
> *** Bug 331237 has been marked as a duplicate of this bug. ***
> 

Not sure if it's really the same bug, I'm talking about Firefox 2.0 nightly and the "Add Bookmark" Windows, not "Bookmark Properties"...

I will attatch a screenshot!

Comment 9

[Andreas Korthaus]

Attachment: Screenshot of hidden buttoms also in "Add Bookmark" window (2.0 only)

Screenshot of the problem reportet in bug #331237 (hidden buttons in "add bookmark" window - Firefox 2.0):

https://bugzilla.mozilla.org/attachment.cgi?bugid=331237

Comment 10

[Phil Ringnalda (:philor)]

*** Bug 331435 has been marked as a duplicate of this bug. ***

Comment 11

[Joe Hughes]

*** Bug 331495 has been marked as a duplicate of this bug. ***

Comment 12

[Joe Hughes]

Attachment: Patch to fix dialog size problem

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 216138 [details] [diff] [review]
Patch to fix dialog size problem

sr=[e-mail]

Comment 14

[Joe Hughes]

Landed on branch & trunk.

Comment 15

[Andreas Morawietz]

you should also create a minimum-size for this window. So user can't make the window smaller than a specified size.
That would look more professionell.

Comment 16

[Joe Hughes]

Good point, Andreas--to that end, I've filed bug 331717 on myself.

Comment 17

[Dave Townsend [:mossop]]

*** Bug 332025 has been marked as a duplicate of this bug. ***

Comment 18

[Phil Ringnalda (:philor)]

*** Bug 335519 has been marked as a duplicate of this bug. ***

Comment 19

[Aurélien DANG]

(In reply to comment #18)
> *** Bug 335519 has been marked as a duplicate of this bug. ***
> 

I've been the original Bug #335519 reporter so thx Phil to help me learn to use bugzilla ! ;-)

Comment 20

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv