330452 - about:blank transfer state inconsistency

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Simon Bünzli]

about:blank is treaded as a non-page in many places (e.g. it isn't displayed in the address bar). Because of this, it probably shouldn't have a transfer state ("Done") in the status bar either. However, it mostly does.

Reproducible: Always

Steps to Reproduce:
1. Set your homepage to about:blank ("Use Blank Page")
2. Open a new window
3. Load your homepage

Actual Results:
After step 2 the status bar is empty; after step 3 it displays "Done".

Expected Results:
There should be no difference between steps 2 and 3 (both load about:blank in the current tab).

Comment 1

[Simon Bünzli]

Attachment: no transfer state for about:blank

This fixes the regression on bug 37987.

Comment 2

[Simon Bünzli]

Comment on attachment 215008 [details] [diff] [review]
no transfer state for about:blank

Suppose I don't need superreview for this. Requesting checking.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 215008 [details] [diff] [review]
no transfer state for about:blank

SR isn't required for browser/toolkit

Comment 4

[Jonathan Louie]

Sorry if this is off the mark (I'm not a Mozilla programmer), but don't you need to close the quotes, after about:blank?

Comment 5

[Simon Bünzli]

Attachment: patch for checkin

Thanks for spotting this, Jonathan.

Comment 6

[Wayne Woods]

It looks like a new tab temporarily adopts whatever status was in the previous tab just before it was created (this is AFTER bug 327604 was fixed), and then "Done" after any subsequent tab switches, regardless of the status of thosee other tabs.

So if you're loading a page in one tab, then create a new one, the status bar for the new tab will accordingly say "Connected to...", "Waiting for... " or "Transferring data from...". This message is static, like in bug 327604. But if you switch back to the still-loading tab (or any other tab for that matter) and then back to the new tab, then its status bar now says "Done", even if the previous tab still has a loading message.

Will this patch fix that issue as well?

Comment 7

[Simon Bünzli]

(In reply to comment #6)
> Will this patch fix that issue as well?

That's a different issue. I've filed bug 331938 for it (patch included).

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.479.2.102
mozilla/browser/base/content/browser.js 	1.599

Comment 9

[Simon Bünzli]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060828 BonEcho/2.0b2 ID:2006082803.