331671 - ICO decoder doesn't handle alpha (transparency) properly (images wrongly drawn with black backgrounds)

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Some icons have a black background.
I see some icons of the type .png without black background so maybe .ico icons are not displayed properly?

Comment 1

[Ria Klaassen (not reading all bugmail)]

Attachment: screenshot

Comment 2

[Ria Klaassen (not reading all bugmail)]

Regression between 1.9a1_2006032412 and 1.9a1_2006032421. 

Comment 3

[Régis Caspar]

Confirmed. see favicon of http://www.mozilla.com/
landing of #331298 [Core:GFX: Thebes]-Speed up image drawing/decoding [Win] looks like a good culprit

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060325 Firefox/1.6a1 ID:2006032505

Comment 4

[Stuart Parmenter]

will fix shortly.

Comment 5

[Stuart Parmenter]

*** Bug 331941 has been marked as a duplicate of this bug. ***

Comment 6

[Wayne Woods]

Adding to the Summary, so that people who aren't graphics experts can still find it in Bugzilla ;)

Comment 7

[Steve England [:stevee]]

*** Bug 331994 has been marked as a duplicate of this bug. ***

Comment 8

[Mark Romero]

I have also noticed that while some images are loading, the parts that have not yet be rendered show up as black. Is this related or should I file a seperate bug report?

Comment 9

[Bill Gianopoulos [:WG9s]]

(In reply to comment #8)
> I have also noticed that while some images are loading, the parts that have not
> yet be rendered show up as black. Is this related or should I file a seperate
> bug report?
> 
That is bug 326672.

Comment 10

[Kevin Brosnan]

*** Bug 332508 has been marked as a duplicate of this bug. ***

Comment 11

[Daniel C]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060407 Firefox/3.0a1

I see this on Linux.

Comment 12

[Phil Ringnalda (:philor)]

*** Bug 333255 has been marked as a duplicate of this bug. ***

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 333367 has been marked as a duplicate of this bug. ***

Comment 14

[Brett Wilson]

*** Bug 333768 has been marked as a duplicate of this bug. ***

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Not sure if this fits with Stuart's plans, but this annoyed me enough to fix it.

This doesn't ifdef out all of the code that's no longer needed; just some of it.

Comment 16

[Julien Moorrees]

This still happens in the latest minefeeld:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060413 Firefox/3.0a1

Comment 17

[Stuart Parmenter]

Comment on attachment 218253 [details] [diff] [review]
patch

lets get this in

Comment 18

[Kevin Brosnan]

*** Bug 334131 has been marked as a duplicate of this bug. ***

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.

Comment 20

[Glenn Randers-Pehrson]

WFM using the latest "auenf" build of FF3.0a which uses CAIRO.  Marking "verified fixed".

Comment 21

[Kevin Brosnan]

*** Bug 334172 has been marked as a duplicate of this bug. ***

Comment 22

[Jesse Ruderman]

Something still isn't right.  I filed bug 335108, "ICO alpha handling still isn't quite right: gray tab background treated as pink background".

Comment 23

[Niro]

some problems fixed such as bug 332508 which is duplicate of this bug but some cases such as the following image, still has a black background:
http://www.techno.co.il/images/avatars/Cartoon/1739.gif

Comment 24

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Both this bug and bug 322508 are about ICO images; that's a GIF, so a different bug.