332268 - Editing start date of all day events adds extra day to end date

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Editing start date of all day events adds extra day to end date

When changing the start date of an all day event in Edit Event dialog an extra day is added to the end date.

Steps to Reproduce:
1. Create all day event on 30-Mar-2006
2. Open 'Edit Event' dialog and change start date to 31-Mar-2006. Press OK.

Actual Results:
Start date is changed to 31-Mar-2006 and end date is changed to 01-Apr-2006. Event now lasts two days instead of one.

Expected Results:
Start date and end date are both changed to 31-Mar-2006. Event lasts one day.

Every time you repeat this procedure an extra day is added.

Seems independed of local timezone (tested in GMT-5, GMT and GMT+2) so my guess is that the patch from bug 327832 does not handle all day events correctly.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060329 Mozilla Sunbird/0.3a1+ and Lightning 0.1+ (20060630)

Comment 1

[Stefan Sitter [:ssitter]]

Same with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060330 Mozilla Sunbird/0.3a1+

Blocking bug 330188?

Comment 2

[Joey Minta]

Attachment: subtract a day for allday events

yeah yeah, all day end-dates are exclusive.

Comment 3

[Joey Minta]

Attachment: subtract a day for allday events

yeah yeah, all day end-dates are exclusive.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 216795 [details] [diff] [review]
subtract a day for allday events

r=mvl
(stricly speaking, gItemDuration for a one-day event should actually be one day, and then you could correct later. But your solution is simple enough, and will likely cause less confusion later.)

Comment 5

[Joey Minta]

Patch checked in.

Comment 6

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060914 Calendar/0.3a2+