332414 - Improve publishEntireCalendar() to ask user for calendar if no calendar is specified

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Improve publishEntireCalendar() to ask user for calendar if no calendar is specified

During my work on Bug 327912 I noticed that I need to call 'Publish Entire Calendar' without a specific calendar from file menu. The user should be prompted to select a calendar, similar to what is already done during import/export.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: patch, v1

- use chooseCalendarDialog.xul to ask for calendar in publishEntireCalendar()
- improve documentation in publish.js
- call publish dialog with option 'resizable' to improve working with long urls

Comment 2

[Joey Minta]

Comment on attachment 216877 [details] [diff] [review]
patch, v1

Is it possible at all right now to hit the chooseCalendarDialog with this patch?  Everything I'm seeing in lxr says that we pass in a calendar.

Comment 3

[Stefan Sitter [:ssitter]]

(In reply to comment #2)
> Is it possible at all right now to hit the chooseCalendarDialog with this
> patch?  Everything I'm seeing in lxr says that we pass in a calendar.

Right. At the moment we always pass in a calendar so we would never hit the chooseCalendarDialog. But with Bug 327912 I'll add the 'publish entire calendar' command to the File menu too and in this case no calendar will be passed in and the user should be asked to select one.

Comment 4

[Joey Minta]

Comment on attachment 216877 [details] [diff] [review]
patch, v1

+   openDialog("chrome://calendar/content/publishDialog.xul", "caPublishEvents", 
+              "chrome,titlebar,modal,resizable", args );
Let's not have the trailing space before );.  No need to submit another iteration, I'll fix it before checkin.

r=jminta, but not for 0.3a2.

Comment 5

[Joey Minta]

Patch checked in.