Closed Bug 332414 Opened 14 years ago Closed 14 years ago

Improve publishEntireCalendar() to ask user for calendar if no calendar is specified

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

References

Details

Attachments

(1 file)

Improve publishEntireCalendar() to ask user for calendar if no calendar is specified

During my work on Bug 327912 I noticed that I need to call 'Publish Entire Calendar' without a specific calendar from file menu. The user should be prompted to select a calendar, similar to what is already done during import/export.
Attached patch patch, v1Splinter Review
- use chooseCalendarDialog.xul to ask for calendar in publishEntireCalendar()
- improve documentation in publish.js
- call publish dialog with option 'resizable' to improve working with long urls
Attachment #216877 - Flags: first-review?(jminta)
Comment on attachment 216877 [details] [diff] [review]
patch, v1

Is it possible at all right now to hit the chooseCalendarDialog with this patch?  Everything I'm seeing in lxr says that we pass in a calendar.
(In reply to comment #2)
> Is it possible at all right now to hit the chooseCalendarDialog with this
> patch?  Everything I'm seeing in lxr says that we pass in a calendar.

Right. At the moment we always pass in a calendar so we would never hit the chooseCalendarDialog. But with Bug 327912 I'll add the 'publish entire calendar' command to the File menu too and in this case no calendar will be passed in and the user should be asked to select one.
Comment on attachment 216877 [details] [diff] [review]
patch, v1

+   openDialog("chrome://calendar/content/publishDialog.xul", "caPublishEvents", 
+              "chrome,titlebar,modal,resizable", args );
Let's not have the trailing space before );.  No need to submit another iteration, I'll fix it before checkin.

r=jminta, but not for 0.3a2.
Attachment #216877 - Flags: first-review?(jminta) → first-review+
Status: NEW → ASSIGNED
Whiteboard: [needs landing]
Patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.