33312 - WinGFX: need full support for css system fonts

Status: RESOLVED INCOMPLETE

(Core Graveyard :: GFX: Win32, defect, P3)

Description

[Pierre Saslawsky]

I implemented the css system fonts in XP code and on the Mac (that was bug 3371). 
We need to complete the job in GetSysFontInfo() in nsDeviceContextWin.cpp. It 
should be easy: you have already done most of it.

The testcase from bug 3371 is copied in the URL above.

Comment 1

[xiaotong]

Attachment: implementation of CSS2 system fonts

Comment 2

[xiaotong]

I've modified the code GetSysFontInfo() for CSS2 (not CSS3) system fonts and 
attached it in the previous attachment.

Sherry Wang
[e-mail]

Comment 3

[rods (gone)]

mass-move to M16

Comment 4

[rickg]

Non-essential for m16

Comment 5

[Chris Hill]

Looks like this was added.  Awesome!

I did have a problem. The caption font on my system is bold, but the font-weight 
isn't getting picked up by "font: caption".  If I use an italic font, that is 
reflected.  Even if I do "font: caption" and later "font-weight: bold", it 
doesn't work (it does with italic and font-style).

I looked at the patch and I don't think the problem is there, although the 
mapping from the LOGFONT to nsFont weight could be handled better.  The weight 
can take on more values than bold and normal.

Several of my system fonts are "MS Sans Serif", which is a bitmap font.  I don't 
think mozilla supports raster fonts, but it should choose an appropriate 
substitute.  On my system, it looks like it is choosing "Times New Roman".

These issues might extend beyond this bug.

Comment 6

[Erik van der Poel]

MS Sans Serif doesn't work because it's a bitmap font. See bug 22031.

Comment 7

[rods (gone)]

moving to M18

Comment 8

[Pierre Saslawsky]

CCd Ben who told me that an external contributor (Matt?) had done it or had 
worked in that area. Ben, any details?

Comment 9

[Michael Lowe]

[e-mail]: I checked in an improved version of the patch that 
[e-mail] attached to this bug report.   In addition to the 2 problems 
that Chris Hill mentioned above, the fonts I used for the CSS3 properties should 
probably be improved.   I mapped all CSS3 properties to a fixed size GUI font.   
Instead, each of them should probably be mapped to one of the fonts returned by 
the Windows APIs for the CSS2 properties.

Comment 10

[Phil Peterson]

Nominate for nsbeta3 since it's required for Classic skin to work right

Comment 11

[ekrock's old account (dead)]

Adding skins keyword per Phil's comment.

Comment 12

[rods (gone)]

*** Bug 11285 has been marked as a duplicate of this bug. ***

Comment 13

[Kevin McCluskey (gone)]

Marking nsbeta3+

Comment 14

[Kevin McCluskey (gone)]

Setting priority to P1

Comment 15

[rods (gone)]

This now works (mostly) on all platforms, Linux was just checked in. I wouldn't 
consider it complete, which is why I am NOT closing out the bug. More 
reasearch needs to be done on what fonts and font sizes are needed for the 
various CSS3 fonts.

But I am downgrading it from nsbeta3, because it gives us enough for the first 
release.

removing nsbeta3 and setting to future

Comment 16

[Braden]

*** Bug 55565 has been marked as a duplicate of this bug. ***

Comment 17

[Braden]

Attachment: Test case for CSS2 system fonts

Comment 18

[Braden]

Actually, I can't see that CSS2 system fonts are working at all on Linux. The
attached test case gives me 12pt Helvetica for all fonts, regardless of the font
used in my GTK theme.

Comment 19

[Braden]

Okay, I think this bug was set up to track the issue with Windows. Bug 33313
tracks the issue with Linux/GTK.

Comment 20

[rods (gone)]

This is fixed now

Comment 21

[Koike Kazuhiko]

A Japanese user reported system fonts don't work on Win95.
This bug should be reopened.

http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=457

Comment 22

[rods (gone)]

I'll need help with this, I do not have access to anything other than English 
WinNT

Comment 23

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 24

[Koike Kazuhiko]

0.8 works fine for Win95-J. 

Comment 25

[Roland]

Attachment: Screen capture from TopStyle showing IE and Moz rendering the same stylesheet - note the differences in rendering the fonts...

Comment 26

[Roland]

System fonts not quite working yet - look at the attachment (above) to 
see the differences in how IE 5.5 and Mozilla render system fonts:

For example - "caption" font should be bold, whereas Mozilla seems to ignore that.

It seems there are some size differences also, though I might be mistaken (I
tried to set fixed size - that didn't change anything). 

OH yes - I use Moz 0.9

Comment 27

[rods (gone)]

Roland, please attach an example to test with, thanks.

Comment 28

[Greg K.]

For reference, the relevant CSS 2 spec. URL is
[http://www.w3.org/TR/REC-CSS2/fonts.html#x27].

Using FizzillaCFM/2002071208, the testcase doesn't appear entirely right.

caption: not sure what OS X element this should be patterend after.
icon: appears to be correct.
menu: too small
message-box: appears to be correct.
small caption: I think this is probably supposed to be like the text shown under
toolbar icons in the OS X Finder. If so, this shouldn't be bold.

Setting All/All.
status bar: appears to be correct.

Comment 29

[Felix Miata]

Attachment: screenshot @ 96 DPI SuSE 8.2 KDE/XFree86

In intl.css we specify: window {font: 3mm tahoma,arial,helvetica,sans-serif;},
which is what menubar seems to inherit. 3mm at 96 DPI should be 11.34px. We
almost get it, getting 12-13px instead.

Comment 30

[Felix Miata]

Attachment: screenshot @ 72 DPI SuSE 8.2 KDE/XFree86

3mm at 72 DPI should be 8.5px. We get 12-13px instead, same as at 96 DPI.

Comment 31

[Felix Miata]

Attachment: screenshot @ 144 DPI SuSE 8.2 KDE/XFree86

3mm at 144 DPI should be 17px. We get 12-13px instead, same as at 96 DPI.

Comment 32

[Felix Miata]

Attachment: tabulation of current behavior on various systems

Attachment is source of current
http://calicovial.no-ip.com/SS/fonts/mozchrome/chromesizetable.html which has
my tabulation of what we are currently doing. GTK2 & Win seem right, but GTK1
definitely isn't very friendly. URL has screenshots I won't attach here unless
requested.

Comment 33

[Felix Miata]

Attachment: screenshot GTK1 Moz trunk on fullscreen 1400x1050 120 DPI SuSE 8.2 KDE 3.1 desktop

We don't seem to be using any system font, CSS2 menu or otherwise. What we do
use is much too small for the context.

Comment 34

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This bug is long since fixed.  Please file new issues in other bugs.

Comment 35

[Felix Miata]

Attachment 169675 [details] was intended to support comment 9 & comment 18, which seem to
indicate this bug was never properly fixed in the first place. If this was
"fixed", what bug(s)/patch(es) fixed it?

Comment 36

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, after testing on Windows, reopening and restoring roughly original
summary and platform.

Comment 37

[Justin Wood (:Callek)]

Hmm, David willing to comment on what the outstanding issue is on this bug,
would be useful for a clearly written "what" on this, after all the confusion,
especially since the summary was changed to something it shouldnt have been before.

Comment 38

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

comment 9

Also, I was just restoring the summary roughly to what it was originally; it
should never have been changed.