16729 - Widgets in Modern skin should use CSS2 system fonts

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Ian Tommins ('thelem')]

Since moving the XUL things like the size of the menus and the folder listing in
mail/news ignore the windows
 settings and just use the default ones. These should be linked to the windows
settings (ie the windows settings should be checked at Moz startup)


Lemming

Comment 1

[Michael Lowe]

UI detail dependent upon bug #3371

Comment 2

[shuang (gone)]

reassign it to pierre since I don't really know what to do. Also set ( a much
later)same milestone as the dependency bug #3371.

Comment 3

[Pierre Saslawsky]

Something doesn't sound right here. I'm not sure Ian was refering to some
settings in the Windows-OS Control Panels.

Ian's comments, as well as his original summary line ("Font sizes not
respected"), make me think that the bug was about some settings from the
AppRunner Preferences panel that are currently ignored by the application.

Ian, could you confirm? Or if I'm wrong, could you rephrase your bug report
according to the guidelines? http://www.mozilla.org/quality/bug-writing-
guidelines.html

Changing the summary line back to "Font sizes not respected" from "Widgets should
use CSS2 system fonts".

Comment 4

[Ian Tommins ('thelem')]

Sorry, I was unclear in my original report.

What I mean is that by default, UI componants such as the name of menus, text
under icons on toolbars etc are set to around size 10. This size can be modified
in the appearance tab of the windows display properties (right click desktop >
Properties).

By using XUL instead of the standard windows hooks, the size of the names on
menus etc _do not_ change according to the settings in the windows display
properties dialog. It should.

Comment 5

[Pierre Saslawsky]

Thanks Ian.

I'm keeping this bug for now. I'll reassign it to the XPToolkit team when the
CSS2 fonts are implemented (see #3371).

Comment 6

[Pierre Saslawsky]

Pushing my M15 bugs to M16

Comment 7

[Erik van der Poel]

Maybe this bug should be re-assigned to the UI team when you have fixed 3371?
I think the UI team is writing the CSS "skins" for the UI.

Comment 8

[Pierre Saslawsky]

Sherry Wang (Browser Development - IBM, Austin TX - [e-mail]) 

volunteered to do the work when I'm done with bug 3371.

Comment 9

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 10

[Pierre Saslawsky]

Reassigned to ben. The Mac implementation works. GFX on Windows (bug 33312) and 
Unix (33313) needs to be completed.

Sherry: if you want to help on Windows or Unix (the 2 bugs above) or for the 
chromes (this bug), please contact the respective assignees: rods, pavlov and 
ben. Thanks!

Comment 11

[xiaotong]

I still would like to volunteer for this bug - modifying the chromes to use CSS2 
system fonts and colors.

Sherry Wang
[e-mail]

Comment 12

[Pierre Saslawsky]

This bug is similar to bug 1021.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

non-essential skin work. shifting off. 

Comment 14

[Erik van der Poel]

Perhaps it is not essential to use CSS system fonts in the UI skins, but it does
seem quite important that the product adhere to the user's choice of font face
and size. This is an accessibility issue. Some people cannot read the default
font because it is too small, or not the right font face for them, etc. Ben, are
you saying that it is not important to consider these needs, or just that we can
achieve that goal via some means other than CSS system fonts?

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 18135 has been marked as a duplicate of this bug. ***

Comment 16

[Matthew T (active 1999-2002)]

I'm surprised this has been pushed past M20, because based on my reading of the 
chrome files, all it requires (once the dependencies have been fixed) is a quick 
blat through one CSS file (xul.css, I think it was), adding relevant `font:' 
lines to the properties for each widget. And the improvement in appearance of the 
UI would be quite substantial.

Ben, if you really don't have time for this before M20, *please* reassign it to 
[e-mail] who has volunteered to do it.

Comment 17

[xiaotong]

Ben, I will send you the changes to skin using CSS2 system fonts and colors 
shortly.

Comment 18

[Matthew T (active 1999-2002)]

*** Bug 31417 has been marked as a duplicate of this bug. ***

Comment 19

[Ben Goodger (use ben at mozilla dot org for email)]

Classic has been using system fonts on windows since the start. 
Unfortunately there are problems. Supposedly the system font support 
doesn't understand bitmap fonts like MS Sans Serif on Windows 95/98, 
so all fonts appear to be Times New Roman. Windows 2000 supplies MS 
Sans Serif in a different format however and it is understood and used by 
Mozilla correctly. cc'ing Michael Lowe, in case he has any ideas (?) 

Pierre informs me that system font support works on mac, but I've never 
seen it myself (running OS8.6 on my G3-450 all system font CSS is 
ignored.. now I *know* that it is possible on 8.6 because IE5 does it ;) I 
keep meaning to ask Pierre about this... 

Comment 20

[Ian Tommins ('thelem')]

This bug really applies to the modern skin, since it will be the default. If 
Netscape are going to include other skins then they should also use system fonts 
(and the same when fonts are unspecified).

I have changed the summary to reflect this, change it back if you disagree.

Comment 21

[Braden]

Ben: Just FYI, system fonts don't appear to be working at all under Linux. In
fact, in a build I compiled last night, changing the document font from "sans
serif" to "serif" in the prefs changed the UI font. (Maybe that's a separate
bug?)

Comment 22

[Pierre Saslawsky]

*** Bug 44806 has been marked as a duplicate of this bug. ***

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

hm. Closing this bug as WONTFIX as I don't believe there was any intent to use 
system * in Modern. If you want a skin that tries to match your system settings, 
use classic ;) 

Comment 24

[Akkana Peck]

This would handily solve the problems in bug 5236, and as Erik pointed out, it's
an accessibility issue, especially since the fonts in Modern are hardwired to be
so small, and since a patch has apparently already been supplied.

Sherry, do you still have your patch?  Could you attach it to this bug and add
the keyword "patch"?

Will reassign to Don since Ben doesn't want it.

Braden: I reopened bug 33313 since I agree with you that gtk system fonts don't
seem to be working (at least, Classic skin comes up with miniscule fonts whereas
normal gtk apps come up with nice readable fonts). 

Comment 25

[Akkana Peck]

Someone suggested reassigning this to don, but I'll wait and let Ben comment on
it.

Comment 26

[Chris McAfee]

adding "loose" dependency to 5236.

Comment 27

[Akkana Peck]

Turns out Pav's bug 33313 is a dup (but not marked as such) of 48907; adding
that dependency as well.

Comment 28

[Ben Goodger (use ben at mozilla dot org for email)]

To Paul, who will probably mark as WONTFIX again...

Comment 29

[Matthew T (active 1999-2002)]

*** Bug 55441 has been marked as a duplicate of this bug. ***

Comment 30

[Alec Flett]

*** Bug 55463 has been marked as a duplicate of this bug. ***

Comment 31

[Alec Flett]

adding dependancy - we can't do this till the modern skin is totally scalable.

Comment 32

[Braden]

Changing summary slightly:

 * Remove "Netscape". They might feel differently about this, and they can track
this issue in the Netscape bug database if they need a separate resolution.

 * Changing "all skins" to "Modern2". That seems to be what this bug is tracking
at this point, and the notion that all skins that ship with Mozilla *must* use
system fonts seems a bit heavy-handed.

Comment 33

[Erik van der Poel]

I don't understand. Is there such a thing as "Modern2"? Or are you saying that
we should create a new theme called Modern2, and make it use system fonts?

Comment 34

[Erik van der Poel]

Alec, I found the place where the font-size is being set to 8.5pt (it's set to
3mm, which is the same):

  mozilla/xpfe/global/resources/locale/en-US/intl.css

In a commercial debug build on Linux, it's installed in:

  ns/dist/bin/chrome/en-US/locale/en-US/global/intl.css

Comment 35

[Braden]

For some reason I was under the impression that the Modern skin was called
Modern2.

Comment 36

[Alec Flett]

erik: gack! We should see how things look without that... but I'll bet we still 
need to fix this.

Comment 37

[Alec Flett]

nominate for rtm

Comment 38

[Phil Peterson]

jar and/or hamerly to check this out on akkana's machine, since alecf sez the
bug can be demonstrated there.

Comment 39

[hangas]

This is my favorite bug.  I really want this one fixed, it is huge for everyone 
that wants to change their system fonts.  If we don't get this in rtm we will 
checkin a fix on the trunk for Modern as soon we can.  We may even create a 
version of Modern with this fix to be made available for those folks running N6.

Comment 40

[hangas]

sending to hewitt

Comment 41

[hangas]

Sadly marking rtm-

Comment 42

[Matthew T (active 1999-2002)]

--> Themes. (Out of my component! Shoo! Shoo!)

Comment 43

[Joe Hewitt (gone)]

Attachment: big long patch

Comment 44

[Ben Goodger (use ben at mozilla dot org for email)]

changes look OK. andreww has provided review, 

a=[e-mail]

Comment 45

[Joe Hewitt (gone)]

Fixed.  System fonts are now honored -- all widgets that contain text can now
stretch in both dimensions.

Comment 46

[Mitch Keller]

Argh! I don't like this fix! On XFree86 3.3.6 under Linux with 100 dpi fonts,
the widgets become HUGE! Even at 75 dpi they're bigger than they were. I thought
that modern was beautiful before this, but now I'm just frustrated. Can anybody
tell me how to put this back to the way that it was?????

Comment 47

[Joe Hewitt (gone)]

This bug _IS FIXED_.  The problem with large Linux fonts is a separate bug.

For those of you Linux users who can't stand the enormity of the new fonts, and 
don't want to wait for it to be fixed, you can put this in your userChrome.css 
file to restore sanity:

button, menubutton, menulist, menu, menuitem, tab, .button-toolbar, window {
  font-size: 12px !important;
}

You may want to tweak that font size to fit your preference.

Comment 48

[(not reading, please use [e-mail] instead)]

actually, things look really good now.  especially the mailnews thread pane.

thanks for the fix, hewitt.

Comment 49

[ckritzer (gone)]

Why do I have this?  This should never have been assigned to me...

qacontact->pmac

Comment 50

[Patty Mac]

Marking verified (2001-01-24-09-Mtrunk).