browser.urlbar.autoFill needs adding to prefs list

RESOLVED FIXED in Firefox 2 alpha2

Status

()

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: pkasting, Assigned: pkasting)

Tracking

({fixed1.8.1})

2.0 Branch
Firefox 2 alpha2
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
Bug 203756 added the browser.urlbar.autoFill pref for auto-filling the best match in the address bar.  However, the pref was never added to firefox.js, so it doesn't show up in about:config and must be newly added.

This bug seeks to add the pref, defaulted to off so as not to change behavior.  Bug 186136 has more discussion about broader issues such as fixing autoFill to suck less.  All I'm trying to do here is make the pref visible.
(Assignee)

Comment 1

13 years ago
Keyed in the wrong bug number in the blocks list.
Blocks: 186136
No longer blocks: 203756
(Assignee)

Comment 2

13 years ago
Created attachment 219196 [details] [diff] [review]
Fix for firefox.js

Add the pref to firefox.js.

Since this is part of browser, it doesn't belong in all.js.
Attachment #219196 - Flags: review?
(Assignee)

Comment 3

13 years ago
Comment on attachment 219196 [details] [diff] [review]
Fix for firefox.js

Tried to set this to get review from Ben Goodger, didn't seem to work.  Trying again.
Attachment #219196 - Flags: review? → review?(bugs)
Comment on attachment 219196 [details] [diff] [review]
Fix for firefox.js

As a general note, there is no requirement to ensure prefs show up in about:config, but this one is not rare, though its far from commonly sought.

The dependency isn't necessary, but meh.
Attachment #219196 - Flags: review?(bugs) → review+
Peter: do you want me to check this in?
(Assignee)

Comment 6

13 years ago
Yes please, since I don't have CVS privileges.

It would be nice to get this onto the 1.8 branch as well.
mozilla/browser/app/profile/firefox.js 	1.106
Status: NEW → RESOLVED
Last Resolved: 13 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 2 alpha2
Version: unspecified → 2.0 Branch
Attachment #219196 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #219196 - Flags: approval-branch-1.8.1?(mconnor)
Checked in on the 1.8 branch too.
mozilla/browser/app/profile/firefox.js 	1.71.2.29
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.