336211 - RealPlayer 10.1 crashes Camino every time (trunk and branches) with stale pluginreg.dat

Status: VERIFIED FIXED

(Plugins Graveyard :: RealPlayer (Real), defect)

Description

[Chris Lawson (gone)]

Fresh profile, RealPlayer 10.1, Camino 1.0.1rc.

Crash is 100% reproducible about 10 seconds after browsing to nfl.com. Crash log looks the same every time. Log coming up.

See also bug 336061.

Comment 1

[Chris Lawson (gone)]

Attachment: relevant portion of crash log

Some day, I will find the person who invented LaunchServices, and I will extract his toenails with a wooden spoon.

Comment 2

[Stuart Morgan]

Or you could blame Real. Crashing in CFString functions is usually a pretty good sign that the client of the framework is passing in bad data.

Comment 3

[Chris Lawson (gone)]

Yes, as I said on the forum, yay for QA testing before a product release. Has anyone at Real ever even *heard* of Camino?

cl

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Simon, do we know anyone at Real to bug about this?

This almost seems like it will quickly be bad enough that we need to add *another* late relnote for 1.0.1 :/  This crash is already showing up on the forum with people wondering why upgrading RP suddenly causes Camino 1.0.1rc to crash.

Comment 5

[Samuel Sidler (old account; do not CC)]

We can't hold 1.0.1 any longer. I suggest we relnote this on the website and advertise it a bit louder than normal.

Comment 6

[Simon Fraser [no longer active]]

Isn't this a dup of 336061?

Comment 7

[Chris Lawson (gone)]

(In reply to comment #6)
> Isn't this a dup of 336061?

No; that bug is trunk-only and has been happening for a while, even with RealPlayer 10.0.0.

This bug is trunk and all branches, and only happens with RealPlayer 10.1.

cl

Comment 8

[froodian (Ian Leue)]

*** Bug 336222 has been marked as a duplicate of this bug. ***

Comment 9

[Eiichi]

Just for reference;

I try to copy "/RealPlayer.app/Contents/MacOS/RealPlayer Plugin.plugin" to "/Library/Internet Plug-Ins", so Camino doesn't crash but no embedded clip.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Simon talked to some folks at Real, and they're going to look in to this.

Comment 11

[Joel Craig]

Just confirming on latest trunk nightly, running on Intel. Crash log posted in case it differs any from Chris'.

http://home.comcast.net/~joelcraig23/caminorealcrash.txt

Comment 12

[Bob Clark]

I'm still looking into this, but I want to make my incremental findings available ASAP in case it jogs someone's memory or rings a bell or insert your favorite metaphor here: ______

We qualified RealPlayer's browser plugin on Firefox 1.5.0.2 and spot-checked Camino. I just noticed that Firefox 1.5.0.3 crashes in apparently the same way, so some tweak between FF 1.5.0.2 and FF 1.5.0.3 exposed the crash. Is Camino 1.0.1 using the same gecko engine as FF 1.5.0.3? What about Camino 1.0? (And does Camino 1.0 exhibit the same crash with RP 10.1?)

The code that it's crashing in is trying to find the RealPlayer Plugin's loaded CFBundle. It's a heisenbug and I'm having trouble peeking in with low enough impact that it still crashes. :-/

Comment 13

[Samuel Sidler (old account; do not CC)]

(In reply to comment #12)
> We qualified RealPlayer's browser plugin on Firefox 1.5.0.2 and spot-checked
> Camino. I just noticed that Firefox 1.5.0.3 crashes in apparently the same way,
> so some tweak between FF 1.5.0.2 and FF 1.5.0.3 exposed the crash. Is Camino
> 1.0.1 using the same gecko engine as FF 1.5.0.3? What about Camino 1.0? (And
> does Camino 1.0 exhibit the same crash with RP 10.1?)

Camino 1.0.1 uses the same code Firefox 1.5.0.3 uses. However, I can't get Firefox 1.5.0.3 to crash using Real Player 10.1.0 (400). It does, however, crash with Camino 1.0.

It looks like this crash is specific to Camino, affecting all recent versions of it (I haven't checked older versions like 0.8.x).

Comment 14

[Bob Clark]

I take back part of what I implied. I have seen it crash in FF1502. It seems that once the plugin information has been added to pluginreg.dat it works perfectly from then on.

Comment 15

[Samuel Sidler (old account; do not CC)]

(In reply to comment #14)
> I take back part of what I implied. I have seen it crash in FF1502. It seems
> that once the plugin information has been added to pluginreg.dat it works
> perfectly from then on.

You're right.

I can confirm the same is true for Fx1.5.0.3 and Camino 1.0.1. If I remove pluginreg.dat from my profile, open Camino, surf to nfl.com, crash, reopen Camino, surf to nfl.com then everything works perfect and I no longer see a crash.

Comment 16

[Samuel Sidler (old account; do not CC)]

Bob, Is there a bug filed here at mozilla.org for the pluginreg.dat issue? Is that something that needs to be fixed on our end or yours (or both)?

I'd like to send this bug to Core since it affects Firefox in the same way, but if there's a bug already file, I'll just dupe it there.

Also, is there anything that can be done in the interim to prevent this crash from either of our ends? We're looking at doing a 1.0.2 shortly to fix a regression and if there's something quick and dirty we can do to stop this crash, I'm sure we'll want to. :)

Comment 17

[Bob Clark]

(In reply to comment #16)
> Bob, Is there a bug filed here at mozilla.org for the pluginreg.dat issue?

No, at least I haven't filed a bug.

> Is
> that something that needs to be fixed on our end or yours (or both)?

It looks like it's our (my) issue from what I've seen.

> I'd like to send this bug to Core since it affects Firefox in the same way, but
> if there's a bug already file, I'll just dupe it there.
> 
> Also, is there anything that can be done in the interim to prevent this crash
> from either of our ends? We're looking at doing a 1.0.2 shortly to fix a
> regression and if there's something quick and dirty we can do to stop this
> crash, I'm sure we'll want to. :)

Here's the snippet of code, with some of my snide comments included, that's around the crash. This is isn't in our publicly-viewable code, so shhhh don't tell anyone.


	gPluginBundleRef = CFBundleGetBundleWithIdentifier( CFSTR( "com.RealNetworks.RealPlayerPlugin" ) );
	
        if (!gPluginBundleRef)
        {
            // oh for the love of pete. I can't find a "get the bundle whose code is executing at this
            // very instant!" API. That makes me grumpy.
            //
            // Something else that makes me grumpy is that when I'm running under Firefox, the bundle
            // ref is NULL -- that is to say, CFBundleGetBundleWithIdentifier FAILED. But in the list
            // of bundles, one of them does report a bundle ID of com.RealNetworks.RealPlayerPlugin.
            // Harumph!
            
            CFArrayRef bundleList = CFBundleGetAllBundles();
            CFIndex numberOfBundles = CFArrayGetCount(bundleList);
            CFIndex i;
            for (i = 0; i < numberOfBundles; i++)
            {
                CFBundleRef curBundle = (CFBundleRef)CFArrayGetValueAtIndex(bundleList, i);
                CFStringRef curBundleID = CFBundleGetIdentifier(curBundle);

The crash happens when one of the CFBundleGetIdentifier calls returns NULL and I don't properly handle the NULL. I suspect that there might be a bundle that recently got added in an OS X update or something (with no bundle identifier!), because we didn't see this problem until, well, now.

The biggest conundrum for me is why the original CFBundleGetBundleWithIdentifier fails. It works with Safari and the fallthough code was trying to patch things up when we saw that running under Mozilla it returned NULL.

The plugin API I used was based on Apple's sample code on your hard drive at /Developer/Examples/WebKit/NetscapeMoviePlugin. I don't know whether CFBundleGetBundleWithIdentifier fails in that plugin too.

Comment 18

[K. Sheppard]

This bug happened as a result of changing to Real Player 10.1.0 using Camino 1.0 and 1.0.1. This  bug does not affect Safari 2.0.3.

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Ian (10.4.6) and I (10.3.9) both tried Sam's work-around (comment 15) with Camino 1.0.1 and were unable to get it to work, no matter what we did to pluginreg.dat or our profiles :-( 

Comment 20

[VTMarik]

This same bug also affects Firefox 1.5.0.x on Windows XP. It crashes without so much as a warning.

Comment 21

[Eiichi]

Just for reference;

Until this problem is fixed, we can now download and reinstall
RealPlayer 10.0.0 (352) from:
http://forms.real.com/real/player/blackjack.html

Comment 22

[Bob Clark]

RealPlayer 10.1.0 build 412 was just released. (Build 400 was the one with the problem.) This issue should be fixed for Firefox and Camino.

Comment 23

[Nick Kreeger]

(In reply to comment #22)
> RealPlayer 10.1.0 build 412 was just released. (Build 400 was the one with the
> problem.) This issue should be fixed for Firefox and Camino.
> 

I updated to 412 and it worked just fine for me. Suggesting to close?

Comment 24

[Samuel Sidler (old account; do not CC)]

Resolving this bug as INVALID since it wasn't a fix on our end.

Bob, if you're in Seattle, shoot me a private email and drinks are on me. :)

Comment 25

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 337939 has been marked as a duplicate of this bug. ***

Comment 26

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 338009 has been marked as a duplicate of this bug. ***

Comment 27

[George]

*** Bug 341938 has been marked as a duplicate of this bug. ***

Comment 28

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 364170 has been marked as a duplicate of this bug. ***