336061 - bogus locale in Camino UA string causes embedded RealPlayer to crash trunk builds

Status: RESOLVED FIXED

(Camino Graveyard :: Plug-ins, defect)

Description

[davedit]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060413 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060413 Camino/1.0+

In recent trunk nightlies of Camino, sites with imbedded RealPlayer will cause Camino to crash.

As far as I can tell, this problem started in the 4/19 trunk nightly, and it still exists in the 4/30 trunk nightly. Branch was not a problem. So somewhere between 18-Apr-2006 06:33 and 19-Apr-2006 06:48, a change was made that started causing this.

Reproducible: Always

Steps to Reproduce:
1. Go to a page that has imbedded RealPlayer

Actual Results:  
Camino crashes

Expected Results:  
Camino should load RealPlayer without crashing

Comment 1

[davedit]

Attachment: Crash log

Crash log for the problem

Comment 2

[Chris Lawson (gone)]

Does it happen in corresponding official nightlies of Firefox?

cl

Comment 3

[davedit]

No, the Firefox trunk nightly, posted 19-Apr-2006 12:50, does not exhibit the same problem.

Comment 4

[Samuel Sidler (old account; do not CC)]

I can confirm the crash and regression range on the trunk only (between 2006-04-18 and 2006-04-19). TB18150530Z (from 04-19).

This doesn't occur on either branch or in today's (4-30) Minefield. It appears to be Camino-only... :-/

Comment 5

[Samuel Sidler (old account; do not CC)]

Regression range: http://tinyurl.com/hghg8

Comment 6

[Samuel Sidler (old account; do not CC)]

And I meant TB18150350Z above. :(

Comment 7

[Samuel Sidler (old account; do not CC)]

Since this doesn't happen in Minefield, my first suspect is Camino and Cocoa changes. The Camino changes that day are limited to an adblocking change and a makefile.in change, which also occurred on the branches.

The only Cocoa change in that range happened in bug 334537. So... CCing Mark based on the above (though really, that wouldn't make much sense to me either).

Comment 8

[Mark Mentovai]

No way it was 334567.

Has anyone tried a cocoafox?

Comment 9

[Håkan Waara]

(In reply to comment #8)
> No way it was 334567.
> 
> Has anyone tried a cocoafox?

I'm building right now... if I fall asleep before it finishes, I'll try reproducing it tomorrow.

Comment 10

[Håkan Waara]

I don't know if we're dealing with a broken plugin, broken site, broken Gecko code, or broken Camino code.

I'm using Cocoafox from today's trunk code, and a RealPlayer plugin from december. Here's my test:

* I went to NFL.com and the box under "Audio and video" is just black. No content is loaded. Ctrl-clicking it gives a context menu with "Play in Real player", "Volume up" and some other RealPlayer plugin things.

* But I'm not sure if the plugin is really loaded, or if it works... 

* Trying it in Firefox 1.5 gives some really crazy behavior! For example the video box ends up drawn in the top-left corner of the window, and only semi-works.

Does anyone know of any other testcase site, so we can rule out that NFL is broken? (I can also try the latest real player plugin tomorrow.)

Comment 11

[davedit]

I checked the problem on multiple sites. Another testcase could be IFILM. Just view any video there and choose RealPlayer in the video preferences and it will crash. Also crashed when MySpace profiles had imbedded RealPlayer videos.

Comment 12

[Eiichi]

After installing RealPlayer 10.1.0, latest branch build (20060501 Camino/1.0+) also crashes.

Comment 13

[Eiichi]

Going to http://www.nfl.com, Camino 1.0.1 RC (20060427 Camino/1.0.1) crashes, too.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I don't crash on nfl.com with Camino 1.0.1RC, the RealPlayer Plugin that comes with RealPlayer 10.0.0 (v352) (c'mon Real, give the plugin a version number!), and Mac OS X 10.3.9.  I don't crash with a recent personal trunk build, either; I don't have a recent official tunk handy, though.

Can everyone clarify their OS versions and RealPlayer (plugin) versions?  Also, have the crashing folks tried fresh profiles just to rule that out?

Comment 15

[Chris Lawson (gone)]

Attachment: Crash log 2 (bug 336211)

Crash log with RealPlayer 10.1, Mac OS 10.4.6, Camino 1.0.1rc.

It's entirely possible this is at least partly a RealPlayer problem.

Comment 16

[Chris Lawson (gone)]

Comment 13 and comment 15 filed as bug 336211.

cl

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

OK, I happened to have the 4-18 and 4-19 trunk nightlies.  I can now confirm the old (10.0.0 v352) RealPlayer's plugin does not crash the 4-18 Cm trunk but *does* crash the 4-19 Cm trunk on 10.3.9, same top-of-stack as davedit.

(don't know why my trunk debug doesn't crash...)

Still Real crashing it looks like, but something changed that day on our end to trigger it.

Ooh, I know why I had those builds and why it crashes the one day and not the next (and why my debug build does not crash, too).  It's bug 335026 and the SeaMonkey changes that caused it.  If you manually set your general.useragent.locale to something valid, no more crashing.  So we need bug 331576 fixed to fix this...mento?

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 336523 has been marked as a duplicate of this bug. ***

Comment 19

[Mark Knopper]

*** Bug 355981 has been marked as a duplicate of this bug. ***

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 355741 has been marked as a duplicate of this bug. ***

Comment 21

[Kurt Weinschenker]

Attachment: Crashlog from Camino trunk build 2006101402

Not quite sure if my crashlog from a current Camino trunk build (2006101402 (v1.2+)) running under Mac OS 10.3.9 is representative of this, or not.  Posting crashlog here pending a bit of triage.

Comment 22

[Chris Lawson (gone)]

(In reply to comment #21)
> Created an attachment (id=242592) [edit]
> Crashlog from Camino trunk build 2006101402
> 
> Not quite sure if my crashlog from a current Camino trunk build (2006101402
> (v1.2+)) running under Mac OS 10.3.9 is representative of this, or not.

Looks like it. To be certain, go to about:config and set

general.useragent.locale

to "en-US" (or something similarly valid). The crashing will stop if what you're seeing is indeed this bug. From the log, it sure looks like it.

cl

Comment 23

[Håkan Waara]

Do we have a contact at Real™?  My quick analysis of the stack is that the realplayer plugin is trying to operate on an already-freed pointer, in the invalid locale case.

Comment 24

[Chris Lawson (gone)]

Bob, can you take a look at this and see if comment 23 is accurate?

cl

Comment 25

[Kurt Weinschenker]

Did a bit more testing with trunk builds over the past couple weeks, including 2006111101 (v1.2+).  Chris's suggestion in comment #22 works around the problem.  We should at least consider putting this workaround in the release notes for Camino, given that Camino trunk builds will crash on the CBSnews.com website, which I would suggest is a fairly high-profile one.

Comment 26

[froodian (Ian Leue)]

Fixed by bug 331576.

Comment 27

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Trunk-only bug ;)