336244 - Clean up/remove extensions/xmlextras/base

Status: RESOLVED FIXED

(Core :: XML, defect, P4)

Description

[Frank Wein [:mcsmurf]]

It looks like extensions/xmlextras/base can be cvs removed (since Bug 324865 was fixed), it's not used anymore. Also the references to the old Makefiles in allmakefiles.sh should be removed.

Comment 1

[Peter Van der Beken [:peterv]]

*** Bug 336821 has been marked as a duplicate of this bug. ***

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 221306 [details] [diff] [review]
v1

r+sr=me

Comment 4

[Peter Van der Beken [:peterv]]

Looking for some help removing xmlextras.xpt from mozilla/embedding/tests/cocoaEmbed/CocoaEmbed.pbproj/project.pbxproj. I don't have the right version of XCode.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Removes xmlextras.xpt from project and converts it to Xcode 1.x

Håkan asked me to do this since I've been kicking the Camino project file for checkins lately.

Note, however, that the CocoaEmbed.pbproj file was still a 10.2 Project Builder file, so in addition to removing the file, this patch also upgrades it to Xcode 1.x format (10.3.9/Xcode 1.5 is the minimum requirement for the trunk now, anyway).  Untested.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hrm.  I should have landed this on the 1.8 branch when I landed bug 324865, shouldn't I?

Comment 7

[Steffen Wilberg]

(In reply to comment #6)
> Hrm.  I should have landed this on the 1.8 branch when I landed bug 324865,
> shouldn't I?
Is it too late to do so? Firefox currently has xmlextras.xpt listed in both packages-static and removed-files.in on the 1.8 branch now...
Compare:
http://mxr.mozilla.org/mozilla1.8/search?string=xmlextras.xpt
http://mxr.mozilla.org/mozilla/search?string=xmlextras.xpt
Also see bug 378533 comment 0.

Comment 8

[Matthew (lilmatt) Willis]

Comment on attachment 221306 [details] [diff] [review]
v1

I'd like to see this on the 1.8 branch.  It's valid cleanup, cuts down on error spew in tinderbox logs and stats, and it would reduce the number of merges I have to keep track of.

-> a1817?

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 221306 [details] [diff] [review]
v1

approved for 1.8.1.7, a=dveditz for release-drivers

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 221306 [details] [diff] [review]
v1

Removing month-old approval, we're hitting the release code-freeze.

Comment 11

[Matthew (lilmatt) Willis]

Attachment: unbitrotten version of attachment 223263, as checked in on MOZILLA_1_8_BRANCH

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 221306 [details] [diff] [review]
v1

Check-in buddy found before the actual freeze, this is OK to land.

Comment 13

[Tony Chung [:tchung]]

Can we get a testcase for this to verify?  if this is code cleanup only, can the reporter please verify it and mark the keyword to verified1.8.1.8?   Thanks.