Clean up/remove extensions/xmlextras/base

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
XML
P4
minor
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: mcsmurf, Assigned: peterv)

Tracking

({fixed1.8.1.8})

Trunk
mozilla1.9alpha1
fixed1.8.1.8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [need testcase])

Attachments

(3 attachments)

(Reporter)

Description

11 years ago
It looks like extensions/xmlextras/base can be cvs removed (since Bug 324865 was fixed), it's not used anymore. Also the references to the old Makefiles in allmakefiles.sh should be removed.
(Assignee)

Updated

11 years ago
Assignee: xml → peterv
Priority: -- → P4
Target Milestone: --- → mozilla1.9alpha
(Assignee)

Comment 1

11 years ago
*** Bug 336821 has been marked as a duplicate of this bug. ***
(Assignee)

Updated

11 years ago
Depends on: 324865
(Assignee)

Comment 2

11 years ago
Created attachment 221306 [details] [diff] [review]
v1
Attachment #221306 - Flags: superreview?(bugmail)
Attachment #221306 - Flags: review?(bugmail)
Comment on attachment 221306 [details] [diff] [review]
v1

r+sr=me
Attachment #221306 - Flags: superreview?(bugmail)
Attachment #221306 - Flags: superreview+
Attachment #221306 - Flags: review?(bugmail)
Attachment #221306 - Flags: review+
(Assignee)

Comment 4

11 years ago
Looking for some help removing xmlextras.xpt from mozilla/embedding/tests/cocoaEmbed/CocoaEmbed.pbproj/project.pbxproj. I don't have the right version of XCode.
Status: NEW → ASSIGNED
Created attachment 223263 [details] [diff] [review]
Removes xmlextras.xpt from project and converts it to Xcode 1.x

Håkan asked me to do this since I've been kicking the Camino project file for checkins lately.

Note, however, that the CocoaEmbed.pbproj file was still a 10.2 Project Builder file, so in addition to removing the file, this patch also upgrades it to Xcode 1.x format (10.3.9/Xcode 1.5 is the minimum requirement for the trunk now, anyway).  Untested.
Hrm.  I should have landed this on the 1.8 branch when I landed bug 324865, shouldn't I?
Depends on: 378533

Comment 7

10 years ago
(In reply to comment #6)
> Hrm.  I should have landed this on the 1.8 branch when I landed bug 324865,
> shouldn't I?
Is it too late to do so? Firefox currently has xmlextras.xpt listed in both packages-static and removed-files.in on the 1.8 branch now...
Compare:
http://mxr.mozilla.org/mozilla1.8/search?string=xmlextras.xpt
http://mxr.mozilla.org/mozilla/search?string=xmlextras.xpt
Also see bug 378533 comment 0.
Comment on attachment 221306 [details] [diff] [review]
v1

I'd like to see this on the 1.8 branch.  It's valid cleanup, cuts down on error spew in tinderbox logs and stats, and it would reduce the number of merges I have to keep track of.

-> a1817?
Attachment #221306 - Flags: approval1.8.1.7?
Comment on attachment 221306 [details] [diff] [review]
v1

approved for 1.8.1.7, a=dveditz for release-drivers
Attachment #221306 - Flags: approval1.8.1.7? → approval1.8.1.7+
Comment on attachment 221306 [details] [diff] [review]
v1

Removing month-old approval, we're hitting the release code-freeze.
Attachment #221306 - Flags: approval1.8.1.8+ → approval1.8.1.8-
Created attachment 283459 [details] [diff] [review]
unbitrotten version of attachment 223263 [details] [diff] [review], as checked in on MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.8
Resolution: --- → FIXED
Comment on attachment 221306 [details] [diff] [review]
v1

Check-in buddy found before the actual freeze, this is OK to land.
Attachment #221306 - Flags: approval1.8.1.8- → approval1.8.1.8+

Comment 13

10 years ago
Can we get a testcase for this to verify?  if this is code cleanup only, can the reporter please verify it and mark the keyword to verified1.8.1.8?   Thanks.
Whiteboard: [need testcase]
You need to log in before you can comment on or make changes to this bug.