378533 - Remove xmlextras.xpt

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

philor: bsmedberg: am I thinking right, that Thunderbird shouldn't be trying to package xmlextras.xpt because it doesn't exist, it's in libxul instead?
bsmedberg: philor: no, you are not thinking correctly... I think that xmlextras.xpt disappeared
philor: bsmedberg: right, better phrased: should Tb just remove it from packages-static, or should it also add it to removed-files.in?
bsmedberg: philor: should almost certainly add it to removed-files, so we don't have conflicting interface defs

And since Firefox is now removing it on 1.8.1, we should probably follow suit there, too, just in case.

(For reference: bug 324865 moved the parts we actually really want, bug 336244 made xmlextras.xpt disappear, bug 377099 added it to Fx's removed-files (though, oddly, Fx 2.0.0.x still tries to package it))

Comment 1

[Scott MacGregor]

Comment on attachment 262574 [details] [diff] [review]
Fix v.1

w00t.

Comment 2

[Phil Ringnalda (:philor)]

mail/installer/windows/packages-static 1.47
mail/config/basemail-unix 1.42
mail/config/basemail-os2 1.18
mail/installer/removed-files.in 1.27

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Branchable

Same patch, but the context messes with the trunk patch applying nicely.

Risk of removing it should be much lower than the risk of keeping it: it hasn't been built since last June, so anything relying on it is broken, and with Firefox removing it, we're at risk of someone deciding that an interface has to change.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 263086 [details] [diff] [review]
Branchable

approved for 1.8.1.4, a=dveditz for release-drivers if you  land today

Comment 5

[Phil Ringnalda (:philor)]

Mmm, I hope "today" ends at midnight, not some time before I get home.

Comment 6

[Phil Ringnalda (:philor)]

Whew.

mail/installer/windows/packages-static 1.8.2.27
mail/config/basemail-unix 1.29.2.5
mail/config/basemail-os2 1.12.2.2
mail/installer/removed-files.in 1.1.2.20

Comment 7

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.4 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4) Gecko/20070604 Thunderbird/2.0.0.4 ID:2007060411, xmlextras.xpt is removed in this build.