Closed Bug 336439 Opened 17 years ago Closed 16 years ago
Infobar not tall enough
[putting in General because I have no idea where this should go; triage help wanted] BUILD: MOZ_CO_DATE="Tue May 2 14:01:07 CDT 2006" Linux Firefox trunk build STEPS TO REPRODUCE: 1) Make sure mozdev.org is no in the XPI whitelist 2) Load http://adblockplus.mozdev.org/installation.html 3) Click the "Install Adblock Plus 0.7" link. 4) Watch the yellow infobar appear EXPECTED RESULTS: infobar is tall enough for its text. ACTUAL RESULTS: infobar text is cut off at the bottom. Screenshot coming up.
I'd really like to see this fixed for the Gecko alpha...
*** Bug 335215 has been marked as a duplicate of this bug. ***
I think Rob Strong's Toolkit: XUL Widgets for bug 335215 was a reasonable choice. I can't quite manage to reproduce this, since Ubuntu doesn't ship with a Gnome theme that has short enough buttons: it looks like the bar gets its height from the button height, so the worst I can get is part of the descenders on a second line cut off. However, cross-platform, with a small enough window to wrap to three lines the bottom one gets cut off.
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
I guess toolkit's right if this thing lives in the tabbrowser binding. Not sure where it's defined.
Oh, sorry: it's probably a regression from bug 268590, so the patch there will tell you where it lives.
Assignee: nobody → enndeakin
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: --- → mozilla1.8.1beta1
Checked into trunk
should this be marked fixed now?
Neil, can you land this on the branch ASAP?
Fixed for 1.9 and 1.8
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Sparky is showing a clear 50ms increase in Ts due to this patch. http://build-graphs.mozilla.org/graph/query.cgi?testname=startup&units=ms&tbox=sparky.office.mozilla.org_MOZILLA_1_8_BRANCH&autoscale=1&days=7&avg=1&showpoint=2006:06:09:09:08:08,2543
Whiteboard: [needs branch landing]
You need to log in before you can comment on or make changes to this bug.