336755 - Viewing website triggers RSS-style file handler

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Oakwine]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060505 BonEcho/2.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060505 BonEcho/2.0a1

A website that I have visited in the past could not be visited with today's build.  Instead of displaying the website, I see an 'opening' dialog asking what I would like to do with a filetype of application/vnd.mozilla.maybe.feed . Based on the filetype claimed, it appears to be related to the checkin of Choose Feed Reader.

Reproducible: Always

Steps to Reproduce:
1. Visit extensions.jedbrown.net

Actual Results:  
Dialog box is shown asking what to do with a filetype application/vnd.mozilla.maybe.feed.
(see image at http://img.photobucket.com/albums/v334/oakwine/Feederror.png )

Expected Results:  
Website displayed normally.

I was able to visit the website with yesterday's build (2006050503).

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Looks like the RDF in the HTML comment is tripping it up.

Comment 2

[Robert Sayre]

Attachment: source code of the page

Comment 3

[John Hanna]

FYI the site referred to worked fine with build Mozilla/5.0 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060504 BonEcho/2.0a1 ID:2006050502. 

Comment 4

[Phil Ringnalda (:philor)]

The last patch in bug 333751 switched the RSS 1.0 sniffing from ANDing together the three conditions to ORing them, so anything with the string "<rdf:RDF" in the first 512 bytes is a maybe.feed

Comment 5

[Robert Sayre]

Response Headers:

HTTP/1.x 302 OK
Date: Fri, 05 May 2006 16:45:01 GMT
Server: Apache Web Server
X-Powered-By: PHP/4.4.1
Location: http://jedbrown.net/1.0/mozilla/extensions/
Keep-Alive: timeout=5, max=150
Connection: Keep-Alive
Transfer-Encoding: chunked
Content-Type: text/html
----------------------------------------------------------

HTTP/1.x 200 OK
Date: Fri, 05 May 2006 16:45:01 GMT
Server: Apache Web Server
X-Powered-By: PHP/4.4.1
Keep-Alive: timeout=5, max=150
Connection: Keep-Alive
Transfer-Encoding: chunked
Content-Type: text/html

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Forgot to add the new feed files to the packager lists!

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

fixed-1.8-branch, fixed-on-trunk

Comment 8

[Phil Ringnalda (:philor)]

I'm confused, how does that packaging change affect the fact that now in http://lxr.mozilla.org/seamonkey/source/browser/components/feeds/src/nsFeedSniffer.cpp#194 if we see "<rdf:RDF" we set isFeed to true, and we only look for the namespace URIs |if (!isFeed)|?

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: add saxparser.xpt too

Comment 10

[Phil Ringnalda (:philor)]

With Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a1) Gecko/20060505 Firefox/3.0a1 ID:2006050518 (checkout finish: Fri May 5 18:36:18 PDT 2006) I get an "Error Processing Feed," which is arguably slightly better, but it seems like maybe the point of this bug was missed:

It's an HTML page, which happens to include the characters "<rdf:RDF" in the first 512 bytes, and nsFeedSniffer::GetMIMETypeFromContent is now *broken*, it treats anything with any one of the three triggers for RSS 1.0 as being a potential feed, instead of requiring that all three be present.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

revert earlier change that I made on darin's suggestion to not reinit end_iter, looks like it is moved after all.

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Now fixed-on-trunk, fixed-1.8-branch. (reverted earlier code)