333751 - Land Initial Content Sniffer/Stream Converter for in-page Feed Preview

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Need to land patch for in-page feed preview using content sniffing/stream converter so that incremental code review can commence. Will be disabled by default, enable-able using --enable-feeds. We need to get testing on this for PLT regressions.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch (testing configure changes now)

Comment 2

[Phil Ringnalda (:philor)]

>+  if (FindInReadable(NS_LITERAL_CSTRING("xmlns=\"http://www.w3.org/2005/atom\""), start_iter, end_iter)) {

If you want to test actually finding any Atom 1.0, I think that needs to either be CaseInsensitiveFindInReadable or /Atom.

Comment 3

[Pawel Chmielowski]

>--- configure.in	11 Apr 2006 18:59:11 -0000	1.1651
>+++ configure.in	12 Apr 2006 18:52:14 -0000
>@@ -5729,16 +5730,27 @@ MOZ_ARG_ENABLE_BOOL(places,
>     MOZ_PLACES= )
> if test -n "$MOZ_PLACES"; then
>     AC_DEFINE(MOZ_PLACES)
>     MOZ_MORK=
>     MOZ_MORKREADER=1
> fi
> 
> dnl ========================================================
>+dnl = Enable feeds (new feed handling/processing)
>+dnl ========================================================
>+MOZ_ARG_ENABLE_BOOL(feeds,
>+[  --enable-feeds        Enable in-page feed handling and processing

This sohould be
[  --enable-feeds        Enable in-page feed handling and processing],

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: more complete patch

Adds support for:

- feed: protocol
- window.goats.registerContentHandler/registerProtocolHandler (to be moved and more completely implemented later)
- web feed handlers (magic!)
- gzip decoding for the content sniffer

Much remains before any of this can be turned on, but closer to checkin.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Includes support for:

- client readers

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

more work on the web handler registry

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, less some extraneous stuff

Comment 8

[Robert Sayre]

I tried applying the latest patch, but it seems to be missing the file WebContentConverter.js. Is it necessary, or can it be removed from the Makefile?

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch, with WCCR this time

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: gigantor patch for checkin

Comment 11

[Phil Ringnalda (:philor)]

Why the extra sniff for the RDF namespace URI? What would have "<rdf:RDF" and the RSS 1.0 namespace URI, but not the RDF namespace URI?

Comment 12

[Brett Wilson]

Comment on attachment 219836 [details] [diff] [review]
gigantor patch for checkin

It seems weird to me to pass URIs as AStrings. Usually I think we do it with UTF8 or nsIURI.

(We discussed changing the pref names in person.)

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: configure changes only

Comment 14

[Benjamin Smedberg]

Comment on attachment 219898 [details] [diff] [review]
configure changes only

Please add "(Firefox)" to the configure help text, so it's clear this is a firefox-only configure option.

Comment 15

[Axel Hecht [:Pike]]

Is the check-in of the empty (and unused, AFAICT) feedhandler.properties on 
purpose?

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: further work

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: some more tweaking - make client and live bookmark handlers work

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: safe exception handling for preferences

Comment 19

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: more browser integration

This does a bunch of opportunistic browser integration:

- makes the feed icon in the url bar show the preview page instead of "Add Live Bookmark" + updates tooltip text etc to not mention Live Bookmarks rather just say "Subscribe"...
- adds "Choose Feed Reader..." button to the general page of preferences (tbd: better location)
- do not register window.goats as a property on web page window objects, instead just seed the web content type handler registry with some demo links for a2 in firefox.js

brett: review this and my next patch will be to fix the pref names, promise!

Comment 20

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: move prefs into numbered branches per brettw request

moves browser.contentType.types.type0 etc to:

browser.contentType.types.0.type
browser.contentType.types.0.uri
browser.contentType.types.0.title

Comment 21

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: add skin files to pinstripe, too

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: fix small typo in subscribe.css

ensure we include the correct image

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: discover system default feed handler on windows

Comment 24

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to make nsFeedSniffer compile on the branch

Comment 25

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: turn on feeds + address some sniffer review comments from darin

Comment 26

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060504 BonEcho/2.0a1 ID:2006050419

Bug on Subscription Options Window
screen shot : http://img157.imageshack.us/img157/8027/asa7eu.jpg

Comment 27

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060504 Minefield/3.0a1 ID:2006050417 [cairo]

acc Tinderbox->Turned ON on trunk
but it does not work at all.
"This XML file does not appear to have any style information associated with it. The document tree is shown below." message for every feed I tried

Comment 28

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060504 Minefield/3.0a1 ID:2006050417 [cairo]

new profile and no extension/theme (all default).

Bug on Subscription Options Window
screen shot : http://img85.imageshack.us/img85/4180/rss8kf.jpg

Comment 29

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060505 BonEcho/2.0a1 ID:2006050504

JS console error, if click/select "Use a Web Site"

screen shot : http://img317.imageshack.us/img317/1488/uws0lz.jpg

Comment 30

[Boris Zbarsky [:bzbarsky]]

So this is spamming my terminal with things like:

  *** WCCR.init: There are 4 handlers registered in preferences.

at startup in an opt build.  Could we please make debug output #ifdef DEBUG or something?

Comment 31

[Phil Ringnalda (:philor)]

*** Bug 294715 has been marked as a duplicate of this bug. ***

Comment 32

[Doug Shelton]

These commits caused a regression under BeOS.  "General" Preferences pane no longer functions.  Bug 342639 opened for BeOS bug.

Comment 33

[Robert Sayre]

don't see why this is open. marking fixed