Closed Bug 336858 Opened 18 years ago Closed 18 years ago

feed content preview not linkified with Atom feeds

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: bugmozz, Assigned: sayrer)

References

(
URL
)

Details

(Keywords: fixed1.8.1, Whiteboard: [swag: 1d])

Attachments

(1 file)

Atom links, xml:base for relative references, and 11 unit tests
29.39 KB, patch
bugs
: review+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060505 BonEcho/2.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060505 BonEcho/2.0a1 ID:2006050522

about Feed Reader.

exsample : http://www.mozillazine.org/
[screen shot]
ATOM : http://img139.imageshack.us/img139/2838/atom9qg.jpg
RSS : http://img139.imageshack.us/img139/5789/rss0bn.jpg

Reproducible: Always
also visible at www.licadho.org/feed.xml (atom 1.0 feed)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060507 BonEcho/2.0a1 ID:2006050704

I can see this too.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Confirmed on Mac OS X, trunk build

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060507 Minefield/3.0a1 ID:2006050705
URL: http://www.mozillazine.org/ → http://www.mozillazine.org/atom.xml
Summary: if Feed is ATOM, Content does not displayed. → feed preview/subscribe page empty with Atom feeds
Blocks: 325085
Changing summary to be more accurate.
Summary: feed preview/subscribe page empty with Atom feeds → Empty feed content preview with Atom feeds
same with my blog http://supernova00.biz/blog/atom.xml

Showed up fine the first time the feed preview landed a few months ago
Flags: blocking-firefox2?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060508 BonEcho/2.0a1 ID:2006050803
seems to be fixed.

screen shot: http://img430.imageshack.us/img430/2928/atom0rz.jpg
Yeah, the feed content is displayed, but it's not "linkified". That's probably due to the changes from bug 336903:
http://bonsai.mozilla.org/cvsquery.cgi?branch=&sortby=Date&hours=2&date=explicit&mindate=2006-05-07+21%3A20&maxdate=2006-05-07+21%3A21

RSS feeds are linkified, atom feeds are not. Compare:
http://www.mozillazine.org/contents.rdf
http://www.mozillazine.org/atom.xml
Summary: Empty feed content preview with Atom feeds → feed content preview not linkified with Atom feeds
Whiteboard: see comment 7
Target Milestone: --- → Firefox 2 alpha2
retargetted at beta 1
Target Milestone: Firefox 2 alpha2 → Firefox 2 beta1
well, since I didn't get a chance to write the Atom link code in the friday-or-feeds-are-cut rush, this behavior is to be expected.
Blocks: 325080
No longer blocks: 325085
Status: NEW → ASSIGNED
Assignee: nobody → sayrer
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: see comment 7 → [swag: 2d]
Whiteboard: [swag: 2d] → [swag: 1d]

        Attachment #227028 -
        Flags: review?(bugs)

        Attachment #227028 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 227028 [details] [diff] [review]
Atom links, xml:base for relative references, and 11 unit tests

please get this reviewed and landed on trunk for baking before requesting review.

        Attachment #227028 -
        Flags: approval1.8.1?
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2

    
    

    
  
Comment on attachment 227028 [details] [diff] [review]
Atom links, xml:base for relative references, and 11 unit tests

r=ben@mozilla.org

        Attachment #227028 -
        Flags: review?(bugs) → review+

    
    

    
  
Checking in public/nsIFeedContainer.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedContainer.idl,v  <--  nsIFeedContainer.idl
new revision: 1.2; previous revision: 1.1
done
Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts.xml,v
done
Checking in test/xml/rfc4287/entry_link_2alts.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts.xml,v  <--  entry_link_2alts.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore.xml,v
done
Checking in test/xml/rfc4287/entry_link_2alts_allcore.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore.xml,v  <--  entry_link_2alts_allcore.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore2.xml,v
done
Checking in test/xml/rfc4287/entry_link_2alts_allcore2.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore2.xml,v  <--  entry_link_2alts_allcore2.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_IANA.xml,v
done
Checking in test/xml/rfc4287/entry_link_IANA.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_IANA.xml,v  <--  entry_link_IANA.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_alt_extension.xml,v
done
Checking in test/xml/rfc4287/entry_link_alt_extension.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_alt_extension.xml,v  <--  entry_link_alt_extension.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_otherURI_alt.xml,v
done
Checking in test/xml/rfc4287/entry_link_otherURI_alt.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_otherURI_alt.xml,v  <--  entry_link_otherURI_alt.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_payment_alt.xml,v
done
Checking in test/xml/rfc4287/entry_link_payment_alt.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_payment_alt.xml,v  <--  entry_link_payment_alt.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_random.xml,v
done
Checking in test/xml/rfc4287/entry_link_random.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_random.xml,v  <--  entry_link_random.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase.xml,v
done
Checking in test/xml/rfc4287/entry_xmlBase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase.xml,v  <--  entry_xmlBase.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase_on_link.xml,v
done
Checking in test/xml/rfc4287/entry_xmlBase_on_link.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase_on_link.xml,v  <--  entry_xmlBase_on_link.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_xmlBase.xml,v
done
Checking in test/xml/rfc4287/feed_xmlBase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_xmlBase.xml,v  <--  feed_xmlBase.xml
initial revision: 1.1
done


    
  
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 227028 [details] [diff] [review]
Atom links, xml:base for relative references, and 11 unit tests

nsIFeedContainer needs a new IID

    
    

    
  
(In reply to comment #14)
> (From update of attachment 227028 [details] [diff] [review] [edit])
> nsIFeedContainer needs a new IID

I treated this as bustage and checked in a fix.

    
  

        Attachment #227028 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 227028 [details] [diff] [review]
Atom links, xml:base for relative references, and 11 unit tests

a=schrep for drivers please be sure up update the IID on branch

        Attachment #227028 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Checking in public/nsIFeedContainer.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedContainer.idl,v  <--  nsIFeedContainer.idl
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Checking in test/xml/rfc4287/entry_link_2alts.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts.xml,v  <--  entry_link_2alts.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_2alts_allcore.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore.xml,v  <--  entry_link_2alts_allcore.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_2alts_allcore2.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore2.xml,v  <--  entry_link_2alts_allcore2.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_IANA.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_IANA.xml,v  <--  entry_link_IANA.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_alt_extension.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_alt_extension.xml,v  <--  entry_link_alt_extension.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_otherURI_alt.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_otherURI_alt.xml,v  <--  entry_link_otherURI_alt.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_payment_alt.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_payment_alt.xml,v  <--  entry_link_payment_alt.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_random.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_random.xml,v  <--  entry_link_random.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_xmlBase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase.xml,v  <--  entry_xmlBase.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_xmlBase_on_link.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase_on_link.xml,v  <--  entry_xmlBase_on_link.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/feed_xmlBase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_xmlBase.xml,v  <--  feed_xmlBase.xml
new revision: 1.1.2.1; previous revision: 1.1
done

Keywords: fixed1.8.1

    
    

    
  
*** Bug 344593 has been marked as a duplicate of this bug. ***

    
    

    
  
This patch fixes half of the problem; now atom feeds will display title and link but not the <content> of an atom item, nor the logo associated with that feed.

http://www.licadho.org/feed.xml 

    
    

    
  
For what it's worth, on trunk you can just ask the nodes for their base URI (as an nsIURI)...

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: