336858 - feed content preview not linkified with Atom feeds

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)

Description

[pal-moz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060505 BonEcho/2.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060505 BonEcho/2.0a1 ID:2006050522

about Feed Reader.

exsample : http://www.mozillazine.org/
[screen shot]
ATOM : http://img139.imageshack.us/img139/2838/atom9qg.jpg
RSS : http://img139.imageshack.us/img139/5789/rss0bn.jpg

Reproducible: Always

Comment 1

[Mathieu Pellerin]

also visible at www.licadho.org/feed.xml (atom 1.0 feed)

Comment 2

[Adam Kowalczyk]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060507 BonEcho/2.0a1 ID:2006050704

I can see this too.

Comment 3

[philippe (part-time)]

Confirmed on Mac OS X, trunk build

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060507 Minefield/3.0a1 ID:2006050705

Comment 4

[Adam Kowalczyk]

Changing summary to be more accurate.

Comment 5

[u88484]

same with my blog http://supernova00.biz/blog/atom.xml

Showed up fine the first time the feed preview landed a few months ago

Comment 6

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060508 BonEcho/2.0a1 ID:2006050803
seems to be fixed.

screen shot: http://img430.imageshack.us/img430/2928/atom0rz.jpg

Comment 7

[Steffen Wilberg]

Yeah, the feed content is displayed, but it's not "linkified". That's probably due to the changes from bug 336903:
http://bonsai.mozilla.org/cvsquery.cgi?branch=&sortby=Date&hours=2&date=explicit&mindate=2006-05-07+21%3A20&maxdate=2006-05-07+21%3A21

RSS feeds are linkified, atom feeds are not. Compare:
http://www.mozillazine.org/contents.rdf
http://www.mozillazine.org/atom.xml

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

retargetted at beta 1

Comment 9

[Robert Sayre]

well, since I didn't get a chance to write the Atom link code in the friday-or-feeds-are-cut rush, this behavior is to be expected.

Comment 10

[Robert Sayre]

Attachment: Atom links, xml:base for relative references, and 11 unit tests

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 227028 [details] [diff] [review]
Atom links, xml:base for relative references, and 11 unit tests

please get this reviewed and landed on trunk for baking before requesting review.

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 227028 [details] [diff] [review]
Atom links, xml:base for relative references, and 11 unit tests

r=[e-mail]

Comment 13

[Robert Sayre]

Checking in public/nsIFeedContainer.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedContainer.idl,v  <--  nsIFeedContainer.idl
new revision: 1.2; previous revision: 1.1
done
Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts.xml,v
done
Checking in test/xml/rfc4287/entry_link_2alts.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts.xml,v  <--  entry_link_2alts.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore.xml,v
done
Checking in test/xml/rfc4287/entry_link_2alts_allcore.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore.xml,v  <--  entry_link_2alts_allcore.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore2.xml,v
done
Checking in test/xml/rfc4287/entry_link_2alts_allcore2.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore2.xml,v  <--  entry_link_2alts_allcore2.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_IANA.xml,v
done
Checking in test/xml/rfc4287/entry_link_IANA.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_IANA.xml,v  <--  entry_link_IANA.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_alt_extension.xml,v
done
Checking in test/xml/rfc4287/entry_link_alt_extension.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_alt_extension.xml,v  <--  entry_link_alt_extension.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_otherURI_alt.xml,v
done
Checking in test/xml/rfc4287/entry_link_otherURI_alt.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_otherURI_alt.xml,v  <--  entry_link_otherURI_alt.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_payment_alt.xml,v
done
Checking in test/xml/rfc4287/entry_link_payment_alt.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_payment_alt.xml,v  <--  entry_link_payment_alt.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_random.xml,v
done
Checking in test/xml/rfc4287/entry_link_random.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_random.xml,v  <--  entry_link_random.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase.xml,v
done
Checking in test/xml/rfc4287/entry_xmlBase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase.xml,v  <--  entry_xmlBase.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase_on_link.xml,v
done
Checking in test/xml/rfc4287/entry_xmlBase_on_link.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase_on_link.xml,v  <--  entry_xmlBase_on_link.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_xmlBase.xml,v
done
Checking in test/xml/rfc4287/feed_xmlBase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_xmlBase.xml,v  <--  feed_xmlBase.xml
initial revision: 1.1
done

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 227028 [details] [diff] [review]
Atom links, xml:base for relative references, and 11 unit tests

nsIFeedContainer needs a new IID

Comment 15

[Robert Sayre]

(In reply to comment #14)
> (From update of attachment 227028 [details] [diff] [review] [edit])
> nsIFeedContainer needs a new IID

I treated this as bustage and checked in a fix.

Comment 16

[Mike Schroepfer]

Comment on attachment 227028 [details] [diff] [review]
Atom links, xml:base for relative references, and 11 unit tests

a=schrep for drivers please be sure up update the IID on branch

Comment 17

[Robert Sayre]

Checking in public/nsIFeedContainer.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedContainer.idl,v  <--  nsIFeedContainer.idl
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
Checking in test/xml/rfc4287/entry_link_2alts.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts.xml,v  <--  entry_link_2alts.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_2alts_allcore.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore.xml,v  <--  entry_link_2alts_allcore.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_2alts_allcore2.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_2alts_allcore2.xml,v  <--  entry_link_2alts_allcore2.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_IANA.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_IANA.xml,v  <--  entry_link_IANA.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_alt_extension.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_alt_extension.xml,v  <--  entry_link_alt_extension.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_otherURI_alt.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_otherURI_alt.xml,v  <--  entry_link_otherURI_alt.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_payment_alt.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_payment_alt.xml,v  <--  entry_link_payment_alt.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_link_random.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_link_random.xml,v  <--  entry_link_random.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_xmlBase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase.xml,v  <--  entry_xmlBase.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/entry_xmlBase_on_link.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_xmlBase_on_link.xml,v  <--  entry_xmlBase_on_link.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/feed_xmlBase.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_xmlBase.xml,v  <--  feed_xmlBase.xml
new revision: 1.1.2.1; previous revision: 1.1
done

Comment 18

[Phil Ringnalda (:philor)]

*** Bug 344593 has been marked as a duplicate of this bug. ***

Comment 19

[Mathieu Pellerin]

This patch fixes half of the problem; now atom feeds will display title and link but not the <content> of an atom item, nor the logo associated with that feed.

http://www.licadho.org/feed.xml 

Comment 20

[Boris Zbarsky [:bzbarsky]]

For what it's worth, on trunk you can just ask the nodes for their base URI (as an nsIURI)...