338254 - When closing tabs, the close buttons don't always come back (per min clip width pref)

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Chris Zubak-Skees]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060512 BonEcho/2.0a2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060512 BonEcho/2.0a2

When opening many tabs 2.0 Alpha 2 changes the tab close button to be the current tab only. The problem is that this switchover starts for me when I open 8 tabs, but doesn't change back to all tabs until 6 tabs. The behavior should be consistent, it should switch to currently selected tabs at 8 and all tabs at 7.

Reproducible: Always

Steps to Reproduce:
1. Open 7 tabs. Note that tab close buttons are on every tab.
2. Open 1 more tab. Note that tab close button is only on currently selected tab.
3. Close 1 tab. Note that tab close button is still only on currently selected tab, despite now having the same number of tabs as in step 1.
4. Close 1 more tab. Note that tab close buttons are now on every tab.
Actual Results:  
The point at which the close button is on every tab varies. Before opening 8 it is 7, after it is 6.

Expected Results:  
The point at which the close button is on every tab should always be the same. If I open 8 tabs it should make the switchover at 8 and go back at 7.

I quote specific numbers of tabs here, but it is very possible this varies based on screen size/resolution. When reproducing try seeing where this hand off occurs for you, instead of taking my numbers as gospel.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060516 Minefield/3.0a1
I see that, too, but only if the selected tab is not the first.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This might be fixed by bug 337514.

Comment 3

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #2)
> 
That's an easy one to try out, but no, it does not fix it.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Thanks for testing.

Comment 5

[Chris Zubak-Skees]

(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060516
> Minefield/3.0a1
> I see that, too, but only if the selected tab is not the first.
> 

For 2.0 Alpha 2 it occurs regardless of which tab is selected.

Comment 6

[Chris Zubak-Skees]

Just downloaded the latest trunk nightly and got the same behavior.

Comment 7

[Peter Kasting]

*** Bug 344193 has been marked as a duplicate of this bug. ***

Comment 8

[Phil Ringnalda (:philor)]

*** Bug 344460 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

I don't think this is worth blocking on - it's a nice polish thing to get right, though, so if we get a small, safe, baked patch please nominate for approval1.8.1

Comment 10

[Asaf Romano (gone)]

My patch for bug 343585 is going to fix this, i think.

Comment 11

[Asaf Romano (gone)]

Fixed in bug 343585.