338661 - [session store] tabs are blank during session restoration

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Nickolay_Ponomarev]

If the saved session contains many tabs (say, 10), it is apparent that session store first opens all the tabs with about:blank in them, then starts loading pages in the opened tabs.

It's fine that we don't load all the tabs at the same moment, but the "(Untitled)" tabs do look a bit unpolished.

Perhaps we could mimic the 'loading' state for those tabs. Or maybe they shouldn't just be all opened at once.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060519 BonEcho/2.0a2

Comment 1

[Simon Bünzli]

Attachment: set "busy" state before restoring tab history

Unless the tabs shouldn't be loaded all at the start, a short period of displaying "(Untitled)" is inevitable because of about:blank being loaded in the new tabs. I still prefer this solution since the users sees from the beginning how many tabs will be restored (i.e. that all tabs were saved).

Comment 2

[Simon Bünzli]

Attachment: use the tabbrowser's methods for setting the "busy" state

Simplified the above patch using the methods used by the tabbrowser itself (see http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#318 ). Sorry for the bugspam.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/sessionstore/src/nsSessionStore.js 	1.5.2.6
mozilla/browser/components/sessionstore/src/nsSessionStore.js 	1.14

Comment 4

[Simon Bünzli]

The branch check-in caused bug 340301.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Backed out the branch patch until the patch for bug 292865 is landed.

Comment 6

[Nickolay_Ponomarev]

This missed beta 1.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/sessionstore/src/nsSessionStore.js 	1.5.2.21

Comment 8

[tabmix.onemen]

look like the tabs show "Loading..." for split second then "Untitled" again and then they start loading again.
maybe about:blank didn't completed loading after all.

this fix the problem

-   // mark the tabs as loading (at this point about:blank
-   // has completed loading in all tabs, so it won't interfere)
+   // mark the tabs as loading
    for (t = 0; t < aTabs.length; t++) {
      var tab = aTabs[t]._tab;
+     tabbrowser.getBrowserForTab(tab).stop();
      tab.setAttribute("busy", "true");
      tabbrowser.updateIcon(tab);
      tabbrowser.setTabTitleLoading(tab);
    }

or maybe change in addTab to stop "about:blank" tabs to.

Comment 9

[Simon Bünzli]

(In reply to comment #8)
> look like the tabs show "Loading..." for split second then "Untitled" again and
> then they start loading again.

Please file a new bug for this issue.

Comment 10

[tabmix.onemen]

Y not to reopen this bug ?

Comment 11

[Simon Bünzli]

(In reply to comment #10)
> Y not to reopen this bug ?

That's not how it works. The issue as filed is fixed and the patch hasn't caused severe regressions of any kind nor had to be backed out again. In this case, a follow up bug is the way to go...