340301 - Branch patch to bug 338661 broke session restoration

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Simon Bünzli]

<tabbrowser/> doesn't feature the setTabTitleLoading method on the branch because the patch to bug 292865 hasn't landed yet.

Comment 1

[Simon Bünzli]

Attachment: add the setTabTitleLoading bits from bug 292865

The alternative would be to replace the call to setTabTitleLoading with

tab.label = tabbrowser.mStringBundle.getString("tabs.loading");

in nsSessionStore.js. However that seems a little bit too hacky IMO (after all, the string bundle is supposed to be private).

Comment 2

[:Gavin Sharp [email: [e-mail]]]

We should just land all of bug 292865's patch.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I backed out the patch for bug 338661. We can reland it on the branch when 292865's patch lands, so I think this bug can be closed now.