339416 - Error: this.getTabBrowser() has no properties

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Jo Hermans]

Error: this.getTabBrowser() has no properties
Source File: file:///Applications/BonEcho.app/Contents/MacOS/components/nsSafebrowsingApplication.js
Line: 516

tested with the 20060526 build on Mac OS X 10.2.8, just before it got labeled 2.0a2.
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a2) Gecko/20060526 BonEcho/2.0a2

The error points to this line in G_TabbedBrowserWatcher :
this.tabbox_ = this.getTabBrowser().mTabBox;

Comment 1

[R Vietri]

Steps to reproduce? Have you tried with Alpha 3?

Comment 2

[Jo Hermans]

I see it in Alpha 3 too.

To reproduce : just start the browser and open the Javascript console. There will be 1 warning in the list. Note that there will be a new warning appearing a few seconds every time the console is opened (at least, that's how the timing is for me).

Comment 3

[Jo Hermans]

*** Bug 339779 has been marked as a duplicate of this bug. ***

Comment 4

[Tony Chang (Google)]

Attachment: v1: give up if no "content" element

This is just a workaround for bug 342925.  Specifically, sb-loader.js seems to be getting included in some non-browser XUL file causing it to throw the error.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 227333 [details] [diff] [review]
v1: give up if no "content" element

I'd rather have a _slightly_ more verbose description of the problem (for example, "if this script is loaded into a non-browser window")

Comment 6

[Tony Chang (Google)]

Attachment: v2: give up if no "content" element

Made the comment more descriptive.

I'm going to see if there's a smarter way to do this before landing on trunk (this doesn't feel right . . .).

Comment 7

[Tony Chang (Google)]

Attachment: v3: move sb-loader.js into browser.xul

And here's the correct way to solve the problem.

Comment 8

[Zach Lipton [:zach]]

I have tested this patch on the mac branch and it fixes the session-restore cancel button issue described in bug 342543.

Comment 9

[Tony Chang (Google)]

on trunk

Comment 10

[Darin Fisher]

Comment on attachment 227376 [details] [diff] [review]
v3: move sb-loader.js into browser.xul

a=darin on behalf of drivers

Comment 11

[Tony Chang (Google)]

on branch