Closed
Bug 339416
Opened 18 years ago
Closed 18 years ago
Error: this.getTabBrowser() has no properties
Categories
(Toolkit :: Safe Browsing, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: jo.hermans, Assigned: tony)
References
Details
(Keywords: verified1.8.1)
Attachments
(1 file, 2 obsolete files)
2.26 KB,
patch
|
bryner
:
superreview+
darin.moz
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Error: this.getTabBrowser() has no properties Source File: file:///Applications/BonEcho.app/Contents/MacOS/components/nsSafebrowsingApplication.js Line: 516 tested with the 20060526 build on Mac OS X 10.2.8, just before it got labeled 2.0a2. Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a2) Gecko/20060526 BonEcho/2.0a2 The error points to this line in G_TabbedBrowserWatcher : this.tabbox_ = this.getTabBrowser().mTabBox;
Reporter | ||
Comment 2•18 years ago
|
||
I see it in Alpha 3 too. To reproduce : just start the browser and open the Javascript console. There will be 1 warning in the list. Note that there will be a new warning appearing a few seconds every time the console is opened (at least, that's how the timing is for me).
Reporter | ||
Comment 3•18 years ago
|
||
*** Bug 339779 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•18 years ago
|
Assignee: nobody → tony
Assignee | ||
Comment 4•18 years ago
|
||
This is just a workaround for bug 342925. Specifically, sb-loader.js seems to be getting included in some non-browser XUL file causing it to throw the error.
Attachment #227333 -
Flags: review?(dietrich)
Updated•18 years ago
|
Attachment #227333 -
Flags: review?(dietrich) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #227333 -
Flags: superreview?(bryner)
Comment 5•18 years ago
|
||
Comment on attachment 227333 [details] [diff] [review] v1: give up if no "content" element I'd rather have a _slightly_ more verbose description of the problem (for example, "if this script is loaded into a non-browser window")
Attachment #227333 -
Flags: superreview?(bryner) → superreview+
Assignee | ||
Comment 6•18 years ago
|
||
Made the comment more descriptive. I'm going to see if there's a smarter way to do this before landing on trunk (this doesn't feel right . . .).
Attachment #227333 -
Attachment is obsolete: true
Assignee | ||
Comment 7•18 years ago
|
||
And here's the correct way to solve the problem.
Attachment #227368 -
Attachment is obsolete: true
Attachment #227376 -
Flags: superreview?(bryner)
Comment 8•18 years ago
|
||
I have tested this patch on the mac branch and it fixes the session-restore cancel button issue described in bug 342543.
Updated•18 years ago
|
Attachment #227376 -
Flags: superreview?(bryner) → superreview+
Assignee | ||
Comment 9•18 years ago
|
||
on trunk
Assignee | ||
Updated•18 years ago
|
Attachment #227376 -
Flags: approval1.8.1?
Comment 10•18 years ago
|
||
Comment on attachment 227376 [details] [diff] [review] v3: move sb-loader.js into browser.xul a=darin on behalf of drivers
Attachment #227376 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 11•18 years ago
|
||
on branch
Reporter | ||
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•